Re: [alsa-devel] [PATCH] Fix request_irq error handling
Hah, um, ignore me. It seems that my c needs some work ;) In if(some_expression), I always though it is true if the expression is > 0, not != 0. If anything, that was a CodingStyle patch because it lets us see exactly what we're getting from request_irq but I can see that it is totally unnecessary :)
----- Original Message ----- From: "Ash Willis" ashwillis@programmer.net To: alsa-devel@alsa-project.org Subject: [alsa-devel] [PATCH] Fix request_irq error handling Date: Sat, 14 Jul 2007 02:29:19 -0500
request_irq returns 0 on success and a negative code on failure. Many ALSA drivers incorrectly check for failure by testing for a positive code instead of a negative one.
Signed-Off-By: Ash Willis ashwillis@programmer.net
-- We've Got Your Name at http://www.mail.com! Get a FREE E-mail Account Today - Choose From 100+ Domains << request_irq_error_handling.patch >>
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Sat, 14 Jul 2007 14:22:14 -0500, Ash Willis wrote:
Hah, um, ignore me. It seems that my c needs some work ;) In if(some_expression), I always though it is true if the expression is > 0, not != 0. If anything, that was a CodingStyle patch because it lets us see exactly what we're getting from request_irq but I can see that it is totally unnecessary :)
Yep, the code works as it is. Let's clean up this later, after 2.6.23 merge window.
thanks,
Takashi
participants (2)
-
Ash Willis
-
Takashi Iwai