[PATCH 0/2] Adjust Stream Name and DT Bindings Updates
This patch set proposes the following changes to improve the flexibility and configurability of the mchp-i2s-mcc driver by allowing the interface name to be set through the device tree and by introducing a new property to better manage multiple interfaces.
Codrin Ciubotariu (2): ASoC: atmel: mchp-i2s-mcc: Remove interface name from stream_name ASoC: dt-bindings: microchip,sama7g5-i2smcc: Add 'sound-name-prefix' property
.../bindings/sound/microchip,sama7g5-i2smcc.yaml | 7 +++++++ sound/soc/atmel/mchp-i2s-mcc.c | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)
base-commit: 9aaeb87ce1e966169a57f53a02ba05b30880ffb8
From: Codrin Ciubotariu codrin.ciubotariu@microchip.com
Remove the interface name from the stream_name. The interface name (and the index of the interface) can be set in DT using the sound-name-prefix string property.
[andrei.simion@microchip: Adjust the commit title]
Signed-off-by: Codrin Ciubotariu codrin.ciubotariu@microchip.com Signed-off-by: Andrei Simion andrei.simion@microchip.com --- sound/soc/atmel/mchp-i2s-mcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c index 35a56b266b8d..f40508668ac5 100644 --- a/sound/soc/atmel/mchp-i2s-mcc.c +++ b/sound/soc/atmel/mchp-i2s-mcc.c @@ -936,14 +936,14 @@ static const struct snd_soc_dai_ops mchp_i2s_mcc_dai_ops = {
static struct snd_soc_dai_driver mchp_i2s_mcc_dai = { .playback = { - .stream_name = "I2SMCC-Playback", + .stream_name = "Playback", .channels_min = 1, .channels_max = 8, .rates = MCHP_I2SMCC_RATES, .formats = MCHP_I2SMCC_FORMATS, }, .capture = { - .stream_name = "I2SMCC-Capture", + .stream_name = "Capture", .channels_min = 1, .channels_max = 8, .rates = MCHP_I2SMCC_RATES,
From: Codrin Ciubotariu codrin.ciubotariu@microchip.com
Add 'sound-name-prefix' property to differentiate between interfaces in DPCM use-cases. Property is optional.
[andrei.simion@microchip.com: Adjust the commit title and message. Reword the description for 'sound-name-prefix'.]
Signed-off-by: Codrin Ciubotariu codrin.ciubotariu@microchip.com Signed-off-by: Andrei Simion andrei.simion@microchip.com --- .../bindings/sound/microchip,sama7g5-i2smcc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml index fb630a184350..ad34df67c7c0 100644 --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml @@ -52,6 +52,13 @@ properties: - const: gclk minItems: 1
+ sound-name-prefix: + pattern: "^I2SMCC[0-9]$" + $ref: /schemas/types.yaml#/definitions/string + description: + Unique prefixes for the sink/source names of the component, ensuring + distinct identification among multiple instances. + dmas: items: - description: TX DMA Channel
On 09/09/2024 10:35, Andrei Simion wrote:
From: Codrin Ciubotariu codrin.ciubotariu@microchip.com
Add 'sound-name-prefix' property to differentiate between interfaces in DPCM use-cases. Property is optional.
[andrei.simion@microchip.com: Adjust the commit title and message. Reword the description for 'sound-name-prefix'.]
Signed-off-by: Codrin Ciubotariu codrin.ciubotariu@microchip.com Signed-off-by: Andrei Simion andrei.simion@microchip.com
.../bindings/sound/microchip,sama7g5-i2smcc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml index fb630a184350..ad34df67c7c0 100644 --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml @@ -52,6 +52,13 @@ properties: - const: gclk minItems: 1
- sound-name-prefix:
- pattern: "^I2SMCC[0-9]$"
This does not look correct. Name/prefix can be anything matching real hardware, why are you restricting it? How can you predict all names?
- $ref: /schemas/types.yaml#/definitions/string
- description:
Unique prefixes for the sink/source names of the component, ensuringdistinct identification among multiple instances.
You are duplicating property definitions. This is not needed at all. Maybe your schema misses $ref to common schema.
Best regards, Krzysztof
On 09.09.2024 11:38, Krzysztof Kozlowski wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
On 09/09/2024 10:35, Andrei Simion wrote:
From: Codrin Ciubotariu codrin.ciubotariu@microchip.com
Add 'sound-name-prefix' property to differentiate between interfaces in DPCM use-cases. Property is optional.
[andrei.simion@microchip.com: Adjust the commit title and message. Reword the description for 'sound-name-prefix'.]
Signed-off-by: Codrin Ciubotariu codrin.ciubotariu@microchip.com Signed-off-by: Andrei Simion andrei.simion@microchip.com
.../bindings/sound/microchip,sama7g5-i2smcc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml index fb630a184350..ad34df67c7c0 100644 --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml @@ -52,6 +52,13 @@ properties: - const: gclk minItems: 1
- sound-name-prefix:
- pattern: "^I2SMCC[0-9]$"
This does not look correct. Name/prefix can be anything matching real hardware, why are you restricting it? How can you predict all names?
Based on the datasheet, the SoC(s) have the following naming conventions: - sama7g5: I2SMCC0 and I2SMCC1 - sam9x60/sam9x75: I2SMCC
To accommodate these variations, I propose using a more relaxed pattern: "^I2SMCC(0-9)?$". This pattern allows for both the fixed prefix and an optional single digit at the end. What are your thoughts on this approach?
- $ref: /schemas/types.yaml#/definitions/string
- description:
Unique prefixes for the sink/source names of the component, ensuringdistinct identification among multiple instances.You are duplicating property definitions. This is not needed at all. Maybe your schema misses $ref to common schema.
I understand the concern about duplicating property definitions. In the current file, I have referenced `dai-common` as shown here: https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindi...
Could you please confirm if this reference is correctly implemented, or suggest any adjustments needed to align with the common schema?
Best Regards, Andrei Simion
Best regards, Krzysztof
On 09/09/2024 14:28, Andrei.Simion@microchip.com wrote:
minItems: 1
- sound-name-prefix:
- pattern: "^I2SMCC[0-9]$"
This does not look correct. Name/prefix can be anything matching real hardware, why are you restricting it? How can you predict all names?
Based on the datasheet, the SoC(s) have the following naming conventions:
- sama7g5: I2SMCC0 and I2SMCC1
- sam9x60/sam9x75: I2SMCC
To accommodate these variations, I propose using a more relaxed pattern: "^I2SMCC(0-9)?$". This pattern allows for both the fixed prefix and an optional single digit at the end. What are your thoughts on this approach?
I understand this does not differ per board, because it is component of the SoC, yet still I do not see any value in enforcing name.
- $ref: /schemas/types.yaml#/definitions/string
- description:
Unique prefixes for the sink/source names of the component, ensuringdistinct identification among multiple instances.You are duplicating property definitions. This is not needed at all. Maybe your schema misses $ref to common schema.
I understand the concern about duplicating property definitions. In the current file, I have referenced `dai-common` as shown here: https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindi...
Could you please confirm if this reference is correctly implemented,
Yeah, the dai-common $ref is correct, so you should not need it. Do you see any warning?
or suggest any adjustments needed to align with the common schema?
I claim nothing has to be done and entire patch is redundant or not much helpful. Your commit msg did not explain *why* this is needed and what problem you are fixing, so what I can say? I don't know why should be aligned because I do not understand the problem being fixed.
Best regards, Krzysztof
On 09/09/2024 10:38, Krzysztof Kozlowski wrote:
On 09/09/2024 10:35, Andrei Simion wrote:
From: Codrin Ciubotariu codrin.ciubotariu@microchip.com
Add 'sound-name-prefix' property to differentiate between interfaces in DPCM use-cases. Property is optional.
[andrei.simion@microchip.com: Adjust the commit title and message. Reword the description for 'sound-name-prefix'.]
Signed-off-by: Codrin Ciubotariu codrin.ciubotariu@microchip.com Signed-off-by: Andrei Simion andrei.simion@microchip.com
.../bindings/sound/microchip,sama7g5-i2smcc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
One more point for future (I missed this before) - be sure you CC necessary lists. Use get_maintainers or b4 for this. Skipping DT list means skipping automation, so this would be a NAK anyway.
Best regards, Krzysztof
On 10.09.2024 10:17, Krzysztof Kozlowski wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
On 09/09/2024 10:38, Krzysztof Kozlowski wrote:
On 09/09/2024 10:35, Andrei Simion wrote:
From: Codrin Ciubotariu codrin.ciubotariu@microchip.com
Add 'sound-name-prefix' property to differentiate between interfaces in DPCM use-cases. Property is optional.
[andrei.simion@microchip.com: Adjust the commit title and message. Reword the description for 'sound-name-prefix'.]
Signed-off-by: Codrin Ciubotariu codrin.ciubotariu@microchip.com Signed-off-by: Andrei Simion andrei.simion@microchip.com
.../bindings/sound/microchip,sama7g5-i2smcc.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
One more point for future (I missed this before) - be sure you CC necessary lists. Use get_maintainers or b4 for this. Skipping DT list means skipping automation, so this would be a NAK anyway.
yes, I will be much more careful. thank you.
Best regards, Andrei Simion
Best regards, Krzysztof
On Mon, 09 Sep 2024 11:35:28 +0300, Andrei Simion wrote:
This patch set proposes the following changes to improve the flexibility and configurability of the mchp-i2s-mcc driver by allowing the interface name to be set through the device tree and by introducing a new property to better manage multiple interfaces.
Codrin Ciubotariu (2): ASoC: atmel: mchp-i2s-mcc: Remove interface name from stream_name ASoC: dt-bindings: microchip,sama7g5-i2smcc: Add 'sound-name-prefix' property
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: atmel: mchp-i2s-mcc: Remove interface name from stream_name commit: b09c71f3e8413ac0a9749f9d0d06f6f0d0b2cc65
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (4)
-
Andrei Simion -
Andrei.Simion＠microchip.com
-
Krzysztof Kozlowski -
Mark Brown