[alsa-devel] [PATCH] slimbus: fix duplicated argument to ||
Remove duplicate argument SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION.
fix below issue reported by coccicheck ./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or ||
Signed-off-by: Hariprasad Kelam hariprasad.kelam@gmail.com --- drivers/slimbus/slimbus.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h index 9be4108..46a6441 100644 --- a/drivers/slimbus/slimbus.h +++ b/drivers/slimbus/slimbus.h @@ -438,8 +438,7 @@ static inline bool slim_tid_txn(u8 mt, u8 mc) return (mt == SLIM_MSG_MT_CORE && (mc == SLIM_MSG_MC_REQUEST_INFORMATION || mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION || - mc == SLIM_MSG_MC_REQUEST_VALUE || - mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION)); + mc == SLIM_MSG_MC_REQUEST_VALUE)); }
static inline bool slim_ec_txn(u8 mt, u8 mc)
On Sun, 2019-07-21 at 23:17 +0530, Hariprasad Kelam wrote:
Remove duplicate argument SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION.
fix below issue reported by coccicheck ./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or ||
Signed-off-by: Hariprasad Kelam hariprasad.kelam@gmail.com
drivers/slimbus/slimbus.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h index 9be4108..46a6441 100644 --- a/drivers/slimbus/slimbus.h +++ b/drivers/slimbus/slimbus.h @@ -438,8 +438,7 @@ static inline bool slim_tid_txn(u8 mt, u8 mc) return (mt == SLIM_MSG_MT_CORE && (mc == SLIM_MSG_MC_REQUEST_INFORMATION || mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION ||
mc == SLIM_MSG_MC_REQUEST_VALUE ||mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION));
mc == SLIM_MSG_MC_REQUEST_VALUE));}
Perhaps this was intended to be mc == SLIM_MSG_MC_REQUEST_CHANGE_VALUE ?
participants (2)
-
Hariprasad Kelam -
Joe Perches