Re: [alsa-devel] [PATCH] ASoC: Constify snd_soc_dai_ops structs
On Wed, Nov 23, 2011 at 11:40:40AM +0100, Lars-Peter Clausen wrote:
Commit 1ee46ebd("ASoC: Make the DAI ops constant in the DAI structure") introduced the possibility to have constant DAI ops structures, yet this is barley used in both existing drivers and also new drivers being submitted, although none of them modifies its DAI ops structure. The later is not surprising since existing drivers are often used as templates for new drivers. So this patch just constifies all existing snd_soc_dai_ops structs to eliminate the issue altogether.
Applied, thanks.
On 11/23/2011 11:47 AM, Mark Brown wrote:
On Wed, Nov 23, 2011 at 11:40:40AM +0100, Lars-Peter Clausen wrote:
Commit 1ee46ebd("ASoC: Make the DAI ops constant in the DAI structure") introduced the possibility to have constant DAI ops structures, yet this is barley used in both existing drivers and also new drivers being submitted, although none of them modifies its DAI ops structure. The later is not surprising since existing drivers are often used as templates for new drivers. So this patch just constifies all existing snd_soc_dai_ops structs to eliminate the issue altogether.
Applied, thanks.
Argh, looks like I have to work a bit more on my coccinelle skills, I introduced a few 'const const struct snd_soc_dai_ops' in this patch, which I overlooked, since this seems to be legal C. Will send a followup cleanup patch.
participants (2)
-
Lars-Peter Clausen -
Mark Brown