Re: [alsa-devel] [PATCH v5 2/2] ASoC: sgtl5000: Fix driver probe after reset
Hi Matt,
On Fri, May 10, 2013 at 2:14 PM, Matt Sealey matt@genesi-usa.com wrote:
Hi Fabio!
Is there any way to make that failure a little less of a "failure" or even a warning, since the message below;
sgtl5000 0-000a: Using internal LDO instead of VDDD
Pretty much covers that VDDD was not supplied. I would consider that you would want to say "VDDD wasn't supplied" in the sense that it is optional and not give in pdata or dt, and then remark that the LDO was actually configured.. I don't like it when my kernels boot up and spit out high numbered errno's for the sake of a completely optional entry in the design vs. missing and still optional entry in the device tree.
Yes, I plan to clean the sgtl5000 log messages. I agree that it is currently too noisy.
Will do it after Mark applies this series.
Regards,
Fabio Estevam
participants (1)
-
Fabio Estevam