[alsa-devel] [PATCH RESEND] ASoC: max98088 - fix element type of the register cache.
From: Chih-Chung Chang chihchung@chromium.org
The registers of max98088 are 8 bits, not 16 bits. This bug causes the contents of registers to be overwritten with bad values when the codec is suspended and then resumed.
Signed-off-by: Chih-Chung Chang chihchung@chromium.org Signed-off-by: Dylan Reid dgreid@chromium.org --- sound/soc/codecs/max98088.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c index 3eeada5..566a367 100644 --- a/sound/soc/codecs/max98088.c +++ b/sound/soc/codecs/max98088.c @@ -1612,7 +1612,7 @@ static int max98088_dai2_digital_mute(struct snd_soc_dai *codec_dai, int mute)
static void max98088_sync_cache(struct snd_soc_codec *codec) { - u16 *reg_cache = codec->reg_cache; + u8 *reg_cache = codec->reg_cache; int i;
if (!codec->cache_sync)
On Mon, Jul 15, 2013 at 09:38:46AM -0700, Dylan Reid wrote:
From: Chih-Chung Chang chihchung@chromium.org
The registers of max98088 are 8 bits, not 16 bits. This bug causes the contents of registers to be overwritten with bad values when the codec is suspended and then resumed.
Applied, thanks, though really this driver ought to be being converted to regmap.
+ Ralph Birt.
Best Regards,
Evan Ragsdale Strategic Applications, Audio Solutions 160 Rio Robles | San Jose, CA 95134 | USA Office: +1 (408) 601-5510 Maxim Integrated | www.maximintegrated.com
-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Monday, July 15, 2013 10:22 AM To: Dylan Reid Cc: alsa-devel@alsa-project.org; lgirdwood@gmail.com; Evan Ragsdale; Chih-Chung Chang Subject: Re: [PATCH RESEND] ASoC: max98088 - fix element type of the register cache.
On Mon, Jul 15, 2013 at 09:38:46AM -0700, Dylan Reid wrote:
From: Chih-Chung Chang chihchung@chromium.org
The registers of max98088 are 8 bits, not 16 bits. This bug causes the contents of registers to be overwritten with bad values when the codec is suspended and then resumed.
Applied, thanks, though really this driver ought to be being converted to regmap.
participants (3)
-
Dylan Reid -
Evan Ragsdale -
Mark Brown