Re: [PATCH 3/3] ASoC: amd: acp: Add legacy audio driver support for Rembrandt platform
On 6/25/2022 8:29 AM, kernel test robot wrote:
[CAUTION: External Email]
Hi sujith,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next] [also build test WARNING on next-20220624] [cannot apply to linus/master v5.19-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit-scm.co...]
url:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com... base:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel... for-next config: i386-allyesconfig compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): #https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com... git remote add linux-reviewhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com... git fetch --no-tags linux-review V-sujith-kumar-Reddy/ADD-legacy-audio-driver-support-for-rembrandt/20220625-035009 git checkout 32f53f63fb2ba0bbf7e8e145879a7340f28ebfbd # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/soc/amd/acp/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robotlkp@intel.com
All warnings (new ones prefixed by >>):
sound/soc/amd/acp/acp-rembrandt.c:264:5: warning: no previous prototype for 'rmb_acp_init' [-Wmissing-prototypes]
264 | int rmb_acp_init(void __iomem *base) | ^~~~~~~~~~~~
Done
sound/soc/amd/acp/acp-rembrandt.c:286:5: warning: no previous prototype for 'rmb_acp_deinit' [-Wmissing-prototypes]
286 | int rmb_acp_deinit(void __iomem *base) | ^~~~~~~~~~~~~~
Done
vim +/rmb_acp_init +264 sound/soc/amd/acp/acp-rembrandt.c
263
264 int rmb_acp_init(void __iomem *base)
265 { 266 int ret; 267 268 /* power on */ 269 ret = acp6x_power_on(base); 270 if (ret) { 271 pr_err("ACP power on failed\n"); 272 return ret; 273 } 274 writel(0x01, base + ACP_CONTROL); 275 276 /* Reset */ 277 ret = acp6x_reset(base); 278 if (ret) { 279 pr_err("ACP reset failed\n"); 280 return ret; 281 } 282 283 return 0; 284 } 285
286 int rmb_acp_deinit(void __iomem *base)
287 { 288 int ret = 0; 289 290 /* Reset */ 291 ret = acp6x_reset(base); 292 if (ret) { 293 pr_err("ACP reset failed\n"); 294 return ret; 295 } 296 297 writel(0x00, base + ACP_CONTROL); 298 299 /* power off */ 300 ret = acp6x_power_off(base); 301 if (ret) { 302 pr_err("ACP power off failed\n"); 303 return ret; 304 } 305 306 return 0; 307 } 308
-- 0-DAY CI Kernel Test Service https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F01.org%2Fl...
participants (1)
-
Reddy, V sujith kumar