[alsa-devel] [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe
Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
Signed-off-by: Axel Lin axel.lin@gmail.com --- sound/soc/fsl/mpc8610_hpcd.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c index 0d7dcf1..7d7847a 100644 --- a/sound/soc/fsl/mpc8610_hpcd.c +++ b/sound/soc/fsl/mpc8610_hpcd.c @@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev) dev_err(&pdev->dev, "platform device add failed\n"); goto error; } + dev_set_drvdata(&pdev->dev, sound_device);
of_node_put(codec_np);
Otherwise, calling dev_get_drvdata in p1022_ds_remove returns NULL.
Signed-off-by: Axel Lin axel.lin@gmail.com --- sound/soc/fsl/p1022_ds.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/fsl/p1022_ds.c b/sound/soc/fsl/p1022_ds.c index 63b9eaa..026b756 100644 --- a/sound/soc/fsl/p1022_ds.c +++ b/sound/soc/fsl/p1022_ds.c @@ -498,6 +498,7 @@ static int p1022_ds_probe(struct platform_device *pdev) dev_err(&pdev->dev, "platform device add failed\n"); goto error; } + dev_set_drvdata(&pdev->dev, sound_device);
of_node_put(codec_np);
On Mon, 2010-11-29 at 14:54 +0800, Axel Lin wrote:
Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
Signed-off-by: Axel Lin axel.lin@gmail.com
sound/soc/fsl/mpc8610_hpcd.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c index 0d7dcf1..7d7847a 100644 --- a/sound/soc/fsl/mpc8610_hpcd.c +++ b/sound/soc/fsl/mpc8610_hpcd.c @@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev) dev_err(&pdev->dev, "platform device add failed\n"); goto error; }
dev_set_drvdata(&pdev->dev, sound_device);
of_node_put(codec_np);
All
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
Axel Lin wrote:
Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
Signed-off-by: Axel Lin axel.lin@gmail.com
Both patches:
Acked-by: Timur Tabi timur@freescale.com
Thanks for catching this.
On Mon, Nov 29, 2010 at 08:53:48AM -0600, Timur Tabi wrote:
Axel Lin wrote:
Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
Signed-off-by: Axel Lin axel.lin@gmail.com
Both patches:
Acked-by: Timur Tabi timur@freescale.com
Applied now.
participants (4)
-
Axel Lin -
Liam Girdwood -
Mark Brown -
Timur Tabi