[alsa-devel] [PATCH 1/2] caiaq/NativeInstruments: input handling fixes
Hi,
I'm re-posting a patch from Dmitry Torokhov which cleans up some input layer related things. It hasn't made its way to any repository yet but my subsequent patch needs it as dependency. I Cc'ed Dmitry to avoid confusion.
Subject: SOUND: caiaq - misc input handling fixes From: Dmitry Torokhov dmitry.torokhov@gmail.com
SOUND: caiaq - misc input handling fixes
- link input device with its parent so that it placed in proper spot in sysfs hierarchy - drivers that allow changing their keymaps should use private copy of the keymap so that one instance of a device does not affect another instance - it is preferred for drivers to properly set up input_dev->phys to help userspace locate devices - drivers should use usb_to_input_id(), or perform endianess conversion, themselves, otherwise ID is not correct on big-endian boxes - whitespace and formatting cleanup
Signed-off-by: Dmitry Torokhov dtor@mail.ru Acked-by: Daniel Mack daniel@caiaq.de
At Tue, 20 Nov 2007 14:35:28 +0100, Daniel Mack wrote:
Hi,
I'm re-posting a patch from Dmitry Torokhov which cleans up some input layer related things. It hasn't made its way to any repository yet but my subsequent patch needs it as dependency. I Cc'ed Dmitry to avoid confusion.
Dmitry, will this patch go to 2.6.24 from your tree?
If it's a 2.6.25 material, then I'd like to put it rather to ALSA tree together with Daniel's another patch.
thanks,
Takashi
On Nov 21, 2007 4:55 AM, Takashi Iwai tiwai@suse.de wrote:
At Tue, 20 Nov 2007 14:35:28 +0100, Daniel Mack wrote:
Hi,
I'm re-posting a patch from Dmitry Torokhov which cleans up some input layer related things. It hasn't made its way to any repository yet but
Yes, I am being slow lately, sorry.
my subsequent patch needs it as dependency. I Cc'ed Dmitry to avoid confusion.
Dmitry, will this patch go to 2.6.24 from your tree?
If it's a 2.6.25 material,
Yes, it is .25 material.
then I'd like to put it rather to ALSA tree together with Daniel's another patch.
Thet would be great. The only reason I offered to send through my tree is that I did not see any response from you guys... I actually prefer not to touch code outside of drivers/input.
BTW, attached is a small Kconfig patchs for caiaq. Probably good for .24.
At Wed, 21 Nov 2007 08:34:33 -0500, Dmitry Torokhov wrote:
On Nov 21, 2007 4:55 AM, Takashi Iwai tiwai@suse.de wrote:
At Tue, 20 Nov 2007 14:35:28 +0100, Daniel Mack wrote:
Hi,
I'm re-posting a patch from Dmitry Torokhov which cleans up some input layer related things. It hasn't made its way to any repository yet but
Yes, I am being slow lately, sorry.
my subsequent patch needs it as dependency. I Cc'ed Dmitry to avoid confusion.
Dmitry, will this patch go to 2.6.24 from your tree?
If it's a 2.6.25 material,
Yes, it is .25 material.
then I'd like to put it rather to ALSA tree together with Daniel's another patch.
Thet would be great. The only reason I offered to send through my tree is that I did not see any response from you guys... I actually prefer not to touch code outside of drivers/input.
Well, I didn't apply it just because I thought you prefer pushing it to 2.6.24 :) If it's for 25, no problem to put to ALSA tree.
BTW, attached is a small Kconfig patchs for caiaq. Probably good for .24.
OK, will add this, too.
Thanks,
Takashi
At Wed, 21 Nov 2007 14:05:56 +0100, I wrote:
At Wed, 21 Nov 2007 08:34:33 -0500, Dmitry Torokhov wrote:
On Nov 21, 2007 4:55 AM, Takashi Iwai tiwai@suse.de wrote:
At Tue, 20 Nov 2007 14:35:28 +0100, Daniel Mack wrote:
Hi,
I'm re-posting a patch from Dmitry Torokhov which cleans up some input layer related things. It hasn't made its way to any repository yet but
Yes, I am being slow lately, sorry.
my subsequent patch needs it as dependency. I Cc'ed Dmitry to avoid confusion.
Dmitry, will this patch go to 2.6.24 from your tree?
If it's a 2.6.25 material,
Yes, it is .25 material.
then I'd like to put it rather to ALSA tree together with Daniel's another patch.
Thet would be great. The only reason I offered to send through my tree is that I did not see any response from you guys... I actually prefer not to touch code outside of drivers/input.
Well, I didn't apply it just because I thought you prefer pushing it to 2.6.24 :) If it's for 25, no problem to put to ALSA tree.
Now it's on ALSA HG tree. I fixed two tiny coding issues checkpatch.pl reported.
BTW, attached is a small Kconfig patchs for caiaq. Probably good for .24.
OK, will add this, too.
Applied this, too.
Thanks.
Takashi
On Nov 21, 2007 10:26 AM, Takashi Iwai tiwai@suse.de wrote:
At Wed, 21 Nov 2007 14:05:56 +0100, I wrote:
At Wed, 21 Nov 2007 08:34:33 -0500, Dmitry Torokhov wrote:
On Nov 21, 2007 4:55 AM, Takashi Iwai tiwai@suse.de wrote:
At Tue, 20 Nov 2007 14:35:28 +0100, Daniel Mack wrote:
Hi,
I'm re-posting a patch from Dmitry Torokhov which cleans up some input layer related things. It hasn't made its way to any repository yet but
Yes, I am being slow lately, sorry.
my subsequent patch needs it as dependency. I Cc'ed Dmitry to avoid confusion.
Dmitry, will this patch go to 2.6.24 from your tree?
If it's a 2.6.25 material,
Yes, it is .25 material.
then I'd like to put it rather to ALSA tree together with Daniel's another patch.
Thet would be great. The only reason I offered to send through my tree is that I did not see any response from you guys... I actually prefer not to touch code outside of drivers/input.
Well, I didn't apply it just because I thought you prefer pushing it to 2.6.24 :) If it's for 25, no problem to put to ALSA tree.
Now it's on ALSA HG tree. I fixed two tiny coding issues checkpatch.pl reported.
Thank you.
BTW, attached is a small Kconfig patchs for caiaq. Probably good for .24.
OK, will add this, too.
Applied this, too.
Great, thank you Takashi.
participants (3)
-
Daniel Mack -
Dmitry Torokhov -
Takashi Iwai