[PATCH 0/2] ASoC: codecs: rt715*: update misleading error log
Improve two errors logs which report bad information.
Bard Liao (2): ASoC: rt715-sdca: reorder the argument in error log ASoC: rt715: reorder the argument in error log
sound/soc/codecs/rt715-sdca.c | 4 ++-- sound/soc/codecs/rt715.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
From: Bard Liao yung-chuan.liao@linux.intel.com
"Failed to set private value: ffffffea <= 6100000 24832" is confusing. It should be "Failed to set private value: 6100000 <= 24832 -22"
Reviewed-by: Rander Wang rander.wang@intel.com Signed-off-by: Bard Liao yung-chuan.liao@linux.intel.com Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com --- sound/soc/codecs/rt715-sdca.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt715-sdca.c b/sound/soc/codecs/rt715-sdca.c index 9fa96fd83d4a..4533eedd7e18 100644 --- a/sound/soc/codecs/rt715-sdca.c +++ b/sound/soc/codecs/rt715-sdca.c @@ -41,8 +41,8 @@ static int rt715_sdca_index_write(struct rt715_sdca_priv *rt715, ret = regmap_write(regmap, addr, value); if (ret < 0) dev_err(&rt715->slave->dev, - "Failed to set private value: %08x <= %04x %d\n", ret, addr, - value); + "Failed to set private value: %08x <= %04x %d\n", + addr, value, ret);
return ret; }
From: Bard Liao yung-chuan.liao@linux.intel.com
"Failed to set private value: ffffffea <= 6100000 24832" is confusing. It should be "Failed to set private value: 6100000 <= 24832 -22"
Reviewed-by: Rander Wang rander.wang@intel.com Signed-off-by: Bard Liao yung-chuan.liao@linux.intel.com Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com --- sound/soc/codecs/rt715.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt715.c b/sound/soc/codecs/rt715.c index ed0af0213d60..9f732a5abd53 100644 --- a/sound/soc/codecs/rt715.c +++ b/sound/soc/codecs/rt715.c @@ -40,8 +40,8 @@ static int rt715_index_write(struct regmap *regmap, unsigned int reg,
ret = regmap_write(regmap, addr, value); if (ret < 0) { - pr_err("Failed to set private value: %08x <= %04x %d\n", ret, - addr, value); + pr_err("Failed to set private value: %08x <= %04x %d\n", + addr, value, ret); }
return ret;
On Thu, 12 Oct 2023 15:13:13 -0400, Pierre-Louis Bossart wrote:
Improve two errors logs which report bad information.
Bard Liao (2): ASoC: rt715-sdca: reorder the argument in error log ASoC: rt715: reorder the argument in error log
sound/soc/codecs/rt715-sdca.c | 4 ++-- sound/soc/codecs/rt715.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: rt715-sdca: reorder the argument in error log commit: cf77250a679556f39bc3247a68bd75ca399f59d6 [2/2] ASoC: rt715: reorder the argument in error log commit: 078d3a4b120f82d57778466de62929bb8824b664
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (2)
-
Mark Brown -
Pierre-Louis Bossart