[alsa-devel] [PATCH] ALSA: ali5451: remove redundant pointer 'codec'
From: Colin Ian King colin.king@canonical.com
Pointer 'codec' is being assigned but is never used hence it is redundant and can be removed.
Cleans up clang warning: warning: variable 'codec' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King colin.king@canonical.com --- sound/pci/ali5451/ali5451.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c index 39547e32e584..9f569379b77e 100644 --- a/sound/pci/ali5451/ali5451.c +++ b/sound/pci/ali5451/ali5451.c @@ -1484,12 +1484,9 @@ static struct snd_pcm_hardware snd_ali_capture = static void snd_ali_pcm_free_substream(struct snd_pcm_runtime *runtime) { struct snd_ali_voice *pvoice = runtime->private_data; - struct snd_ali *codec;
- if (pvoice) { - codec = pvoice->codec; + if (pvoice) snd_ali_free_voice(pvoice->codec, pvoice); - } }
static int snd_ali_open(struct snd_pcm_substream *substream, int rec,
On Mon, 16 Jul 2018 10:57:38 +0200, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
Pointer 'codec' is being assigned but is never used hence it is redundant and can be removed.
Cleans up clang warning: warning: variable 'codec' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King colin.king@canonical.com
Applied, thanks.
Takashi
participants (2)
-
Colin King
-
Takashi Iwai