[alsa-devel] [PATCH] ASoC: soc-core: fix crash when removing not instantiated card
If the card was not instantiated in snd_soc_instantiate_card, calling soc-remove will crash because some of codec, cpu_dai and card .remove methods are called twice. Fix this by returning from soc_remove immediately.
Signed-off-by: Mike Rapoport mike@compulab.co.il --- sound/soc/soc-core.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 99712f6..1cd149b 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -954,6 +954,9 @@ static int soc_remove(struct platform_device *pdev) struct snd_soc_platform *platform = card->platform; struct snd_soc_codec_device *codec_dev = socdev->codec_dev;
+ if (!card->instantiated) + return 0; + run_delayed_work(&card->delayed_work);
if (platform->remove)
On Mon, May 11, 2009 at 01:04:55PM +0300, Mike Rapoport wrote:
If the card was not instantiated in snd_soc_instantiate_card, calling soc-remove will crash because some of codec, cpu_dai and card .remove methods are called twice. Fix this by returning from soc_remove immediately.
Signed-off-by: Mike Rapoport mike@compulab.co.il
Applied, thanks.
participants (2)
-
Mark Brown
-
Mike Rapoport