On 03/11/2021 19:19, Christophe JAILLET wrote:

'hphpa_on' is know to be false, so this is just dead code that should be removed.

Suggested-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org Signed-off-by: Christophe JAILLET christophe.jaillet@wanadoo.fr

Thanks for the patch,

Reviewed-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org

--srini

---

This patch is a follow-up of: https://lore.kernel.org/kernel-janitors/988948f7f266aa00698704687537335b7e6a...

---

sound/soc/codecs/wcd-mbhc-v2.c | 5 ----- 1 file changed, 5 deletions(-)

diff --git a/sound/soc/codecs/wcd-mbhc-v2.c b/sound/soc/codecs/wcd-mbhc-v2.c index 405128ccb4b0..b905eb8f3c67 100644 --- a/sound/soc/codecs/wcd-mbhc-v2.c +++ b/sound/soc/codecs/wcd-mbhc-v2.c @@ -1176,7 +1176,6 @@ static irqreturn_t wcd_mbhc_adc_hs_rem_irq(int irq, void *data) struct wcd_mbhc *mbhc = data; unsigned long timeout; int adc_threshold, output_mv, retry = 0;

• bool hphpa_on = false;

  mutex_lock(&mbhc->lock); timeout = jiffies + msecs_to_jiffies(WCD_FAKE_REMOVAL_MIN_PERIOD_MS);

@@ -1210,10 +1209,6 @@ static irqreturn_t wcd_mbhc_adc_hs_rem_irq(int irq, void *data) wcd_mbhc_elec_hs_report_unplug(mbhc); wcd_mbhc_write_field(mbhc, WCD_MBHC_BTN_ISRC_CTL, 0);

• if (hphpa_on) {

• hphpa_on = false;
  

• wcd_mbhc_write_field(mbhc, WCD_MBHC_HPH_PA_EN, 3);
  

• } exit: mutex_unlock(&mbhc->lock); return IRQ_HANDLED;