[alsa-devel] Fwd: Re: no reset_resume for driver snd-usb-audio for logitech headset H600
FWD:
Any news to the snd-usb-audio issue?
Thanks, Bernhard
Old Message: ------------- I have tested the patch with kernel 3.12.0 with suspend and hibernate, and the problem is gone.
No messages "no reset_resume for driver snd-usb-audio?" or other negative effects/messages.
After resume, the usb_audio_device (Headset) is the master channel in KDE Mixer, as it should be.
=> So the problem is solved for me.
Can you please add the patch to the latest kernels and LTS-kernels or whitelist the workaround for my device (ID 046d:0a29 Logitech, Inc. H600 [Wireless Headset])
Thanks, Bernhard
On 2013-10-20 23:35, Takashi Iwai wrote:
At Sun, 20 Oct 2013 23:18:13 +0200, baumber@hotmail.com wrote:
On 2013-10-09 11:16 (CEST,UTC+2), Takashi Iwai wrote:
diff --git a/sound/usb/card.c b/sound/usb/card.c index 9d9de8d..c591a83 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -747,6 +747,7 @@ static struct usb_driver usb_audio_driver = { .disconnect = usb_audio_disconnect, .suspend = usb_audio_suspend, .resume = usb_audio_resume,
- .reset_resume = usb_audio_resume, .id_table = usb_audio_ids, .supports_autosuspend = 1, };
Shall I add the line in b/sound/usb/card.c and try it? Which kernel version shall I use?
It doesn't matter which kernel version is. The error message should disappear, but I don't know whether any other positive effect you get. As Clemens pointed, there can be some negative effects by this, so it cannot be taken as is. But at least, it'd be good to know the result...
thanks,
Takashi
At Sat, 11 Jan 2014 11:08:39 +0100, baumber@hotmail.com wrote:
FWD:
Any news to the snd-usb-audio issue?
Thanks, Bernhard
Old Message:
I have tested the patch with kernel 3.12.0 with suspend and hibernate, and the problem is gone.
No messages "no reset_resume for driver snd-usb-audio?" or other negative effects/messages.
After resume, the usb_audio_device (Headset) is the master channel in KDE Mixer, as it should be.
=> So the problem is solved for me.
Can you please add the patch to the latest kernels and LTS-kernels or whitelist the workaround for my device (ID 046d:0a29 Logitech, Inc. H600 [Wireless Headset])
The "reset_resume" kernel message was known to be harmless, and now it's degraded as a debug message. That's the only change, so there is no functional change.
That being said, you just need to ignore the kernel messages in the old kernels. Or, feel free to submit the commit [0a56b4fa6844: USB: change dev_warn about missing reset-resume to dev_dbg] to stable kernel.
Takashi
Thanks, Bernhard
On 2013-10-20 23:35, Takashi Iwai wrote:
At Sun, 20 Oct 2013 23:18:13 +0200, baumber@hotmail.com wrote:
On 2013-10-09 11:16 (CEST,UTC+2), Takashi Iwai wrote:
> diff --git a/sound/usb/card.c b/sound/usb/card.c > index 9d9de8d..c591a83 100644 > --- a/sound/usb/card.c > +++ b/sound/usb/card.c > @@ -747,6 +747,7 @@ static struct usb_driver usb_audio_driver = { > .disconnect = usb_audio_disconnect, > .suspend = usb_audio_suspend, > .resume = usb_audio_resume, > + .reset_resume = usb_audio_resume, > .id_table = usb_audio_ids, > .supports_autosuspend = 1, > };
Shall I add the line in b/sound/usb/card.c and try it? Which kernel version shall I use?
It doesn't matter which kernel version is. The error message should disappear, but I don't know whether any other positive effect you get. As Clemens pointed, there can be some negative effects by this, so it cannot be taken as is. But at least, it'd be good to know the result...
thanks,
Takashi
Hello,
there must be a misunderstanding;
There is a functional change, because with the line/patch ".reset_resume = usb_audio_resume," the mixer of the usb headset was not removed during suspend/resume and so the master channel in KDE Mixer was not changed (Headset), which is the correct behaviour.
Without the line ".reset_resume = usb_audio_resume," in /sound/usb/card.c, the mixer was removed during suspend/resume and re-added, and so the master channel changed in KDE Mixer to the default onboard audio.
I have tested kernel 3.13rc8, and as you mentioned, the "reset_resume"-messages are gone. But the behaviour of removing the mixer of the usb_audio_headset occurs, which is, in my opinion, not the correct behaviour, because the chosen master channel/mixer should stay after suspend/resume.
Could you please take a look at the issue again.
Thanks, Bernhard
On 2014-01-13 10:55, Takashi Iwai wrote:
At Sat, 11 Jan 2014 11:08:39 +0100, The "reset_resume" kernel message was known to be harmless, and now it's degraded as a debug message. That's the only change, so there is no functional change.
That being said, you just need to ignore the kernel messages in the old kernels. Or, feel free to submit the commit [0a56b4fa6844: USB: change dev_warn about missing reset-resume to dev_dbg] to stable kernel.
Takashi
baumber@hotmail.com wrote:
FWD:
Any news to the snd-usb-audio issue?
Thanks, Bernhard
Old Message:
I have tested the patch with kernel 3.12.0 with suspend and hibernate, and the problem is gone.
No messages "no reset_resume for driver snd-usb-audio?" or other negative effects/messages.
After resume, the usb_audio_device (Headset) is the master channel in KDE Mixer, as it should be.
=> So the problem is solved for me.
Can you please add the patch to the latest kernels and LTS-kernels or whitelist the workaround for my device (ID 046d:0a29 Logitech, Inc. H600 [Wireless Headset])
Thanks, Bernhard
On 2013-10-20 23:35, Takashi Iwai wrote:
At Sun, 20 Oct 2013 23:18:13 +0200, baumber@hotmail.com wrote:
On 2013-10-09 11:16 (CEST,UTC+2), Takashi Iwai wrote:
>> diff --git a/sound/usb/card.c b/sound/usb/card.c >> index 9d9de8d..c591a83 100644 >> --- a/sound/usb/card.c >> +++ b/sound/usb/card.c >> @@ -747,6 +747,7 @@ static struct usb_driver usb_audio_driver = { >> .disconnect = usb_audio_disconnect, >> .suspend = usb_audio_suspend, >> .resume = usb_audio_resume, >> + .reset_resume = usb_audio_resume, >> .id_table = usb_audio_ids, >> .supports_autosuspend = 1, >> };
Shall I add the line in b/sound/usb/card.c and try it? Which kernel version shall I use?
It doesn't matter which kernel version is. The error message should disappear, but I don't know whether any other positive effect you get. As Clemens pointed, there can be some negative effects by this, so it cannot be taken as is. But at least, it'd be good to know the result...
thanks,
Takashi
At Sun, 19 Jan 2014 21:30:58 +0100, baumber@hotmail.com wrote:
Hello,
there must be a misunderstanding;
There is a functional change, because with the line/patch ".reset_resume = usb_audio_resume," the mixer of the usb headset was not removed during suspend/resume and so the master channel in KDE Mixer was not changed (Headset), which is the correct behaviour.
Without the line ".reset_resume = usb_audio_resume," in /sound/usb/card.c, the mixer was removed during suspend/resume and re-added, and so the master channel changed in KDE Mixer to the default onboard audio.
I have tested kernel 3.13rc8, and as you mentioned, the "reset_resume"-messages are gone. But the behaviour of removing the mixer of the usb_audio_headset occurs, which is, in my opinion, not the correct behaviour, because the chosen master channel/mixer should stay after suspend/resume.
Could you please take a look at the issue again.
Simply adding usb_audio-resume to reset_resume ops doesn't work properly as Clemens already suggested. It misses the recovery of the current mixer values. This might work in some cases like S3 (where the device is kept more or less powered on), but it'll be definitely broken in some cases like S4.
Takashi
Thanks, Bernhard
On 2014-01-13 10:55, Takashi Iwai wrote:
At Sat, 11 Jan 2014 11:08:39 +0100, The "reset_resume" kernel message was known to be harmless, and now it's degraded as a debug message. That's the only change, so there is no functional change.
That being said, you just need to ignore the kernel messages in the old kernels. Or, feel free to submit the commit [0a56b4fa6844: USB: change dev_warn about missing reset-resume to dev_dbg] to stable kernel.
Takashi
baumber@hotmail.com wrote:
FWD:
Any news to the snd-usb-audio issue?
Thanks, Bernhard
Old Message:
I have tested the patch with kernel 3.12.0 with suspend and hibernate, and the problem is gone.
No messages "no reset_resume for driver snd-usb-audio?" or other negative effects/messages.
After resume, the usb_audio_device (Headset) is the master channel in KDE Mixer, as it should be.
=> So the problem is solved for me.
Can you please add the patch to the latest kernels and LTS-kernels or whitelist the workaround for my device (ID 046d:0a29 Logitech, Inc. H600 [Wireless Headset])
Thanks, Bernhard
On 2013-10-20 23:35, Takashi Iwai wrote:
At Sun, 20 Oct 2013 23:18:13 +0200, baumber@hotmail.com wrote:
On 2013-10-09 11:16 (CEST,UTC+2), Takashi Iwai wrote:
>>> diff --git a/sound/usb/card.c b/sound/usb/card.c >>> index 9d9de8d..c591a83 100644 >>> --- a/sound/usb/card.c >>> +++ b/sound/usb/card.c >>> @@ -747,6 +747,7 @@ static struct usb_driver usb_audio_driver = { >>> .disconnect = usb_audio_disconnect, >>> .suspend = usb_audio_suspend, >>> .resume = usb_audio_resume, >>> + .reset_resume = usb_audio_resume, >>> .id_table = usb_audio_ids, >>> .supports_autosuspend = 1, >>> };
Shall I add the line in b/sound/usb/card.c and try it? Which kernel version shall I use?
It doesn't matter which kernel version is. The error message should disappear, but I don't know whether any other positive effect you get. As Clemens pointed, there can be some negative effects by this, so it cannot be taken as is. But at least, it'd be good to know the result...
thanks,
Takashi
At Mon, 20 Jan 2014 09:45:58 +0100, Takashi Iwai wrote:
At Sun, 19 Jan 2014 21:30:58 +0100, baumber@hotmail.com wrote:
Hello,
there must be a misunderstanding;
There is a functional change, because with the line/patch ".reset_resume = usb_audio_resume," the mixer of the usb headset was not removed during suspend/resume and so the master channel in KDE Mixer was not changed (Headset), which is the correct behaviour.
Without the line ".reset_resume = usb_audio_resume," in /sound/usb/card.c, the mixer was removed during suspend/resume and re-added, and so the master channel changed in KDE Mixer to the default onboard audio.
I have tested kernel 3.13rc8, and as you mentioned, the "reset_resume"-messages are gone. But the behaviour of removing the mixer of the usb_audio_headset occurs, which is, in my opinion, not the correct behaviour, because the chosen master channel/mixer should stay after suspend/resume.
Could you please take a look at the issue again.
Simply adding usb_audio-resume to reset_resume ops doesn't work properly as Clemens already suggested. It misses the recovery of the current mixer values. This might work in some cases like S3 (where the device is kept more or less powered on), but it'll be definitely broken in some cases like S4.
... and below is a quick fix with mixer resume code. It still doesn't handle some quirks, so it might break some devices.
Takashi
-- >8 -- From: Takashi Iwai tiwai@suse.de Subject: [PATCH] ALSA: usb-audio: Resume mixer values properly
Implement reset_resume callback so that the mixer values are properly restored. Still no boot quirks are called, so it might not work well on some devices.
Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/usb/card.c | 18 ++++++++-- sound/usb/mixer.c | 99 ++++++++++++++++++++++++++++++++++++++++++++----------- sound/usb/mixer.h | 7 ++-- 3 files changed, 99 insertions(+), 25 deletions(-)
diff --git a/sound/usb/card.c b/sound/usb/card.c index d979050e6a6a..025224136129 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -691,12 +691,12 @@ static int usb_audio_suspend(struct usb_interface *intf, pm_message_t message) }
list_for_each_entry(mixer, &chip->mixer_list, list) - snd_usb_mixer_inactivate(mixer); + snd_usb_mixer_suspend(mixer);
return 0; }
-static int usb_audio_resume(struct usb_interface *intf) +static int __usb_audio_resume(struct usb_interface *intf, bool reset_resume) { struct snd_usb_audio *chip = usb_get_intfdata(intf); struct usb_mixer_interface *mixer; @@ -711,7 +711,7 @@ static int usb_audio_resume(struct usb_interface *intf) * we just notify and restart the mixers */ list_for_each_entry(mixer, &chip->mixer_list, list) { - err = snd_usb_mixer_activate(mixer); + err = snd_usb_mixer_resume(mixer, reset_resume); if (err < 0) goto err_out; } @@ -723,9 +723,20 @@ static int usb_audio_resume(struct usb_interface *intf) err_out: return err; } + +static int usb_audio_resume(struct usb_interface *intf) +{ + return __usb_audio_resume(intf, false); +} + +static int usb_audio_reset_resume(struct usb_interface *intf) +{ + return __usb_audio_resume(intf, true); +} #else #define usb_audio_suspend NULL #define usb_audio_resume NULL +#define usb_audio_reset_resume NULL #endif /* CONFIG_PM */
static struct usb_device_id usb_audio_ids [] = { @@ -747,6 +758,7 @@ static struct usb_driver usb_audio_driver = { .disconnect = usb_audio_disconnect, .suspend = usb_audio_suspend, .resume = usb_audio_resume, + .reset_resume = usb_audio_reset_resume, .id_table = usb_audio_ids, .supports_autosuspend = 1, }; diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 44b0ba4feab3..aa9bc19aae68 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2299,26 +2299,6 @@ requeue: } }
-/* stop any bus activity of a mixer */ -void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer) -{ - usb_kill_urb(mixer->urb); - usb_kill_urb(mixer->rc_urb); -} - -int snd_usb_mixer_activate(struct usb_mixer_interface *mixer) -{ - int err; - - if (mixer->urb) { - err = usb_submit_urb(mixer->urb, GFP_NOIO); - if (err < 0) - return err; - } - - return 0; -} - /* create the handler for the optional status interrupt endpoint */ static int snd_usb_mixer_status_create(struct usb_mixer_interface *mixer) { @@ -2417,3 +2397,82 @@ void snd_usb_mixer_disconnect(struct list_head *p) usb_kill_urb(mixer->urb); usb_kill_urb(mixer->rc_urb); } + +#ifdef CONFIG_PM +/* stop any bus activity of a mixer */ +static void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer) +{ + usb_kill_urb(mixer->urb); + usb_kill_urb(mixer->rc_urb); +} + +static int snd_usb_mixer_activate(struct usb_mixer_interface *mixer) +{ + int err; + + if (mixer->urb) { + err = usb_submit_urb(mixer->urb, GFP_NOIO); + if (err < 0) + return err; + } + + return 0; +} + +int snd_usb_mixer_suspend(struct usb_mixer_interface *mixer) +{ + snd_usb_mixer_inactivate(mixer); + return 0; +} + +static int restore_mixer_value(struct usb_mixer_elem_info *cval) +{ + int c, err, idx; + + if (cval->cmask) { + idx = 0; + for (c = 0; c < MAX_CHANNELS; c++) { + if (!(cval->cmask & (1 << c))) + continue; + if (cval->cached & (1 << c)) { + err = set_cur_mix_value(cval, c + 1, idx, + cval->cache_val[idx]); + if (err < 0) + return err; + } + idx++; + } + } else { + /* master */ + if (cval->cached) { + err = set_cur_mix_value(cval, 0, 0, *cval->cache_val); + if (err < 0) + return err; + } + } + + return 0; +} + +int snd_usb_mixer_resume(struct usb_mixer_interface *mixer, bool reset_resume) +{ + struct usb_mixer_elem_info *cval; + int id, err; + + /* FIXME: any mixer quirks? */ + + if (reset_resume) { + /* restore cached mixer values */ + for (id = 0; id < MAX_ID_ELEMS; id++) { + for (cval = mixer->id_elems[id]; cval; + cval = cval->next_id_elem) { + err = restore_mixer_value(cval); + if (err < 0) + return err; + } + } + } + + return snd_usb_mixer_activate(mixer); +} +#endif diff --git a/sound/usb/mixer.h b/sound/usb/mixer.h index aab80df201bd..73b1f649447b 100644 --- a/sound/usb/mixer.h +++ b/sound/usb/mixer.h @@ -63,8 +63,6 @@ void snd_usb_mixer_notify_id(struct usb_mixer_interface *mixer, int unitid);
int snd_usb_mixer_set_ctl_value(struct usb_mixer_elem_info *cval, int request, int validx, int value_set); -void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer); -int snd_usb_mixer_activate(struct usb_mixer_interface *mixer);
int snd_usb_mixer_add_control(struct usb_mixer_interface *mixer, struct snd_kcontrol *kctl); @@ -72,4 +70,9 @@ int snd_usb_mixer_add_control(struct usb_mixer_interface *mixer, int snd_usb_mixer_vol_tlv(struct snd_kcontrol *kcontrol, int op_flag, unsigned int size, unsigned int __user *_tlv);
+#ifdef CONFIG_PM +int snd_usb_mixer_suspend(struct usb_mixer_interface *mixer); +int snd_usb_mixer_resume(struct usb_mixer_interface *mixer, bool reset_resume); +#endif + #endif /* __USBMIXER_H */
On 2014-01-20 17:07, Takashi Iwai wrote:
At Mon, 20 Jan 2014 09:45:58 +0100, Takashi Iwai wrote:
At Sun, 19 Jan 2014 21:30:58 +0100, baumber@hotmail.com wrote:
Hello,
there must be a misunderstanding;
There is a functional change, because with the line/patch ".reset_resume = usb_audio_resume," the mixer of the usb headset was not removed during suspend/resume and so the master channel in KDE Mixer was not changed (Headset), which is the correct behaviour.
Without the line ".reset_resume = usb_audio_resume," in /sound/usb/card.c, the mixer was removed during suspend/resume and re-added, and so the master channel changed in KDE Mixer to the default onboard audio.
I have tested kernel 3.13rc8, and as you mentioned, the "reset_resume"-messages are gone. But the behaviour of removing the mixer of the usb_audio_headset occurs, which is, in my opinion, not the correct behaviour, because the chosen master channel/mixer should stay after suspend/resume.
Could you please take a look at the issue again.
Simply adding usb_audio-resume to reset_resume ops doesn't work properly as Clemens already suggested. It misses the recovery of the current mixer values. This might work in some cases like S3 (where the device is kept more or less powered on), but it'll be definitely broken in some cases like S4.
For my USB Logitech Headset (ID 046d:0a29 Logitech, Inc. H600 [Wireless Headset]) S3 and S4 are working (mixer resume), when using the "reset_resume" line/patch.
... and below is a quick fix with mixer resume code. It still doesn't handle some quirks, so it might break some devices.
Thank you for your patch/quick fix, I'll try it.
When can I expect a more complete solution for the mixer resume code, in the next kernel releases 3.14 or 3.15?
Thanks, Bernhard
Takashi
-- >8 -- From: Takashi Iwai tiwai@suse.de Subject: [PATCH] ALSA: usb-audio: Resume mixer values properly
Implement reset_resume callback so that the mixer values are properly restored. Still no boot quirks are called, so it might not work well on some devices.
Signed-off-by: Takashi Iwai tiwai@suse.de
sound/usb/card.c | 18 ++++++++-- sound/usb/mixer.c | 99 ++++++++++++++++++++++++++++++++++++++++++++----------- sound/usb/mixer.h | 7 ++-- 3 files changed, 99 insertions(+), 25 deletions(-)
diff --git a/sound/usb/card.c b/sound/usb/card.c index d979050e6a6a..025224136129 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -691,12 +691,12 @@ static int usb_audio_suspend(struct usb_interface *intf, pm_message_t message) }
list_for_each_entry(mixer, &chip->mixer_list, list)
snd_usb_mixer_inactivate(mixer);
snd_usb_mixer_suspend(mixer);return 0; }
-static int usb_audio_resume(struct usb_interface *intf) +static int __usb_audio_resume(struct usb_interface *intf, bool reset_resume) { struct snd_usb_audio *chip = usb_get_intfdata(intf); struct usb_mixer_interface *mixer; @@ -711,7 +711,7 @@ static int usb_audio_resume(struct usb_interface *intf) * we just notify and restart the mixers */ list_for_each_entry(mixer, &chip->mixer_list, list) {
err = snd_usb_mixer_activate(mixer);
err = snd_usb_mixer_resume(mixer, reset_resume);@@ -723,9 +723,20 @@ static int usb_audio_resume(struct usb_interface *intf) err_out: return err; }
+static int usb_audio_resume(struct usb_interface *intf) +{
- return __usb_audio_resume(intf, false);
+}
+static int usb_audio_reset_resume(struct usb_interface *intf) +{
- return __usb_audio_resume(intf, true);
+} #else #define usb_audio_suspend NULL #define usb_audio_resume NULL +#define usb_audio_reset_resume NULL #endif /* CONFIG_PM */
static struct usb_device_id usb_audio_ids [] = { @@ -747,6 +758,7 @@ static struct usb_driver usb_audio_driver = { .disconnect = usb_audio_disconnect, .suspend = usb_audio_suspend, .resume = usb_audio_resume,
- .reset_resume = usb_audio_reset_resume, .id_table = usb_audio_ids, .supports_autosuspend = 1, };
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 44b0ba4feab3..aa9bc19aae68 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2299,26 +2299,6 @@ requeue: } }
-/* stop any bus activity of a mixer */ -void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer) -{
- usb_kill_urb(mixer->urb);
- usb_kill_urb(mixer->rc_urb);
-}
-int snd_usb_mixer_activate(struct usb_mixer_interface *mixer) -{
- int err;
- if (mixer->urb) {
err = usb_submit_urb(mixer->urb, GFP_NOIO);if (err < 0)return err;- }
- return 0;
-}
- /* create the handler for the optional status interrupt endpoint */ static int snd_usb_mixer_status_create(struct usb_mixer_interface *mixer) {
@@ -2417,3 +2397,82 @@ void snd_usb_mixer_disconnect(struct list_head *p) usb_kill_urb(mixer->urb); usb_kill_urb(mixer->rc_urb); }
+#ifdef CONFIG_PM +/* stop any bus activity of a mixer */ +static void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer) +{
- usb_kill_urb(mixer->urb);
- usb_kill_urb(mixer->rc_urb);
+}
+static int snd_usb_mixer_activate(struct usb_mixer_interface *mixer) +{
- int err;
- if (mixer->urb) {
err = usb_submit_urb(mixer->urb, GFP_NOIO);if (err < 0)return err;- }
- return 0;
+}
+int snd_usb_mixer_suspend(struct usb_mixer_interface *mixer) +{
- snd_usb_mixer_inactivate(mixer);
- return 0;
+}
+static int restore_mixer_value(struct usb_mixer_elem_info *cval) +{
- int c, err, idx;
- if (cval->cmask) {
idx = 0;for (c = 0; c < MAX_CHANNELS; c++) {if (!(cval->cmask & (1 << c)))continue;if (cval->cached & (1 << c)) {err = set_cur_mix_value(cval, c + 1, idx,cval->cache_val[idx]);if (err < 0)return err;}idx++;}- } else {
/* master */if (cval->cached) {err = set_cur_mix_value(cval, 0, 0, *cval->cache_val);if (err < 0)return err;}- }
- return 0;
+}
+int snd_usb_mixer_resume(struct usb_mixer_interface *mixer, bool reset_resume) +{
- struct usb_mixer_elem_info *cval;
- int id, err;
- /* FIXME: any mixer quirks? */
- if (reset_resume) {
/* restore cached mixer values */for (id = 0; id < MAX_ID_ELEMS; id++) {for (cval = mixer->id_elems[id]; cval;cval = cval->next_id_elem) {err = restore_mixer_value(cval);if (err < 0)return err;}}- }
- return snd_usb_mixer_activate(mixer);
+} +#endif diff --git a/sound/usb/mixer.h b/sound/usb/mixer.h index aab80df201bd..73b1f649447b 100644 --- a/sound/usb/mixer.h +++ b/sound/usb/mixer.h @@ -63,8 +63,6 @@ void snd_usb_mixer_notify_id(struct usb_mixer_interface *mixer, int unitid);
int snd_usb_mixer_set_ctl_value(struct usb_mixer_elem_info *cval, int request, int validx, int value_set); -void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer); -int snd_usb_mixer_activate(struct usb_mixer_interface *mixer);
int snd_usb_mixer_add_control(struct usb_mixer_interface *mixer, struct snd_kcontrol *kctl); @@ -72,4 +70,9 @@ int snd_usb_mixer_add_control(struct usb_mixer_interface *mixer, int snd_usb_mixer_vol_tlv(struct snd_kcontrol *kcontrol, int op_flag, unsigned int size, unsigned int __user *_tlv);
+#ifdef CONFIG_PM +int snd_usb_mixer_suspend(struct usb_mixer_interface *mixer); +int snd_usb_mixer_resume(struct usb_mixer_interface *mixer, bool reset_resume); +#endif
- #endif /* __USBMIXER_H */
At Wed, 22 Jan 2014 18:12:45 +0100, baumber@hotmail.com wrote:
On 2014-01-20 17:07, Takashi Iwai wrote:
At Mon, 20 Jan 2014 09:45:58 +0100, Takashi Iwai wrote:
At Sun, 19 Jan 2014 21:30:58 +0100, baumber@hotmail.com wrote:
Hello,
there must be a misunderstanding;
There is a functional change, because with the line/patch ".reset_resume = usb_audio_resume," the mixer of the usb headset was not removed during suspend/resume and so the master channel in KDE Mixer was not changed (Headset), which is the correct behaviour.
Without the line ".reset_resume = usb_audio_resume," in /sound/usb/card.c, the mixer was removed during suspend/resume and re-added, and so the master channel changed in KDE Mixer to the default onboard audio.
I have tested kernel 3.13rc8, and as you mentioned, the "reset_resume"-messages are gone. But the behaviour of removing the mixer of the usb_audio_headset occurs, which is, in my opinion, not the correct behaviour, because the chosen master channel/mixer should stay after suspend/resume.
Could you please take a look at the issue again.
Simply adding usb_audio-resume to reset_resume ops doesn't work properly as Clemens already suggested. It misses the recovery of the current mixer values. This might work in some cases like S3 (where the device is kept more or less powered on), but it'll be definitely broken in some cases like S4.
For my USB Logitech Headset (ID 046d:0a29 Logitech, Inc. H600 [Wireless Headset]) S3 and S4 are working (mixer resume), when using the "reset_resume" line/patch.
You didn't change the mixer value (e.g. mute), right? Otherwise you'll have to notice the difference after S4.
... and below is a quick fix with mixer resume code. It still doesn't handle some quirks, so it might break some devices.
Thank you for your patch/quick fix, I'll try it.
When can I expect a more complete solution for the mixer resume code, in the next kernel releases 3.14 or 3.15?
Only after I get positive test reports. If I get them earlier, it can be in 3.14-rc1, as it's no too intrusive change. If not, it'll be in 3.15.
Takashi
Thanks, Bernhard
Takashi
-- >8 -- From: Takashi Iwai tiwai@suse.de Subject: [PATCH] ALSA: usb-audio: Resume mixer values properly
Implement reset_resume callback so that the mixer values are properly restored. Still no boot quirks are called, so it might not work well on some devices.
Signed-off-by: Takashi Iwai tiwai@suse.de
sound/usb/card.c | 18 ++++++++-- sound/usb/mixer.c | 99 ++++++++++++++++++++++++++++++++++++++++++++----------- sound/usb/mixer.h | 7 ++-- 3 files changed, 99 insertions(+), 25 deletions(-)
diff --git a/sound/usb/card.c b/sound/usb/card.c index d979050e6a6a..025224136129 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -691,12 +691,12 @@ static int usb_audio_suspend(struct usb_interface *intf, pm_message_t message) }
list_for_each_entry(mixer, &chip->mixer_list, list)
snd_usb_mixer_inactivate(mixer);
snd_usb_mixer_suspend(mixer);return 0; }
-static int usb_audio_resume(struct usb_interface *intf) +static int __usb_audio_resume(struct usb_interface *intf, bool reset_resume) { struct snd_usb_audio *chip = usb_get_intfdata(intf); struct usb_mixer_interface *mixer; @@ -711,7 +711,7 @@ static int usb_audio_resume(struct usb_interface *intf) * we just notify and restart the mixers */ list_for_each_entry(mixer, &chip->mixer_list, list) {
err = snd_usb_mixer_activate(mixer);
err = snd_usb_mixer_resume(mixer, reset_resume);@@ -723,9 +723,20 @@ static int usb_audio_resume(struct usb_interface *intf) err_out: return err; }
+static int usb_audio_resume(struct usb_interface *intf) +{
- return __usb_audio_resume(intf, false);
+}
+static int usb_audio_reset_resume(struct usb_interface *intf) +{
- return __usb_audio_resume(intf, true);
+} #else #define usb_audio_suspend NULL #define usb_audio_resume NULL +#define usb_audio_reset_resume NULL #endif /* CONFIG_PM */
static struct usb_device_id usb_audio_ids [] = { @@ -747,6 +758,7 @@ static struct usb_driver usb_audio_driver = { .disconnect = usb_audio_disconnect, .suspend = usb_audio_suspend, .resume = usb_audio_resume,
- .reset_resume = usb_audio_reset_resume, .id_table = usb_audio_ids, .supports_autosuspend = 1, };
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 44b0ba4feab3..aa9bc19aae68 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2299,26 +2299,6 @@ requeue: } }
-/* stop any bus activity of a mixer */ -void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer) -{
- usb_kill_urb(mixer->urb);
- usb_kill_urb(mixer->rc_urb);
-}
-int snd_usb_mixer_activate(struct usb_mixer_interface *mixer) -{
- int err;
- if (mixer->urb) {
err = usb_submit_urb(mixer->urb, GFP_NOIO);if (err < 0)return err;- }
- return 0;
-}
- /* create the handler for the optional status interrupt endpoint */ static int snd_usb_mixer_status_create(struct usb_mixer_interface *mixer) {
@@ -2417,3 +2397,82 @@ void snd_usb_mixer_disconnect(struct list_head *p) usb_kill_urb(mixer->urb); usb_kill_urb(mixer->rc_urb); }
+#ifdef CONFIG_PM +/* stop any bus activity of a mixer */ +static void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer) +{
- usb_kill_urb(mixer->urb);
- usb_kill_urb(mixer->rc_urb);
+}
+static int snd_usb_mixer_activate(struct usb_mixer_interface *mixer) +{
- int err;
- if (mixer->urb) {
err = usb_submit_urb(mixer->urb, GFP_NOIO);if (err < 0)return err;- }
- return 0;
+}
+int snd_usb_mixer_suspend(struct usb_mixer_interface *mixer) +{
- snd_usb_mixer_inactivate(mixer);
- return 0;
+}
+static int restore_mixer_value(struct usb_mixer_elem_info *cval) +{
- int c, err, idx;
- if (cval->cmask) {
idx = 0;for (c = 0; c < MAX_CHANNELS; c++) {if (!(cval->cmask & (1 << c)))continue;if (cval->cached & (1 << c)) {err = set_cur_mix_value(cval, c + 1, idx,cval->cache_val[idx]);if (err < 0)return err;}idx++;}- } else {
/* master */if (cval->cached) {err = set_cur_mix_value(cval, 0, 0, *cval->cache_val);if (err < 0)return err;}- }
- return 0;
+}
+int snd_usb_mixer_resume(struct usb_mixer_interface *mixer, bool reset_resume) +{
- struct usb_mixer_elem_info *cval;
- int id, err;
- /* FIXME: any mixer quirks? */
- if (reset_resume) {
/* restore cached mixer values */for (id = 0; id < MAX_ID_ELEMS; id++) {for (cval = mixer->id_elems[id]; cval;cval = cval->next_id_elem) {err = restore_mixer_value(cval);if (err < 0)return err;}}- }
- return snd_usb_mixer_activate(mixer);
+} +#endif diff --git a/sound/usb/mixer.h b/sound/usb/mixer.h index aab80df201bd..73b1f649447b 100644 --- a/sound/usb/mixer.h +++ b/sound/usb/mixer.h @@ -63,8 +63,6 @@ void snd_usb_mixer_notify_id(struct usb_mixer_interface *mixer, int unitid);
int snd_usb_mixer_set_ctl_value(struct usb_mixer_elem_info *cval, int request, int validx, int value_set); -void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer); -int snd_usb_mixer_activate(struct usb_mixer_interface *mixer);
int snd_usb_mixer_add_control(struct usb_mixer_interface *mixer, struct snd_kcontrol *kctl); @@ -72,4 +70,9 @@ int snd_usb_mixer_add_control(struct usb_mixer_interface *mixer, int snd_usb_mixer_vol_tlv(struct snd_kcontrol *kcontrol, int op_flag, unsigned int size, unsigned int __user *_tlv);
+#ifdef CONFIG_PM +int snd_usb_mixer_suspend(struct usb_mixer_interface *mixer); +int snd_usb_mixer_resume(struct usb_mixer_interface *mixer, bool reset_resume); +#endif
- #endif /* __USBMIXER_H */
On 2014-01-22 18:16 CET (UTC+1), Takashi Iwai wrote:
At Wed, 22 Jan 2014 18:12:45 +0100, baumber@hotmail.com wrote:
On 2014-01-20 17:07, Takashi Iwai wrote:
At Mon, 20 Jan 2014 09:45:58 +0100, Takashi Iwai wrote:
At Sun, 19 Jan 2014 21:30:58 +0100, baumber@hotmail.com wrote:
Hello,
there must be a misunderstanding;
There is a functional change, because with the line/patch ".reset_resume = usb_audio_resume," the mixer of the usb headset was not removed during suspend/resume and so the master channel in KDE Mixer was not changed (Headset), which is the correct behaviour.
Without the line ".reset_resume = usb_audio_resume," in /sound/usb/card.c, the mixer was removed during suspend/resume and re-added, and so the master channel changed in KDE Mixer to the default onboard audio.
I have tested kernel 3.13rc8, and as you mentioned, the "reset_resume"-messages are gone. But the behaviour of removing the mixer of the usb_audio_headset occurs, which is, in my opinion, not the correct behaviour, because the chosen master channel/mixer should stay after suspend/resume.
Could you please take a look at the issue again.
Simply adding usb_audio-resume to reset_resume ops doesn't work properly as Clemens already suggested. It misses the recovery of the current mixer values. This might work in some cases like S3 (where the device is kept more or less powered on), but it'll be definitely broken in some cases like S4.
For my USB Logitech Headset (ID 046d:0a29 Logitech, Inc. H600 [Wireless Headset]) S3 and S4 are working (mixer resume), when using the "reset_resume" line/patch.
You didn't change the mixer value (e.g. mute), right? Otherwise you'll have to notice the difference after S4.
I always let the last used mixer value stay (no mute), but I turn off the headset (power switch) before hibernate.
... and below is a quick fix with mixer resume code. It still doesn't handle some quirks, so it might break some devices.
Thank you for your patch/quick fix, I'll try it.
When can I expect a more complete solution for the mixer resume code, in the next kernel releases 3.14 or 3.15?
Only after I get positive test reports. If I get them earlier, it can be in 3.14-rc1, as it's no too intrusive change. If not, it'll be in 3.15.
Thank you for your patch, it is working fine.
It works with hibernate, the mixer value stays and the master channel "headset" (kmix) is selected after hibernate as it should be.
When will the patch be in mainline => 3.14? and backported to LTS-kernels?
Do you know, what is the meaning of the following message in /var/log/Xorg.0.log ?
(EE) [dix] Logitech Logitech Wireless Headset: unable to find touch point 0
Thanks, Bernhard
Takashi
Thanks, Bernhard
Takashi
-- >8 -- From: Takashi Iwai tiwai@suse.de Subject: [PATCH] ALSA: usb-audio: Resume mixer values properly
Implement reset_resume callback so that the mixer values are properly restored. Still no boot quirks are called, so it might not work well on some devices.
Signed-off-by: Takashi Iwai tiwai@suse.de
sound/usb/card.c | 18 ++++++++-- sound/usb/mixer.c | 99 ++++++++++++++++++++++++++++++++++++++++++++----------- sound/usb/mixer.h | 7 ++-- 3 files changed, 99 insertions(+), 25 deletions(-)
diff --git a/sound/usb/card.c b/sound/usb/card.c index d979050e6a6a..025224136129 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -691,12 +691,12 @@ static int usb_audio_suspend(struct usb_interface *intf, pm_message_t message) }
list_for_each_entry(mixer, &chip->mixer_list, list)
snd_usb_mixer_inactivate(mixer);
snd_usb_mixer_suspend(mixer);return 0; }
-static int usb_audio_resume(struct usb_interface *intf) +static int __usb_audio_resume(struct usb_interface *intf, bool reset_resume) { struct snd_usb_audio *chip = usb_get_intfdata(intf); struct usb_mixer_interface *mixer; @@ -711,7 +711,7 @@ static int usb_audio_resume(struct usb_interface *intf) * we just notify and restart the mixers */ list_for_each_entry(mixer, &chip->mixer_list, list) {
err = snd_usb_mixer_activate(mixer);
err = snd_usb_mixer_resume(mixer, reset_resume); if (err < 0) goto err_out;@@ -723,9 +723,20 @@ static int usb_audio_resume(struct usb_interface *intf) err_out: return err; }
+static int usb_audio_resume(struct usb_interface *intf) +{
- return __usb_audio_resume(intf, false);
+}
+static int usb_audio_reset_resume(struct usb_interface *intf) +{
- return __usb_audio_resume(intf, true);
+} #else #define usb_audio_suspend NULL #define usb_audio_resume NULL +#define usb_audio_reset_resume NULL #endif /* CONFIG_PM */
static struct usb_device_id usb_audio_ids [] = { @@ -747,6 +758,7 @@ static struct usb_driver usb_audio_driver = { .disconnect = usb_audio_disconnect, .suspend = usb_audio_suspend, .resume = usb_audio_resume,
- .reset_resume = usb_audio_reset_resume, .id_table = usb_audio_ids, .supports_autosuspend = 1, };
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 44b0ba4feab3..aa9bc19aae68 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2299,26 +2299,6 @@ requeue: } }
-/* stop any bus activity of a mixer */ -void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer) -{
- usb_kill_urb(mixer->urb);
- usb_kill_urb(mixer->rc_urb);
-}
-int snd_usb_mixer_activate(struct usb_mixer_interface *mixer) -{
- int err;
- if (mixer->urb) {
err = usb_submit_urb(mixer->urb, GFP_NOIO);if (err < 0)return err;- }
- return 0;
-}
- /* create the handler for the optional status interrupt endpoint */ static int snd_usb_mixer_status_create(struct usb_mixer_interface *mixer) {
@@ -2417,3 +2397,82 @@ void snd_usb_mixer_disconnect(struct list_head *p) usb_kill_urb(mixer->urb); usb_kill_urb(mixer->rc_urb); }
+#ifdef CONFIG_PM +/* stop any bus activity of a mixer */ +static void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer) +{
- usb_kill_urb(mixer->urb);
- usb_kill_urb(mixer->rc_urb);
+}
+static int snd_usb_mixer_activate(struct usb_mixer_interface *mixer) +{
- int err;
- if (mixer->urb) {
err = usb_submit_urb(mixer->urb, GFP_NOIO);if (err < 0)return err;- }
- return 0;
+}
+int snd_usb_mixer_suspend(struct usb_mixer_interface *mixer) +{
- snd_usb_mixer_inactivate(mixer);
- return 0;
+}
+static int restore_mixer_value(struct usb_mixer_elem_info *cval) +{
- int c, err, idx;
- if (cval->cmask) {
idx = 0;for (c = 0; c < MAX_CHANNELS; c++) {if (!(cval->cmask & (1 << c)))continue;if (cval->cached & (1 << c)) {err = set_cur_mix_value(cval, c + 1, idx,cval->cache_val[idx]);if (err < 0)return err;}idx++;}- } else {
/* master */if (cval->cached) {err = set_cur_mix_value(cval, 0, 0, *cval->cache_val);if (err < 0)return err;}- }
- return 0;
+}
+int snd_usb_mixer_resume(struct usb_mixer_interface *mixer, bool reset_resume) +{
- struct usb_mixer_elem_info *cval;
- int id, err;
- /* FIXME: any mixer quirks? */
- if (reset_resume) {
/* restore cached mixer values */for (id = 0; id < MAX_ID_ELEMS; id++) {for (cval = mixer->id_elems[id]; cval;cval = cval->next_id_elem) {err = restore_mixer_value(cval);if (err < 0)return err;}}- }
- return snd_usb_mixer_activate(mixer);
+} +#endif diff --git a/sound/usb/mixer.h b/sound/usb/mixer.h index aab80df201bd..73b1f649447b 100644 --- a/sound/usb/mixer.h +++ b/sound/usb/mixer.h @@ -63,8 +63,6 @@ void snd_usb_mixer_notify_id(struct usb_mixer_interface *mixer, int unitid);
int snd_usb_mixer_set_ctl_value(struct usb_mixer_elem_info *cval, int request, int validx, int value_set); -void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer); -int snd_usb_mixer_activate(struct usb_mixer_interface *mixer);
int snd_usb_mixer_add_control(struct usb_mixer_interface *mixer, struct snd_kcontrol *kctl); @@ -72,4 +70,9 @@ int snd_usb_mixer_add_control(struct usb_mixer_interface *mixer, int snd_usb_mixer_vol_tlv(struct snd_kcontrol *kcontrol, int op_flag, unsigned int size, unsigned int __user *_tlv);
+#ifdef CONFIG_PM +int snd_usb_mixer_suspend(struct usb_mixer_interface *mixer); +int snd_usb_mixer_resume(struct usb_mixer_interface *mixer, bool reset_resume); +#endif
- #endif /* __USBMIXER_H */
At Tue, 25 Mar 2014 20:21:34 +0100, baumber@hotmail.com wrote:
On 2014-01-22 18:16 CET (UTC+1), Takashi Iwai wrote:
At Wed, 22 Jan 2014 18:12:45 +0100, baumber@hotmail.com wrote:
On 2014-01-20 17:07, Takashi Iwai wrote:
At Mon, 20 Jan 2014 09:45:58 +0100, Takashi Iwai wrote:
At Sun, 19 Jan 2014 21:30:58 +0100, baumber@hotmail.com wrote:
Hello,
there must be a misunderstanding;
There is a functional change, because with the line/patch ".reset_resume = usb_audio_resume," the mixer of the usb headset was not removed during suspend/resume and so the master channel in KDE Mixer was not changed (Headset), which is the correct behaviour.
Without the line ".reset_resume = usb_audio_resume," in /sound/usb/card.c, the mixer was removed during suspend/resume and re-added, and so the master channel changed in KDE Mixer to the default onboard audio.
I have tested kernel 3.13rc8, and as you mentioned, the "reset_resume"-messages are gone. But the behaviour of removing the mixer of the usb_audio_headset occurs, which is, in my opinion, not the correct behaviour, because the chosen master channel/mixer should stay after suspend/resume.
Could you please take a look at the issue again.
Simply adding usb_audio-resume to reset_resume ops doesn't work properly as Clemens already suggested. It misses the recovery of the current mixer values. This might work in some cases like S3 (where the device is kept more or less powered on), but it'll be definitely broken in some cases like S4.
For my USB Logitech Headset (ID 046d:0a29 Logitech, Inc. H600 [Wireless Headset]) S3 and S4 are working (mixer resume), when using the "reset_resume" line/patch.
You didn't change the mixer value (e.g. mute), right? Otherwise you'll have to notice the difference after S4.
I always let the last used mixer value stay (no mute), but I turn off the headset (power switch) before hibernate.
... and below is a quick fix with mixer resume code. It still doesn't handle some quirks, so it might break some devices.
Thank you for your patch/quick fix, I'll try it.
When can I expect a more complete solution for the mixer resume code, in the next kernel releases 3.14 or 3.15?
Only after I get positive test reports. If I get them earlier, it can be in 3.14-rc1, as it's no too intrusive change. If not, it'll be in 3.15.
Thank you for your patch, it is working fine.
It works with hibernate, the mixer value stays and the master channel "headset" (kmix) is selected after hibernate as it should be.
When will the patch be in mainline => 3.14? and backported to LTS-kernels?
It'll be in 3.15 kernel. No stable backport is planned, though.
Do you know, what is the meaning of the following message in /var/log/Xorg.0.log ?
(EE) [dix] Logitech Logitech Wireless Headset: unable to find touch point 0
This implies that your device provides a HID but X driver couldn't handle it.
Takashi
On 2014-03-26 07:45 CET (UTC+1), Takashi Iwai wrote:
Thank you for your patch, it is working fine.
It works with hibernate, the mixer value stays and the master channel "headset" (kmix) is selected after hibernate as it should be.
When will the patch be in mainline => 3.14? and backported to LTS-kernels?
It'll be in 3.15 kernel. No stable backport is planned, though.
Thank you.
Another issue/problem with the headset occurs every ~10th - 20th hibernate cycle, but is not related to your patch. The usb-headset (the usb transceiver part) disconnects and reconnects immediately after resume. This behaviour was also before your patch and I interpreted this as device reset and as a problem of the device itself. Because of this behaviour the master channel "headset" in kmix is also cleared and reset to the onboard one.
Do you know if this is a kernel bug or a device bug?
Bernhard
usb-headset disconnects/reconnects after resume; ------------------------------------ [ 3901.627484] ata6.00: configured for UDMA/133 [ 3901.630579] ata5: SATA link up 3.0 Gbps (SStatus 123 SControl 300) [ 3901.630593] sd 7:0:0:0: [sdc] Starting disk [ 3901.634755] ata5.00: configured for UDMA/133 [ 3901.646699] sd 5:0:0:0: [sdb] Starting disk [ 3901.654656] sd 4:0:0:0: [sda] Starting disk [ 3901.666459] firewire_core 0000:0c:03.0: rediscovered device fw0 [ 3901.670491] usb 2-1: reset high-speed USB device number 2 using ehci-pci [ 3901.874780] usb 1-1.4: reset high-speed USB device number 3 using ehci-pci [ 3902.271236] usb 2-1.2: reset low-speed USB device number 3 using ehci-pci [ 3902.623801] usb 1-1.4.3: reset high-speed USB device number 4 using ehci-pci [ 3902.996413] usb 1-1.4.3.4: reset full-speed USB device number 6 using ehci-pci [ 3903.160598] usb 1-1.4.3.3: reset full-speed USB device number 5 using ehci-pci [ 3903.329030] PM: restore of devices complete after 2234.676 msecs [ 3903.329283] PM: Image restored successfully. [ 3903.329284] Restarting tasks ... done. [ 3903.336466] PM: Basic memory bitmaps freed [ 3904.575113] r8169 0000:05:00.0 eth0: link down [ 3904.575127] r8169 0000:05:00.0 eth0: link down [ 3904.575153] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready [ 3906.277519] r8169 0000:05:00.0 eth0: link up [ 3906.277531] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready [ 3958.031248] usb 1-1.4.3.3: USB disconnect, device number 5 [ 3958.743798] usb 1-1.4.3.3: new full-speed USB device number 7 using ehci-pci [ 3959.165798] usb 1-1.4.3.3: New USB device found, idVendor=046d, idProduct=0a29 [ 3959.165806] usb 1-1.4.3.3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 3959.165810] usb 1-1.4.3.3: Product: Logitech Wireless Headset [ 3959.165813] usb 1-1.4.3.3: Manufacturer: Logitech [ 3959.165817] usb 1-1.4.3.3: SerialNumber: 000d44b20870 [ 3959.249740] input: Logitech Logitech Wireless Headset as /devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.4/1-1.4.3/1-1.4.3.3/1-1.4.3.3:1.3/input/input17 [ 3959.250347] hid-generic 0003:046D:0A29.0007: input,hiddev0,hidraw1: USB HID v1.11 Device [Logitech Logitech Wireless Headset] on usb-0000:00:1a.0-1.4.3.3/input3 [ 3959.539837] hda-codec: out of range cmd 2:5:707:ffffffbf
On Wed, 26 Mar 2014 baumber@hotmail.com wrote:
Another issue/problem with the headset occurs every ~10th - 20th hibernate cycle, but is not related to your patch. The usb-headset (the usb transceiver part) disconnects and reconnects immediately after resume. This behaviour was also before your patch and I interpreted this as device reset and as a problem of the device itself. Because of this behaviour the master channel "headset" in kmix is also cleared and reset to the onboard one.
Do you know if this is a kernel bug or a device bug?
Bernhard
usb-headset disconnects/reconnects after resume;
[ 3901.627484] ata6.00: configured for UDMA/133 [ 3901.630579] ata5: SATA link up 3.0 Gbps (SStatus 123 SControl 300) [ 3901.630593] sd 7:0:0:0: [sdc] Starting disk [ 3901.634755] ata5.00: configured for UDMA/133 [ 3901.646699] sd 5:0:0:0: [sdb] Starting disk [ 3901.654656] sd 4:0:0:0: [sda] Starting disk [ 3901.666459] firewire_core 0000:0c:03.0: rediscovered device fw0 [ 3901.670491] usb 2-1: reset high-speed USB device number 2 using ehci-pci [ 3901.874780] usb 1-1.4: reset high-speed USB device number 3 using ehci-pci [ 3902.271236] usb 2-1.2: reset low-speed USB device number 3 using ehci-pci [ 3902.623801] usb 1-1.4.3: reset high-speed USB device number 4 using ehci-pci [ 3902.996413] usb 1-1.4.3.4: reset full-speed USB device number 6 using ehci-pci [ 3903.160598] usb 1-1.4.3.3: reset full-speed USB device number 5 using ehci-pci [ 3903.329030] PM: restore of devices complete after 2234.676 msecs [ 3903.329283] PM: Image restored successfully. [ 3903.329284] Restarting tasks ... done. [ 3903.336466] PM: Basic memory bitmaps freed [ 3904.575113] r8169 0000:05:00.0 eth0: link down [ 3904.575127] r8169 0000:05:00.0 eth0: link down [ 3904.575153] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready [ 3906.277519] r8169 0000:05:00.0 eth0: link up [ 3906.277531] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready [ 3958.031248] usb 1-1.4.3.3: USB disconnect, device number 5
This is what you're referring to?
[ 3958.743798] usb 1-1.4.3.3: new full-speed USB device number 7 using ehci-pci [ 3959.165798] usb 1-1.4.3.3: New USB device found, idVendor=046d, idProduct=0a29 [ 3959.165806] usb 1-1.4.3.3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 3959.165810] usb 1-1.4.3.3: Product: Logitech Wireless Headset [ 3959.165813] usb 1-1.4.3.3: Manufacturer: Logitech [ 3959.165817] usb 1-1.4.3.3: SerialNumber: 000d44b20870 [ 3959.249740] input: Logitech Logitech Wireless Headset as /devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.4/1-1.4.3/1-1.4.3.3/1-1.4.3.3:1.3/input/input17 [ 3959.250347] hid-generic 0003:046D:0A29.0007: input,hiddev0,hidraw1: USB HID v1.11 Device [Logitech Logitech Wireless Headset] on usb-0000:00:1a.0-1.4.3.3/input3 [ 3959.539837] hda-codec: out of range cmd 2:5:707:ffffffbf
It is most likely a bug in the device. Given that happens no more than 10% of the time, it is very unlikely to be a bug in the kernel.
Alan Stern
participants (3)
-
Alan Stern -
baumber＠hotmail.com -
Takashi Iwai