On Thu, Dec 06, 2012 at 05:14:50PM -0800, Jerry Wong wrote:

Here is the resubmission of the sound/soc/max98090.c driver with the changes you suggested including regmap I/O and some stylistic updates.

Please fix your mailer to word wrap within paragraphs. Please also follow the submission procedure in SubmittingPatches, as previously mentioned this is essential especially the Signed-off-by bit. I really can't apply or even properly review something that doesn't follow that.

Looking at the code you want to check the register defaults - defaults for volatile registers don't make a huge amount of sense.

For the ranges based on bases use ... or if (else) rather than listing the individual registers by hand.

For the custom get and sets I can't see why you're not able to use generic controls, if you aren't there's enough of these that you should add a generic type.

Gains should always be volume controls with TLV, enable/disable stuff should be Switch and controls called Gain Volume don't make a lot of sense (just Volume).

Prints that just log the build time aren't helpful, you'll notice no other mainline drivers do that... there's already a kernel level build time. Similarly other stuff like interrupt numbers that are getting logged are a bit noisy.

Build time options for things like performance need to be made runtime or platform data based.

Are you sure you want the bandgap reference running the entire time the system is powered up?