On Thu, Sep 27, 2012 at 8:58 PM, Stephen Warren swarren@wwwdotorg.org wrote:

On 09/27/2012 04:25 AM, Padmavathi Venna wrote:

...

Add support for device based discovery.

...

+++ b/Documentation/devicetree/bindings/sound/samsung-i2s.txt

...

+i2s@03830000 {

• compatible = "samsung,samsung-i2s";
  

• reg = <0x03830000 0x100>;
  

...

• tx-dma-channel-secondary = <&pdma0 8>;
  

• tx-dma-channel = <&pdma0 10>;
  

• rx-dma-channel = <&pdma0 9>;
  

• supports-6ch;
  

• supports-rstclr;
  

• supports-secdai;
  

Those 6 properties are custom to this binding so should have a vendor prefix, e.g. "samsung,supports-6ch".

Okay. I will change this.

Also, I wonder if this shouldn't wait for the forthcoming standardized DT DMA bindings (or perhaps document custom bindings that are identical to the new standardized bindings)? Otherwise, the DMA stuff will all have to be redefined again. Apparently it's hoped the bindings will be in 3.7, or if not there, in 3.8.

Okay. Once the generic DT DMA bindings are available I will use that. But It will be good if atleast other things get reviewed.

Thanks Padma

-- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html