[alsa-devel] [PATCH 0/2] ASoC: omap: sdma-pcm: modpost warning fix and include cleanup
Hi,
Since the sdma-pcm can be built as module it must have MODULE_LICENSE defined, whcih I have missed:
After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig) produced this warning:
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o see include/linux/module.h for more information WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o see include/linux/module.h for more information
Introduced by commit
dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm")
The second patch is kust a small adjustement for the include files.
Regards, Peter --- Peter Ujfalusi (2): ASoC: omap: sdma-pcm: Fix modpost warning ASoC: omap: sdma-pcm: Correction for the include files
sound/soc/omap/sdma-pcm.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o see include/linux/module.h for more information WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o see include/linux/module.h for more information
Add the missing MODULE_LICENSE.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@ti.com --- sound/soc/omap/sdma-pcm.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/sound/soc/omap/sdma-pcm.c b/sound/soc/omap/sdma-pcm.c index f7b2b5b69d27..403b90e2c89b 100644 --- a/sound/soc/omap/sdma-pcm.c +++ b/sound/soc/omap/sdma-pcm.c @@ -4,6 +4,7 @@ * Author: Peter Ujfalusi peter.ujfalusi@ti.com */
+#include <linux/module.h> #include <sound/core.h> #include <sound/pcm.h> #include <sound/pcm_params.h> @@ -66,3 +67,7 @@ int sdma_pcm_platform_register(struct device *dev, return devm_snd_dmaengine_pcm_register(dev, config, flags); } EXPORT_SYMBOL_GPL(sdma_pcm_platform_register); + +MODULE_AUTHOR("Peter Ujfalusi peter.ujfalusi@ti.com"); +MODULE_DESCRIPTION("sDMA PCM ASoC platform driver"); +MODULE_LICENSE("GPL");
On 2018-05-11 15:20, Peter Ujfalusi wrote:
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o see include/linux/module.h for more information WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o see include/linux/module.h for more information
Add the missing MODULE_LICENSE.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@ti.com
sound/soc/omap/sdma-pcm.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/sound/soc/omap/sdma-pcm.c b/sound/soc/omap/sdma-pcm.c index f7b2b5b69d27..403b90e2c89b 100644 --- a/sound/soc/omap/sdma-pcm.c +++ b/sound/soc/omap/sdma-pcm.c @@ -4,6 +4,7 @@
- Author: Peter Ujfalusi peter.ujfalusi@ti.com
*/
+#include <linux/module.h> #include <sound/core.h> #include <sound/pcm.h> #include <sound/pcm_params.h> @@ -66,3 +67,7 @@ int sdma_pcm_platform_register(struct device *dev, return devm_snd_dmaengine_pcm_register(dev, config, flags); } EXPORT_SYMBOL_GPL(sdma_pcm_platform_register);
+MODULE_AUTHOR("Peter Ujfalusi peter.ujfalusi@ti.com"); +MODULE_DESCRIPTION("sDMA PCM ASoC platform driver"); +MODULE_LICENSE("GPL");
The SPDX line is telling GPL-2.0, I should have "GPL v2"
resending.
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
The sdma-pcm does not need any information from omap-dma.h, it only needs to include the omap-dmaengine.h - for the omap_dma_filter_fn, but that might not be needed at all as OMAP1 was converted to dma_slave_map, but I can not test OMAP1.
Add the linux/device.h include as well for devm_kzalloc()
Signed-off-by: Peter Ujfalusi peter.ujfalusi@ti.com --- sound/soc/omap/sdma-pcm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/omap/sdma-pcm.c b/sound/soc/omap/sdma-pcm.c index 403b90e2c89b..471d4ec12da5 100644 --- a/sound/soc/omap/sdma-pcm.c +++ b/sound/soc/omap/sdma-pcm.c @@ -4,13 +4,14 @@ * Author: Peter Ujfalusi peter.ujfalusi@ti.com */
+#include <linux/device.h> #include <linux/module.h> #include <sound/core.h> #include <sound/pcm.h> #include <sound/pcm_params.h> #include <sound/soc.h> #include <sound/dmaengine_pcm.h> -#include <linux/omap-dma.h> +#include <linux/omap-dmaengine.h>
#include "sdma-pcm.h"
The patch
ASoC: omap: sdma-pcm: Correction for the include files
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 1cc0fe247958e5ae359e42e4d3cae1cf4f3c8136 Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi peter.ujfalusi@ti.com Date: Tue, 15 May 2018 09:43:35 +0300 Subject: [PATCH] ASoC: omap: sdma-pcm: Correction for the include files
The sdma-pcm does not need any information from omap-dma.h, it only needs to include the omap-dmaengine.h - for the omap_dma_filter_fn, but that might not be needed at all as OMAP1 was converted to dma_slave_map, but I can not test OMAP1.
Add the linux/device.h include as well for devm_kzalloc()
Signed-off-by: Peter Ujfalusi peter.ujfalusi@ti.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/omap/sdma-pcm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/omap/sdma-pcm.c b/sound/soc/omap/sdma-pcm.c index 3e52ccb2ae26..21a9c2499d48 100644 --- a/sound/soc/omap/sdma-pcm.c +++ b/sound/soc/omap/sdma-pcm.c @@ -4,13 +4,14 @@ * Author: Peter Ujfalusi peter.ujfalusi@ti.com */
+#include <linux/device.h> #include <linux/module.h> #include <sound/core.h> #include <sound/pcm.h> #include <sound/pcm_params.h> #include <sound/soc.h> #include <sound/dmaengine_pcm.h> -#include <linux/omap-dma.h> +#include <linux/omap-dmaengine.h>
#include "sdma-pcm.h"
participants (2)
-
Mark Brown
-
Peter Ujfalusi