Re: [alsa-devel] 'modern dailink' transition
On Mon, Mar 25, 2019 at 10:54:52AM +0900, Kuninori Morimoto wrote:
This is my understanding, please correct me if I was wrong. I think current many sound card which doesn't need "platfrom" are 2 patterns.
- select snd-soc-dummy as platfrom
- select cpu component as platfrom
Current ASoC selects 1) automatically if .platfrom_name was NULL. And driver needs to have below if it want to be 2)
dai_link->platform_of_node = dai_link->cpu_of_node
But, I think one of them is enough ? I mean select 2) automatically can be OK? In other words, current some sound card which doesn't need platfrom is calling snd-soc-dummy platfrom method in 1) case. But, is it needed ? I'm not sure...
It seems snd-soc-dummy platfrom is caring about DPCM-BE case, but, I think CPU is snd-soc-dummy in such case. Maybe we need same cade to dummy CPU (?), but *my* DPCM system is working correctly without it.
It *should* work without it. If it actually does work is a separate question - that code is a bit fragile so there may be some problems. Since the most complicated user of DPCM is x86 I think if a change to this stuff tests out well there it should be OK.
Hi Mark, Pierre-Louis
- select snd-soc-dummy as platfrom
- select cpu component as platfrom
(snip)
It seems snd-soc-dummy platfrom is caring about DPCM-BE case, but, I think CPU is snd-soc-dummy in such case. Maybe we need same cade to dummy CPU (?), but *my* DPCM system is working correctly without it.
It *should* work without it. If it actually does work is a separate question - that code is a bit fragile so there may be some problems. Since the most complicated user of DPCM is x86 I think if a change to this stuff tests out well there it should be OK.
OK, nice to know. Thank you
Best regards --- Kuninori Morimoto
Hi Pierre-Louis Cc: Mark
- select snd-soc-dummy as platfrom
- select cpu component as platfrom
(snip)
It seems snd-soc-dummy platfrom is caring about DPCM-BE case, but, I think CPU is snd-soc-dummy in such case. Maybe we need same cade to dummy CPU (?), but *my* DPCM system is working correctly without it.
It *should* work without it. If it actually does work is a separate question - that code is a bit fragile so there may be some problems. Since the most complicated user of DPCM is x86 I think if a change to this stuff tests out well there it should be OK.
I want to ask you about "Multi CPU" support. When you can post it ? I'm asking because I'm waiting it for a long term, and "switch to modern style" is based on it. But, v3 is not yet posted, right ?
If you can post it soon, I can keep waiting. But, if it will takes more long term, can I suggest ? I think there is few conflict around soc.h and soc-core.c between this suggestion and your patch, but not super much.
1. I will post "modern style CPU" support, it is still "single CPU" 2. All sound card switch to "modern style" 3. remove "legacy style"
I think, your "Multi CPU" support can be implemented on top of it. And, I can continue, like this
4. post "allow no Platfrom" 5. remove "snd-soc-dummy Platfrom", and "CPU = Platfrom" code from Intel card as trial. If it was OK, continue for all card.
I want to know your plan/opinion. Thank you for your help
Best regards --- Kuninori Morimoto
Hi Morimoto-san,
I want to ask you about "Multi CPU" support. When you can post it ? I'm asking because I'm waiting it for a long term, and "switch to modern style" is based on it. But, v3 is not yet posted, right ?
the multi-cpu part is required for SoundWire, but the directions taken to support multi-cpu are changing due to additional developments in the MIPI Software WG (contributors only at this point). So the plan for now is to develop with single cpu-dai first, and add multi-cpu support at a later stage.
In other words, the multi-cpu/multi-link part isn't the most urgent priority and it shouldn't impact your work.
If you can post it soon, I can keep waiting. But, if it will takes more long term, can I suggest ? I think there is few conflict around soc.h and soc-core.c between this suggestion and your patch, but not super much.
- I will post "modern style CPU" support, it is still "single CPU"
- All sound card switch to "modern style"
- remove "legacy style"
I think, your "Multi CPU" support can be implemented on top of it.
yes that's fine, this plan works fine for me.
And, I can continue, like this
- post "allow no Platfrom"
- remove "snd-soc-dummy Platfrom", and "CPU = Platfrom" code from Intel card as trial. If it was OK, continue for all card.
there are only 2 or 3 cases of this snd-soc-dummy platform and I'll try to remove it as part of the first batch. I don't think it's necessary at all.
Thanks!
-Pierre
Hi Pierre-Louis
Thank you for your feedback
- I will post "modern style CPU" support, it is still "single CPU"
- All sound card switch to "modern style"
- remove "legacy style"
I think, your "Multi CPU" support can be implemented on top of it.
yes that's fine, this plan works fine for me.
And, I can continue, like this
- post "allow no Platfrom"
- remove "snd-soc-dummy Platfrom", and "CPU = Platfrom" code from Intel card as trial. If it was OK, continue for all card.
there are only 2 or 3 cases of this snd-soc-dummy platform and I'll try to remove it as part of the first batch. I don't think it's necessary at all.
Thank you for sharing plan ! OK, I will work for 1, 2, 3 plan from now.
Best regards --- Kuninori Morimoto
participants (3)
-
Kuninori Morimoto -
Mark Brown -
Pierre-Louis Bossart