[alsa-devel] [PATCH] ALSA: hda/realtek - Add ALC3234 headset mode for Optiplex 9020m
The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.
A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.
Unfortunately, pin configurations can changed based on firmware/BIOS versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.
With help from David Henningsson diwic@ubuntu.com
Signed-off-by: Bastien Nocera hadess@hadess.net Tested-by: Bastien Nocera hadess@hadess.net --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 1402ba9..810bcee 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5449,6 +5449,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x064a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x064b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0665, "Dell XPS 13", ALC288_FIXUP_DELL_XPS_13), + SND_PCI_QUIRK(0x1028, 0x0669, "Dell Optiplex 9020m", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x069a, "Dell Vostro 5480", ALC290_FIXUP_SUBWOOFER_HSJACK), SND_PCI_QUIRK(0x1028, 0x06c7, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x06d9, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
On Mon, 18 Apr 2016 11:10:42 +0200, Bastien Nocera wrote:
The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.
A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.
Unfortunately, pin configurations can changed based on firmware/BIOS versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.
With help from David Henningsson diwic@ubuntu.com
Signed-off-by: Bastien Nocera hadess@hadess.net Tested-by: Bastien Nocera hadess@hadess.net
Applied, thanks.
Takashi
sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 1402ba9..810bcee 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5449,6 +5449,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x064a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x064b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0665, "Dell XPS 13", ALC288_FIXUP_DELL_XPS_13),
- SND_PCI_QUIRK(0x1028, 0x0669, "Dell Optiplex 9020m", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x069a, "Dell Vostro 5480", ALC290_FIXUP_SUBWOOFER_HSJACK), SND_PCI_QUIRK(0x1028, 0x06c7, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x06d9, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
-- 2.7.3
On Mon, 2016-04-18 at 11:40 +0200, Takashi Iwai wrote:
On Mon, 18 Apr 2016 11:10:42 +0200, Bastien Nocera wrote:
The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.
A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.
Unfortunately, pin configurations can changed based on firmware/BIOS versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.
With help from David Henningsson diwic@ubuntu.com
Signed-off-by: Bastien Nocera hadess@hadess.net Tested-by: Bastien Nocera hadess@hadess.net
Applied, thanks.
Thanks for the quick response. Can you however fix the typo I made?
"pin configurations can changed" should be "pin configurations can change"
Cheers
On Mon, 18 Apr 2016 12:02:59 +0200, Bastien Nocera wrote:
On Mon, 2016-04-18 at 11:40 +0200, Takashi Iwai wrote:
On Mon, 18 Apr 2016 11:10:42 +0200, Bastien Nocera wrote:
The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.
A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.
Unfortunately, pin configurations can changed based on firmware/BIOS versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.
With help from David Henningsson diwic@ubuntu.com
Signed-off-by: Bastien Nocera hadess@hadess.net Tested-by: Bastien Nocera hadess@hadess.net
Applied, thanks.
Thanks for the quick response. Can you however fix the typo I made?
"pin configurations can changed" should be "pin configurations can change"
Sorry, too late, it's been already merged and published.
Takashi
On Mon, 2016-04-18 at 13:20 +0200, Takashi Iwai wrote:
On Mon, 18 Apr 2016 12:02:59 +0200, Bastien Nocera wrote:
On Mon, 2016-04-18 at 11:40 +0200, Takashi Iwai wrote:
On Mon, 18 Apr 2016 11:10:42 +0200, Bastien Nocera wrote:
The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.
A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.
Unfortunately, pin configurations can changed based on firmware/BIOS versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.
With help from David Henningsson diwic@ubuntu.com
Signed-off-by: Bastien Nocera hadess@hadess.net Tested-by: Bastien Nocera hadess@hadess.net
Applied, thanks.
Thanks for the quick response. Can you however fix the typo I made?
"pin configurations can changed" should be "pin configurations can change"
Sorry, too late, it's been already merged and published.
Yay git :/
On Mon, 18 Apr 2016 13:56:34 +0200, Bastien Nocera wrote:
On Mon, 2016-04-18 at 13:20 +0200, Takashi Iwai wrote:
On Mon, 18 Apr 2016 12:02:59 +0200, Bastien Nocera wrote:
On Mon, 2016-04-18 at 11:40 +0200, Takashi Iwai wrote:
On Mon, 18 Apr 2016 11:10:42 +0200, Bastien Nocera wrote:
The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.
A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.
Unfortunately, pin configurations can changed based on firmware/BIOS versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.
With help from David Henningsson diwic@ubuntu.com
Signed-off-by: Bastien Nocera hadess@hadess.net Tested-by: Bastien Nocera hadess@hadess.net
Applied, thanks.
Thanks for the quick response. Can you however fix the typo I made?
"pin configurations can changed" should be "pin configurations can change"
Sorry, too late, it's been already merged and published.
Yay git :/
If the change were catastrophically buggy, I'd revert or rebase. But in this case, it's a not-too-bad typo, so I prefer leaving it.
Takashi
participants (2)
-
Bastien Nocera -
Takashi Iwai