Pandora audio using machine_is_omap3_pandora() check
Hi Grazvydas,
Arnd noticed that pandora audio is using machine_is_omap3_pandora() check that never succeeds for devicetree booting machines. Looks like this has been broken at some point many years ago with the devicetree conversion.
Does anybody have an interest in fixing this driver?
Regards,
Tony
Hi Tony,
Am 27.06.2022 um 11:52 schrieb Tony Lindgren tony@atomide.com:
Hi Grazvydas,
Arnd noticed that pandora audio is using machine_is_omap3_pandora() check that never succeeds for devicetree booting machines. Looks like this has been broken at some point many years ago with the devicetree conversion.
Does anybody have an interest in fixing this driver?
we already have fixes by Stefan Leichter and Grond here (incl. removing any call to machine_is_omap3_pandora):
https://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux/...
But I don't know who can volunteer to run this series through the upstreaming discussions and do regression tests (AFAIR the Pandora of Grond is broken and he has no replacement).
BR, NIkolaus
* H. Nikolaus Schaller hns@goldelico.com [220627 11:36]:
Hi Tony,
Am 27.06.2022 um 11:52 schrieb Tony Lindgren tony@atomide.com:
Hi Grazvydas,
Arnd noticed that pandora audio is using machine_is_omap3_pandora() check that never succeeds for devicetree booting machines. Looks like this has been broken at some point many years ago with the devicetree conversion.
Does anybody have an interest in fixing this driver?
we already have fixes by Stefan Leichter and Grond here (incl. removing any call to machine_is_omap3_pandora):
https://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux/...
OK :)
But I don't know who can volunteer to run this series through the upstreaming discussions and do regression tests (AFAIR the Pandora of Grond is broken and he has no replacement).
Probably best that Stefan and Grond do it :) Not sure what the minimal fix for the mainline kernel might be to get things at least try to probe.
Regards,
Tony
participants (2)
-
H. Nikolaus Schaller
-
Tony Lindgren