[alsa-devel] [PATCH 0/4] remove devm_pinctrl_get_select_default from drivers
The core does this automatically, no need to do this explicitly in drivers. Those patchces should go via the respective subtrees. Thanks!
Wolfram Sang (4): drivers/gpu/drm/tilcdc: don't use devm_pinctrl_get_select_default() in probe drivers/mmc/host: don't use devm_pinctrl_get_select_default() in probe drivers/pwm: don't use devm_pinctrl_get_select_default() in probe sound/soc/atmel: don't use devm_pinctrl_get_select_default() in probe
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 ------ drivers/gpu/drm/tilcdc/tilcdc_slave.c | 6 ------ drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 ------ drivers/mmc/host/mvsdio.c | 7 +------ drivers/mmc/host/omap_hsmmc.c | 7 ------- drivers/mmc/host/sdhci-esdhc-imx.c | 8 -------- drivers/pwm/pwm-tiecap.c | 6 ------ drivers/pwm/pwm-tiehrpwm.c | 6 ------ sound/soc/atmel/atmel_wm8904.c | 8 -------- 9 files changed, 1 insertion(+), 59 deletions(-)
Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins.
Acked-by: Linus Walleij linus.walleij@linaro.org (personally at LCE13) Signed-off-by: Wolfram Sang wsa@the-dreams.de --- sound/soc/atmel/atmel_wm8904.c | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/sound/soc/atmel/atmel_wm8904.c b/sound/soc/atmel/atmel_wm8904.c index 7222380..b4e3690 100644 --- a/sound/soc/atmel/atmel_wm8904.c +++ b/sound/soc/atmel/atmel_wm8904.c @@ -12,7 +12,6 @@ #include <linux/module.h> #include <linux/of.h> #include <linux/of_device.h> -#include <linux/pinctrl/consumer.h>
#include <sound/soc.h>
@@ -155,15 +154,8 @@ static int atmel_asoc_wm8904_probe(struct platform_device *pdev) struct snd_soc_card *card = &atmel_asoc_wm8904_card; struct snd_soc_dai_link *dailink = &atmel_asoc_wm8904_dailink; struct clk *clk_src; - struct pinctrl *pinctrl; int id, ret;
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev); - if (IS_ERR(pinctrl)) { - dev_err(&pdev->dev, "failed to request pinctrl\n"); - return PTR_ERR(pinctrl); - } - card->dev = &pdev->dev; ret = atmel_asoc_wm8904_dt_init(pdev); if (ret) {
Hi Wolfram Sang,
On 10/14/2013 00:17, Wolfram Sang wrote:
Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins.
Acked-by: Linus Walleij linus.walleij@linaro.org (personally at LCE13) Signed-off-by: Wolfram Sang wsa@the-dreams.de
sound/soc/atmel/atmel_wm8904.c | 8 -------- 1 file changed, 8 deletions(-)
Tested OK on at91sam9n12ek and sama5d3xek board. Thanks.
Acked-by: Bo Shen voice.shen@atmel.com
Best Regards, Bo Shen
On Sun, Oct 13, 2013 at 06:17:50PM +0200, Wolfram Sang wrote:
Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins.
Applied, thanks. Please use subject lines appropriate to the subsystem.
Applied, thanks. Please use subject lines appropriate to the subsystem.
That's quite a nut to crack with a generated patch series running over the whole tree. I wonder if it is really worth the effort?
On Mon, Oct 14, 2013 at 04:56:29PM +0200, Wolfram Sang wrote:
Applied, thanks. Please use subject lines appropriate to the subsystem.
That's quite a nut to crack with a generated patch series running over the whole tree. I wonder if it is really worth the effort?
I think it's probably worth the effort to add something to put rules for these things in MAINTAINERS, it'd cover 90% of cases. If you're sending only one of a big series with a subject line that won't pattern match that's a good way to get stuff dropped on the floor.
Applied, thanks. Please use subject lines appropriate to the subsystem.
That's quite a nut to crack with a generated patch series running over the whole tree. I wonder if it is really worth the effort?
I think it's probably worth the effort to add something to put rules for these things in MAINTAINERS, it'd cover 90% of cases. If you're sending only one of a big series with a subject line that won't pattern match that's a good way to get stuff dropped on the floor.
On the other hand, MAINTAINERS information gets overlooked and/or could get stale. Thinking about it again, it is probably less work (at least for me with i2c) to create a git-hook fixing the subject line than to always nag people.
On Thu, Oct 17, 2013 at 06:46:14PM +0200, Wolfram Sang wrote:
On the other hand, MAINTAINERS information gets overlooked and/or could get stale. Thinking about it again, it is probably less work (at least for me with i2c) to create a git-hook fixing the subject line than to always nag people.
That doesn't fix the main problem which is getting the mail looked at in the first place - not having a subject line that people are looking for makes it easy for things to get dropped on the floor.
participants (3)
-
Bo Shen -
Mark Brown -
Wolfram Sang