Dear Takashi, Liam, Mark

Thanks for your reply

...

Hm, this should have been fixed by the later commit: commit 2b39535b9e54888649923beaab443af212b6c0fd Author: Jarkko Nikula jhnikula@gmail.com Date: Fri May 20 15:47:40 2011 +0300

ASoC: core: Don't set "(null)" as a driver name

Could you check whether the segfault occurs at this point? It's possible that another bug was introduced after it, of course.

Hmm... segfault still happen on this commit.

Is this become hint ?

my kernel boot log is

-------------- ... fsi-pcm-audio sh_fsi2: clocks managed by runtime pm ak4642-codec 0-0013: AK4642 Audio Codec 0.0.1 asoc: ak4642-hifi <-> fsia-dai mapping ok sh-mobile-hdmi sh-mobile-hdmi: SH Mobile HDMI Audio Codec asoc: sh_mobile_hdmi-hifi <-> fsib-dai mapping ok ALSA device list: #0: FSI2A (AK4643) #1: FSI2B (SH MOBILE HDMI) --------------

I don't know why, but the segfault didn't happen if I applied below patch

------------------- diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index bb7cd58..e84bf6d 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1929,8 +1929,8 @@ static void snd_soc_instantiate_card(struct snd_soc_card * "%s", card->name); snprintf(card->snd_card->longname, sizeof(card->snd_card->longname), "%s", card->long_name ? card->long_name : card->name); - snprintf(card->snd_card->driver, sizeof(card->snd_card->driver), - "%s", card->driver_name ? card->driver_name : card->name); +// snprintf(card->snd_card->driver, sizeof(card->snd_card->driver), +// "%s", card->driver_name ? card->driver_name : card->name);

if (card->late_probe) { ret = card->late_probe(card); -------------------

Best regards --- Kuninori Morimoto

it shouldn't contain space letters and special letters like parentheses.

aplay will be "Segmentation fault" without this patch. special thanks to Takashi.

Cc: Takashi Iwai tiwai@suse.de Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- sound/soc/sh/fsi-ak4642.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/sound/soc/sh/fsi-ak4642.c b/sound/soc/sh/fsi-ak4642.c index d6f4703..770a71a 100644 --- a/sound/soc/sh/fsi-ak4642.c +++ b/sound/soc/sh/fsi-ak4642.c @@ -97,7 +97,7 @@ static int fsi_ak4642_remove(struct platform_device *pdev)

static struct fsi_ak4642_data fsi_a_ak4642 = { .name = "AK4642", - .card = "FSIA (AK4642)", + .card = "FSIA-AK4642", .cpu_dai = "fsia-dai", .codec = "ak4642-codec.0-0012", .platform = "sh_fsi.0", @@ -106,7 +106,7 @@ static struct fsi_ak4642_data fsi_a_ak4642 = {

static struct fsi_ak4642_data fsi_b_ak4642 = { .name = "AK4642", - .card = "FSIB (AK4642)", + .card = "FSIB-AK4642", .cpu_dai = "fsib-dai", .codec = "ak4642-codec.0-0012", .platform = "sh_fsi.0", @@ -115,7 +115,7 @@ static struct fsi_ak4642_data fsi_b_ak4642 = {

static struct fsi_ak4642_data fsi_a_ak4643 = { .name = "AK4643", - .card = "FSIA (AK4643)", + .card = "FSIA-AK4643", .cpu_dai = "fsia-dai", .codec = "ak4642-codec.0-0013", .platform = "sh_fsi.0", @@ -124,7 +124,7 @@ static struct fsi_ak4642_data fsi_a_ak4643 = {

static struct fsi_ak4642_data fsi_b_ak4643 = { .name = "AK4643", - .card = "FSIB (AK4643)", + .card = "FSIB-AK4643", .cpu_dai = "fsib-dai", .codec = "ak4642-codec.0-0013", .platform = "sh_fsi.0", @@ -133,7 +133,7 @@ static struct fsi_ak4642_data fsi_b_ak4643 = {

static struct fsi_ak4642_data fsi2_a_ak4642 = { .name = "AK4642", - .card = "FSI2A (AK4642)", + .card = "FSI2A-AK4642", .cpu_dai = "fsia-dai", .codec = "ak4642-codec.0-0012", .platform = "sh_fsi2", @@ -142,7 +142,7 @@ static struct fsi_ak4642_data fsi2_a_ak4642 = {

static struct fsi_ak4642_data fsi2_b_ak4642 = { .name = "AK4642", - .card = "FSI2B (AK4642)", + .card = "FSI2B-AK4642", .cpu_dai = "fsib-dai", .codec = "ak4642-codec.0-0012", .platform = "sh_fsi2", @@ -151,7 +151,7 @@ static struct fsi_ak4642_data fsi2_b_ak4642 = {

static struct fsi_ak4642_data fsi2_a_ak4643 = { .name = "AK4643", - .card = "FSI2A (AK4643)", + .card = "FSI2A-AK4643", .cpu_dai = "fsia-dai", .codec = "ak4642-codec.0-0013", .platform = "sh_fsi2", @@ -160,7 +160,7 @@ static struct fsi_ak4642_data fsi2_a_ak4643 = {

static struct fsi_ak4642_data fsi2_b_ak4643 = { .name = "AK4643", - .card = "FSI2B (AK4643)", + .card = "FSI2B-AK4643", .cpu_dai = "fsib-dai", .codec = "ak4642-codec.0-0013", .platform = "sh_fsi2",

it shouldn't contain space letters and special letters like parentheses.

aplay will be "Segmentation fault" without this patch. special thanks to Takashi.

Cc: Takashi Iwai tiwai@suse.de Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- sound/soc/sh/fsi-da7210.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/sh/fsi-da7210.c b/sound/soc/sh/fsi-da7210.c index dbafd7a..59553fd 100644 --- a/sound/soc/sh/fsi-da7210.c +++ b/sound/soc/sh/fsi-da7210.c @@ -42,7 +42,7 @@ static struct snd_soc_dai_link fsi_da7210_dai = { };

static struct snd_soc_card fsi_soc_card = { - .name = "FSI (DA7210)", + .name = "FSI-DA7210", .dai_link = &fsi_da7210_dai, .num_links = 1, };

At Tue, 05 Jul 2011 00:12:04 -0700 (PDT), kuninori.morimoto.gx@renesas.com wrote:

Dear Mark, Liam

These are fsi-xxx card name fixup patches. It are needed for current linus tree.

Kuninori Morimoto (3): ASoC: sh: fsi-ak4642: fixup snd_soc_card name ASoC: sh: fsi-da7210: fixup snd_soc_card name ASoC: sh: fsi-hdmi: fixup snd_soc_card name

The name string itself is allowed to contain spaces or other special letters. These are copied to longname and shortname. But the driver_name string isn't, and the problem is to reuse the same string for it.

Since no driver sets driver_name string yet, a better fix would be to keep it empty like the earlier version. The revised patch below.

Takashi

--- From: Takashi Iwai tiwai@suse.de Subject: [PATCH] ASoC: Don't set invalid name string to snd_card->driver field

The snd_card->driver field contains a driver name string, and in general it shouldn't contain space or special letters. The commit 2b39535b9e54888649923beaab443af212b6c0fd changed the string copy from card->name, but the long name string may contain such letters, thus it may still lead to a segfault.

A temporary fix is not to copy the long name string but just keep it empty as the earlier version did.

Reported-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/soc/soc-core.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index d75043e..b194be0 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1929,8 +1929,9 @@ static void snd_soc_instantiate_card(struct snd_soc_card *card) "%s", card->name); snprintf(card->snd_card->longname, sizeof(card->snd_card->longname), "%s", card->long_name ? card->long_name : card->name); - snprintf(card->snd_card->driver, sizeof(card->snd_card->driver), - "%s", card->driver_name ? card->driver_name : card->name); + if (card->driver_name) + strlcpy(card->snd_card->driver, card->driver_name, + sizeof(card->snd_card->driver));

if (card->late_probe) { ret = card->late_probe(card);

On 05/07/11 08:33, Takashi Iwai wrote:

At Tue, 05 Jul 2011 00:12:04 -0700 (PDT), kuninori.morimoto.gx@renesas.com wrote:

...

Dear Mark, Liam

These are fsi-xxx card name fixup patches. It are needed for current linus tree.

Kuninori Morimoto (3): ASoC: sh: fsi-ak4642: fixup snd_soc_card name ASoC: sh: fsi-da7210: fixup snd_soc_card name ASoC: sh: fsi-hdmi: fixup snd_soc_card name

The name string itself is allowed to contain spaces or other special letters. These are copied to longname and shortname. But the driver_name string isn't, and the problem is to reuse the same string for it.

Since no driver sets driver_name string yet, a better fix would be to keep it empty like the earlier version. The revised patch below.

I can give a little background here, the intention is to allow a single "family" driver to support several different machines. i.e. the Panda, Blaze and SDP4430 are use the same "OMAP4" sound driver, but all have slightly different analog outputs (requiring slightly different userspace alsa-lib/UCM configs).

I do have a patch queued using driver name for OMAP4, but that will be for 3.2.

Takashi

---

From: Takashi Iwai tiwai@suse.de Subject: [PATCH] ASoC: Don't set invalid name string to snd_card->driver field

The snd_card->driver field contains a driver name string, and in general it shouldn't contain space or special letters. The commit 2b39535b9e54888649923beaab443af212b6c0fd changed the string copy from card->name, but the long name string may contain such letters, thus it may still lead to a segfault.

A temporary fix is not to copy the long name string but just keep it empty as the earlier version did.

Reported-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Signed-off-by: Takashi Iwai tiwai@suse.de

Acked-by: Liam Girdwood lrg@ti.com

---

sound/soc/soc-core.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index d75043e..b194be0 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1929,8 +1929,9 @@ static void snd_soc_instantiate_card(struct snd_soc_card *card) "%s", card->name); snprintf(card->snd_card->longname, sizeof(card->snd_card->longname), "%s", card->long_name ? card->long_name : card->name);

• snprintf(card->snd_card->driver, sizeof(card->snd_card->driver),

•  "%s", card->driver_name ? card->driver_name : card->name);
  

• if (card->driver_name)

• strlcpy(card->snd_card->driver, card->driver_name,
  

• 	sizeof(card->snd_card->driver));
  
  

  if (card->late_probe) { ret = card->late_probe(card);