[alsa-devel] [PATCH 1/2] ASoC: SPEAr: Add dependency on dmaengine helpers
I'd be very surprised if anyone has used the Kconfig...
Signed-off-by: Mark Brown broonie@linaro.org --- sound/soc/spear/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/spear/Kconfig b/sound/soc/spear/Kconfig index 3b7cdad..5b744ed 100644 --- a/sound/soc/spear/Kconfig +++ b/sound/soc/spear/Kconfig @@ -27,6 +27,7 @@ config SND_SPEAR_SOC Say Y or M if you want to add support for any of the audio controllers (I2S/SPDIF). You will also need to select the audio interface codecs to support below. + select SND_SOC_DMAENGINE_PCM
config SND_SPEAR_SPDIF_OUT tristate "SPEAr SPDIF Out Device Driver"
The individual component drivers are only useful with a machine driver and should be selected by the machine drivers so shouldn't have help text of their own in order to hide them in interactive configuration.
Signed-off-by: Mark Brown broonie@linaro.org --- sound/soc/spear/Kconfig | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/sound/soc/spear/Kconfig b/sound/soc/spear/Kconfig index 5b744ed..e3851d6 100644 --- a/sound/soc/spear/Kconfig +++ b/sound/soc/spear/Kconfig @@ -20,21 +20,11 @@ config SND_SPEAR1340_EVM platform
config SND_SPEAR_SOC - tristate "SoC Audio for the ST chip" - depends on SND_DESIGNWARE_I2S || SND_SPEAR_SPDIF_OUT || \ - SND_SPEAR_SPDIF_IN - help - Say Y or M if you want to add support for any of the audio - controllers (I2S/SPDIF). You will also need to select - the audio interface codecs to support below. + tristate select SND_SOC_DMAENGINE_PCM
config SND_SPEAR_SPDIF_OUT - tristate "SPEAr SPDIF Out Device Driver" - help - Say Y or M if you want to add support for SPDIF OUT driver. + tristate
config SND_SPEAR_SPDIF_IN - tristate "SPEAr SPDIF IN Device Driver" - help - Say Y or M if you want to add support for SPDIF IN driver. + tristate
On Fri, Jun 14, 2013 at 5:00 PM, Mark Brown broonie@linaro.org wrote:
The individual component drivers are only useful with a machine driver and should be selected by the machine drivers so shouldn't have help text of their own in order to hide them in interactive configuration.
Signed-off-by: Mark Brown broonie@linaro.org
sound/soc/spear/Kconfig | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-)
Acked-by: Viresh Kumar viresh.kumar@linaro.org
On Fri, Jun 14, 2013 at 5:00 PM, Mark Brown broonie@linaro.org wrote:
I'd be very surprised if anyone has used the Kconfig...
This might be selected directly by defconfig...
Signed-off-by: Mark Brown broonie@linaro.org
sound/soc/spear/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/spear/Kconfig b/sound/soc/spear/Kconfig index 3b7cdad..5b744ed 100644 --- a/sound/soc/spear/Kconfig +++ b/sound/soc/spear/Kconfig @@ -27,6 +27,7 @@ config SND_SPEAR_SOC Say Y or M if you want to add support for any of the audio controllers (I2S/SPDIF). You will also need to select the audio interface codecs to support below.
select SND_SOC_DMAENGINE_PCMconfig SND_SPEAR_SPDIF_OUT tristate "SPEAr SPDIF Out Device Driver"
Acked-by: Viresh Kumar viresh.kumar@linaro.org
On Fri, Jun 14, 2013 at 05:49:06PM +0530, Viresh Kumar wrote:
On Fri, Jun 14, 2013 at 5:00 PM, Mark Brown broonie@linaro.org wrote:
I'd be very surprised if anyone has used the Kconfig...
This might be selected directly by defconfig...
No, any select only options like that should be deselected automatically during the build if they're not required any more.
participants (3)
-
Mark Brown -
Mark Brown -
Viresh Kumar