[PATCH] ASoC: dt-bindings: mediatek: mt8192: re-add audio afe document
The document was removed temporarily by commit 7d94ca3c8acd ("ASoC: mt8192: revert add audio afe document") because the dependency was not merged at that time.
The dependency has merged. Re-adds back the document.
Signed-off-by: Tzung-Bi Shih tzungbi@google.com ---
More context: - [1] reported `dt_binding_check` was broken. - [2] reverted. - The dependency has merged in [3] and it can be found from linux-next.
[1]: https://patchwork.kernel.org/project/alsa-devel/patch/1604390378-23993-8-git... [2]: https://patchwork.kernel.org/project/alsa-devel/patch/1605081920-11848-1-git... [3]: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-...
.../bindings/sound/mt8192-afe-pcm.yaml | 100 ++++++++++++++++++ 1 file changed, 100 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml new file mode 100644 index 000000000000..0170c93802d2 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml @@ -0,0 +1,100 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/mt8192-afe-pcm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek AFE PCM controller for mt8192 + +maintainers: + - Jiaxin Yu jiaxin.yu@mediatek.com + - Shane Chien shane.chien@mediatek.com + +properties: + compatible: + const: mediatek,mt8192-audio + + interrupts: + maxItems: 1 + + resets: + maxItems: 1 + + reset-names: + const: audiosys + + mediatek,apmixedsys: + $ref: "/schemas/types.yaml#/definitions/phandle" + description: The phandle of the mediatek apmixedsys controller + + mediatek,infracfg: + $ref: "/schemas/types.yaml#/definitions/phandle" + description: The phandle of the mediatek infracfg controller + + mediatek,topckgen: + $ref: "/schemas/types.yaml#/definitions/phandle" + description: The phandle of the mediatek topckgen controller + + power-domains: + maxItems: 1 + + clocks: + items: + - description: AFE clock + - description: ADDA DAC clock + - description: ADDA DAC pre-distortion clock + - description: audio infra sys clock + - description: audio infra 26M clock + + clock-names: + items: + - const: aud_afe_clk + - const: aud_dac_clk + - const: aud_dac_predis_clk + - const: aud_infra_clk + - const: aud_infra_26m_clk + +required: + - compatible + - interrupts + - resets + - reset-names + - mediatek,apmixedsys + - mediatek,infracfg + - mediatek,topckgen + - power-domains + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/mt8192-clk.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/power/mt8192-power.h> + #include <dt-bindings/reset-controller/mt8192-resets.h> + + afe: mt8192-afe-pcm { + compatible = "mediatek,mt8192-audio"; + interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>; + resets = <&watchdog MT8192_TOPRGU_AUDIO_SW_RST>; + reset-names = "audiosys"; + mediatek,apmixedsys = <&apmixedsys>; + mediatek,infracfg = <&infracfg>; + mediatek,topckgen = <&topckgen>; + power-domains = <&scpsys MT8192_POWER_DOMAIN_AUDIO>; + clocks = <&audsys CLK_AUD_AFE>, + <&audsys CLK_AUD_DAC>, + <&audsys CLK_AUD_DAC_PREDIS>, + <&infracfg CLK_INFRA_AUDIO>, + <&infracfg CLK_INFRA_AUDIO_26M_B>; + clock-names = "aud_afe_clk", + "aud_dac_clk", + "aud_dac_predis_clk", + "aud_infra_clk", + "aud_infra_26m_clk"; + }; + +...
On Thu, Aug 26, 2021 at 11:19 PM Mark Brown broonie@kernel.org wrote:
On Thu, Aug 26, 2021 at 10:13:14PM +0800, Tzung-Bi Shih wrote:
The dependency has merged. Re-adds back the document.
What is the dependency and where wsa it merged?
The context is in the original email after "---". Do you think it needs to be part of the commit message?
On Thu, Aug 26, 2021 at 11:28:15PM +0800, Tzung-Bi Shih wrote:
On Thu, Aug 26, 2021 at 11:19 PM Mark Brown broonie@kernel.org wrote:
The dependency has merged. Re-adds back the document.
What is the dependency and where wsa it merged?
The context is in the original email after "---". Do you think it needs to be part of the commit message?
I was looking for a description of what these things are and where things are in words - I'm on a train with spotty network access which makes them not as useful as they might be.
Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.
participants (2)
-
Mark Brown -
Tzung-Bi Shih