On 9/7/21 1:46 PM, Pierre-Louis Bossart wrote:

From: Rander Wang rander.wang@intel.com

SOF_CTRL_TYPE_VALUE_CHAN_SET should be used for put operations for consistency. The current use of _GET is obviously incorrect but _GET and _SET result in the same action so there is no functional change introduced by this patch.

Reviewed-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com Signed-off-by: Rander Wang rander.wang@intel.com Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

Please discard this patch, it was already sent by Peter on September 2. The effect of the long week-end I guess...

Sorry for the noise.

---

sound/soc/sof/control.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/sof/control.c b/sound/soc/sof/control.c index a5dd728c580a..504500dd4d43 100644 --- a/sound/soc/sof/control.c +++ b/sound/soc/sof/control.c @@ -108,7 +108,7 @@ int snd_sof_volume_put(struct snd_kcontrol *kcontrol, if (pm_runtime_active(scomp->dev)) snd_sof_ipc_set_get_comp_data(scontrol, SOF_IPC_COMP_SET_VALUE,

• 			      SOF_CTRL_TYPE_VALUE_CHAN_GET,
  

• 			      SOF_CTRL_TYPE_VALUE_CHAN_SET,
  		      SOF_CTRL_CMD_VOLUME,
  		      true);
  

  return change;

@@ -179,7 +179,7 @@ int snd_sof_switch_put(struct snd_kcontrol *kcontrol, if (pm_runtime_active(scomp->dev)) snd_sof_ipc_set_get_comp_data(scontrol, SOF_IPC_COMP_SET_VALUE,

• 			      SOF_CTRL_TYPE_VALUE_CHAN_GET,
  

• 			      SOF_CTRL_TYPE_VALUE_CHAN_SET,
  		      SOF_CTRL_CMD_SWITCH,
  		      true);
  
  

@@ -226,7 +226,7 @@ int snd_sof_enum_put(struct snd_kcontrol *kcontrol, if (pm_runtime_active(scomp->dev)) snd_sof_ipc_set_get_comp_data(scontrol, SOF_IPC_COMP_SET_VALUE,

• 			      SOF_CTRL_TYPE_VALUE_CHAN_GET,
  

• 			      SOF_CTRL_TYPE_VALUE_CHAN_SET,
  		      SOF_CTRL_CMD_ENUM,
  		      true);