[PATCH -next] soundwire: stream: Fix error return code in do_bank_switch()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wang Wensheng wangwensheng4@huawei.com --- drivers/soundwire/stream.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index 980f26d49b66..553131597af6 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -822,6 +822,7 @@ static int do_bank_switch(struct sdw_stream_runtime *stream) } else if (multi_link) { dev_err(bus->dev, "Post bank switch ops not implemented\n"); + ret = -EINVAL; goto error; }
On 3/7/22 01:40, Wang Wensheng wrote:
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wang Wensheng wangwensheng4@huawei.com
Thanks for the patch, sounds good to me.
Reviewed-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
drivers/soundwire/stream.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index 980f26d49b66..553131597af6 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -822,6 +822,7 @@ static int do_bank_switch(struct sdw_stream_runtime *stream) } else if (multi_link) { dev_err(bus->dev, "Post bank switch ops not implemented\n");
ret = -EINVAL; goto error;
participants (3)
-
Pierre-Louis Bossart -
Vinod Koul -
Wang Wensheng