[alsa-devel] [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch
Mismatching stream names in DAPM route and widget definitions are causing compilation errors. Fixing these names allows the cs4270 driver to compile and function.
Signed-off-by: Murray Foster mrafoster@gmail.com --- Changes in v2: - Remove the 's' typo at the beginning of the codec driver.
sound/soc/codecs/cs4270.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index e07807d..3670086 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -148,11 +148,11 @@ SND_SOC_DAPM_OUTPUT("AOUTR"), };
static const struct snd_soc_dapm_route cs4270_dapm_routes[] = { - { "Capture", NULL, "AINA" }, - { "Capture", NULL, "AINB" }, + { "Capture", NULL, "AINL" }, + { "Capture", NULL, "AINR" },
- { "AOUTA", NULL, "Playback" }, - { "AOUTB", NULL, "Playback" }, + { "AOUTL", NULL, "Playback" }, + { "AOUTR", NULL, "Playback" }, };
/**
On 7/2/16, 4:21 AM, "murray foster" mrafoster@gmail.com wrote:
Mismatching stream names in DAPM route and widget definitions are causing compilation errors. Fixing these names allows the cs4270 driver to compile and function.
Signed-off-by: Murray Foster mrafoster@gmail.com
Changes in v2:
- Remove the 's' typo at the beginning of the codec driver.
sound/soc/codecs/cs4270.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index e07807d..3670086 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -148,11 +148,11 @@ SND_SOC_DAPM_OUTPUT("AOUTR"), };
static const struct snd_soc_dapm_route cs4270_dapm_routes[] = {
- { "Capture", NULL, "AINA" },
- { "Capture", NULL, "AINB" },
- { "Capture", NULL, "AINL" },
- { "Capture", NULL, "AINR" },
- { "AOUTA", NULL, "Playback" },
- { "AOUTB", NULL, "Playback" },
- { "AOUTL", NULL, "Playback" },
- { "AOUTR", NULL, "Playback" },
};
Acked-by: Paul Handrigan Paul.Handrigan@cirrus.com
On Fri, 8 Jul 2016, Handrigan, Paul wrote:
Acked-by: Paul Handrigan Paul.Handrigan@cirrus.com
What's the next step after patch acknowledgement? I'm a newbie on the list so I'm sure there's some step I've missed or misinterpreted.
Murray
On 10/06/2016 08:43 PM, murray foster wrote:
On Fri, 8 Jul 2016, Handrigan, Paul wrote:
Acked-by: Paul Handrigan Paul.Handrigan@cirrus.com
What's the next step after patch acknowledgement? I'm a newbie on the list so I'm sure there's some step I've missed or misinterpreted.
Apply is the next step. But sometimes patches get lost, simply due to the sheer volume.
Best is to re-send the patch with the Acked-by added to the commit message and make sure send the patch to maintainers (Mark and Liam) with the ALSA list on Cc. This will make sure that they see the patch and it gets applied.
On Thu, Oct 06, 2016 at 09:41:13PM +0200, Lars-Peter Clausen wrote:
Best is to re-send the patch with the Acked-by added to the commit message and make sure send the patch to maintainers (Mark and Liam) with the ALSA list on Cc. This will make sure that they see the patch and it gets applied.
I didn't get sent the original e-mail in the first place :(
On Thu, Oct 06, 2016 at 11:43:09AM -0700, murray foster wrote:
What's the next step after patch acknowledgement? I'm a newbie on the list so I'm sure there's some step I've missed or misinterpreted.
As documented in SubmittingPatches please send patches to the maintainers for the code you would like to change. The normal kernel workflow is that people apply patches from their inboxes, if they aren't copied they are likely to not see the patch at all and it is much more difficult to apply patches.
participants (4)
-
Handrigan, Paul -
Lars-Peter Clausen -
Mark Brown -
murray foster