[PATCH] ASoC: amd: vangogh: add SPI dependency
From: Arnd Bergmann arnd@arndb.de
Without CONFIG_SPI, this fails to build:
WARNING: unmet direct dependencies detected for SND_SOC_CS35L41_SPI Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SPI_MASTER [=n] Selected by [m]: - SND_SOC_AMD_VANGOGH_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_AMD_ACP5x [=m] && I2C [=y] ERROR: modpost: "spi_setup" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined! ERROR: modpost: "__devm_regmap_init_spi" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined!
Fixes: 96792fdd77cd ("ASoC: amd: enable vangogh platform machine driver build") Signed-off-by: Arnd Bergmann arnd@arndb.de --- sound/soc/amd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index d91a9399777c..edee2098c82e 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH tristate "AMD Vangogh support for NAU8821 CS35L41" select SND_SOC_NAU8821 select SND_SOC_CS35L41_SPI - depends on SND_SOC_AMD_ACP5x && I2C + depends on SND_SOC_AMD_ACP5x && I2C && SPI help This option enables machine driver for Vangogh platform using NAU8821 and CS35L41 codecs.
On 10/19/21 12:14 PM, Arnd Bergmann wrote:
From: Arnd Bergmann arnd@arndb.de
Without CONFIG_SPI, this fails to build:
WARNING: unmet direct dependencies detected for SND_SOC_CS35L41_SPI Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SPI_MASTER [=n] Selected by [m]:
- SND_SOC_AMD_VANGOGH_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_AMD_ACP5x [=m] && I2C [=y]
ERROR: modpost: "spi_setup" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined! ERROR: modpost: "__devm_regmap_init_spi" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined!
Fixes: 96792fdd77cd ("ASoC: amd: enable vangogh platform machine driver build") Signed-off-by: Arnd Bergmann arnd@arndb.de
sound/soc/amd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index d91a9399777c..edee2098c82e 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH tristate "AMD Vangogh support for NAU8821 CS35L41" select SND_SOC_NAU8821 select SND_SOC_CS35L41_SPI
- depends on SND_SOC_AMD_ACP5x && I2C
- depends on SND_SOC_AMD_ACP5x && I2C && SPI help This option enables machine driver for Vangogh platform using NAU8821 and CS35L41 codecs.
Reviewed-by: Randy Dunlap rdunlap@infradead.org
Just had this build error in linux-next-20211103 so this patch is needed there.
Thanks.
participants (2)
-
Arnd Bergmann -
Randy Dunlap