On Fri, Aug 27, 2021 at 05:59:30AM +0000, Derek [方德義] wrote:

...

...

+#ifdef CONFIG_COMMON_CLK

• /* Check if MCLK provided */
• rt5682s->mclk = devm_clk_get(component->dev, "mclk");

Perhaps factor the clock init out into a _probe_clks() function and then have a stub function rather than the two ifdefs?

We want to factor the codes like below to reduce ifdefs. Could you give any comments?

That looks fine.