[alsa-devel] [PATCH] ALSA: hda - Add a de-pop quirk for some HP machines
On some HP machines, there will be pop noise when the machine is shutting down, rebooting or booting up from poweroff state.
Set EAPD enable only when stream starts can help to fix this problem.
[The patch was originally written by Kailang, we tested it and rebased it on latest kernel.]
Signed-off-by: Kailang Yang kailang@realtek.com Signed-off-by: Hui Wang hui.wang@canonical.com --- sound/pci/hda/patch_realtek.c | 55 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 52 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 48d6d10..51811a6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4282,6 +4282,47 @@ static void alc290_fixup_mono_speakers(struct hda_codec *codec, } }
+/* + * ALC290 PCM hooks + */ +static void alc290_playback_pcm_hook(struct hda_pcm_stream *hinfo, + struct hda_codec *codec, + struct snd_pcm_substream *substream, + int action) +{ + int val; + + switch (action) { + case HDA_GEN_PCM_ACT_OPEN: + val = alc_read_coef_idx(codec, 0x4); /* EAPD manual high */ + if ((val & 0xc000) != 0xc000) + alc_write_coef_idx(codec, 0x4, val | (1<<14)); + break; + } +} + +static void alc290_fixup_pop_noise(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct alc_spec *spec = codec->spec; + int val; + + switch (action) { + case HDA_FIXUP_ACT_PRE_PROBE: + snd_hda_codec_write(codec, 0x17, 0, + AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT); + val = alc_read_coef_idx(codec, 0x4); + if ((val & 0xc000) != 0xc000) + alc_write_coef_idx(codec, 0x4, val | (3<<14)); /* EAPD low */ + spec->gen.pcm_playback_hook = alc290_playback_pcm_hook; + break; + case HDA_FIXUP_ACT_INIT: + snd_hda_codec_write(codec, 0x17, 0, + AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT); + break; + } +} + /* for hda_fixup_thinkpad_acpi() */ #include "thinkpad_helper.c"
@@ -4354,6 +4395,7 @@ enum { ALC283_FIXUP_BXBT2807_MIC, ALC255_FIXUP_DELL_WMI_MIC_MUTE_LED, ALC282_FIXUP_ASPIRE_V5_PINS, + ALC290_FIXUP_HP_DEPOP_WITH_MUTE_LED, };
static const struct hda_fixup alc269_fixups[] = { @@ -4817,7 +4859,12 @@ static const struct hda_fixup alc269_fixups[] = { { }, }, }, - + [ALC290_FIXUP_HP_DEPOP_WITH_MUTE_LED] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc290_fixup_pop_noise, + .chained = true, + .chain_id = ALC269_FIXUP_HP_MUTE_LED_MIC1, + }, };
static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -4975,12 +5022,14 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x2280, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x2281, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x2282, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), - SND_PCI_QUIRK(0x103c, 0x2289, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), + SND_PCI_QUIRK(0x103c, 0x2289, "HP", ALC290_FIXUP_HP_DEPOP_WITH_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x228a, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x228b, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), - SND_PCI_QUIRK(0x103c, 0x228c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), + SND_PCI_QUIRK(0x103c, 0x228c, "HP", ALC290_FIXUP_HP_DEPOP_WITH_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x228d, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x228e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), + SND_PCI_QUIRK(0x103c, 0x228f, "HP", ALC290_FIXUP_HP_DEPOP_WITH_MUTE_LED), + SND_PCI_QUIRK(0x103c, 0x22a8, "HP", ALC290_FIXUP_HP_DEPOP_WITH_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x22c5, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x22c6, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x22c7, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
At Fri, 29 Aug 2014 15:47:05 +0800, Hui Wang wrote:
On some HP machines, there will be pop noise when the machine is shutting down, rebooting or booting up from poweroff state.
Set EAPD enable only when stream starts can help to fix this problem.
[The patch was originally written by Kailang, we tested it and rebased it on latest kernel.]
Signed-off-by: Kailang Yang kailang@realtek.com Signed-off-by: Hui Wang hui.wang@canonical.com
sound/pci/hda/patch_realtek.c | 55 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 52 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 48d6d10..51811a6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4282,6 +4282,47 @@ static void alc290_fixup_mono_speakers(struct hda_codec *codec, } }
+/*
- ALC290 PCM hooks
- */
+static void alc290_playback_pcm_hook(struct hda_pcm_stream *hinfo,
struct hda_codec *codec,struct snd_pcm_substream *substream,int action)+{
- int val;
- switch (action) {
- case HDA_GEN_PCM_ACT_OPEN:
val = alc_read_coef_idx(codec, 0x4); /* EAPD manual high */if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val | (1<<14));break;- }
+}
+static void alc290_fixup_pop_noise(struct hda_codec *codec,
const struct hda_fixup *fix, int action)+{
- struct alc_spec *spec = codec->spec;
- int val;
- switch (action) {
- case HDA_FIXUP_ACT_PRE_PROBE:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
Why do you need this...
val = alc_read_coef_idx(codec, 0x4);if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val | (3<<14)); /* EAPD low */spec->gen.pcm_playback_hook = alc290_playback_pcm_hook;break;- case HDA_FIXUP_ACT_INIT:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
... and this? There is no explanation about this change.
Also, can't you just set EAPD low in the shutdown callback instead?
In your patch, if the machine goes shutdown/reboot while playing a stream (or before runtime PM), it's still EAPD high, so the noise should be heard, if I understand correctly.
Takashi
On 2014年08月29日 16:02, Takashi Iwai wrote:
At Fri, 29 Aug 2014 15:47:05 +0800, Hui Wang wrote:
On some HP machines, there will be pop noise when the machine is shutting down, rebooting or booting up from poweroff state.
Set EAPD enable only when stream starts can help to fix this problem.
[The patch was originally written by Kailang, we tested it and rebased it on latest kernel.]
Signed-off-by: Kailang Yang kailang@realtek.com Signed-off-by: Hui Wang hui.wang@canonical.com
sound/pci/hda/patch_realtek.c | 55 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 52 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 48d6d10..51811a6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4282,6 +4282,47 @@ static void alc290_fixup_mono_speakers(struct hda_codec *codec, } }
+/*
- ALC290 PCM hooks
- */
+static void alc290_playback_pcm_hook(struct hda_pcm_stream *hinfo,
struct hda_codec *codec,struct snd_pcm_substream *substream,int action)+{
- int val;
- switch (action) {
- case HDA_GEN_PCM_ACT_OPEN:
val = alc_read_coef_idx(codec, 0x4); /* EAPD manual high */if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val | (1<<14));break;- }
+}
+static void alc290_fixup_pop_noise(struct hda_codec *codec,
const struct hda_fixup *fix, int action)+{
- struct alc_spec *spec = codec->spec;
- int val;
- switch (action) {
- case HDA_FIXUP_ACT_PRE_PROBE:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);Why do you need this...
val = alc_read_coef_idx(codec, 0x4);if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val | (3<<14)); /* EAPD low */spec->gen.pcm_playback_hook = alc290_playback_pcm_hook;break;- case HDA_FIXUP_ACT_INIT:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);... and this? There is no explanation about this change.
Also, can't you just set EAPD low in the shutdown callback instead?
Good idea, all will be addressed in the V2.
Thanks, Hui.
In your patch, if the machine goes shutdown/reboot while playing a stream (or before runtime PM), it's still EAPD high, so the noise should be heard, if I understand correctly.
Takashi
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Friday, August 29, 2014 4:03 PM To: Hui Wang Cc: alsa-devel@alsa-project.org; Kailang; stable@vger.kernel.org Subject: Re: [PATCH] ALSA: hda - Add a de-pop quirk for some HP machines
At Fri, 29 Aug 2014 15:47:05 +0800, Hui Wang wrote:
On some HP machines, there will be pop noise when the machine is shutting down, rebooting or booting up from poweroff state.
Set EAPD enable only when stream starts can help to fix
this problem.
[The patch was originally written by Kailang, we tested it
and rebased
it on latest kernel.]
Signed-off-by: Kailang Yang kailang@realtek.com Signed-off-by: Hui Wang hui.wang@canonical.com
sound/pci/hda/patch_realtek.c | 55 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 52 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 48d6d10..51811a6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4282,6 +4282,47 @@ static void
alc290_fixup_mono_speakers(struct hda_codec *codec,
} }
+/*
- ALC290 PCM hooks
- */
+static void alc290_playback_pcm_hook(struct hda_pcm_stream *hinfo,
struct hda_codec *codec,struct snd_pcm_substream*substream,
int action)+{
- int val;
- switch (action) {
- case HDA_GEN_PCM_ACT_OPEN:
val = alc_read_coef_idx(codec, 0x4); /* EAPDmanual high */
if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val | (1<<14));break;- }
+}
+static void alc290_fixup_pop_noise(struct hda_codec *codec,
const struct hda_fixup *fix,int action) {
- struct alc_spec *spec = codec->spec;
- int val;
- switch (action) {
- case HDA_FIXUP_ACT_PRE_PROBE:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
Why do you need this...
This is reauest by HP. They say Keep this to output will lower pop noise from woofer speaker.
val = alc_read_coef_idx(codec, 0x4);if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val |(3<<14)); /* EAPD low */
spec->gen.pcm_playback_hook = alc290_playback_pcm_hook;break;- case HDA_FIXUP_ACT_INIT:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
... and this? There is no explanation about this change.
Also, can't you just set EAPD low in the shutdown callback instead?
In your patch, if the machine goes shutdown/reboot while playing a stream (or before runtime PM), it's still EAPD high, so the noise should be heard, if I understand correctly.
EAPD keep high, no change state will no pop noise. EC will control the delay for 30s to do AMP pin to high. When it enter to S3, EAPD will go low. Resume back, the eapd will go high. It will show pop noise. This is not have method to improve for this hardware issue in this state.
Takashi
------Please consider the environment before printing this e-mail.
At Fri, 29 Aug 2014 08:29:52 +0000, Kailang wrote:
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Friday, August 29, 2014 4:03 PM To: Hui Wang Cc: alsa-devel@alsa-project.org; Kailang; stable@vger.kernel.org Subject: Re: [PATCH] ALSA: hda - Add a de-pop quirk for some HP machines
At Fri, 29 Aug 2014 15:47:05 +0800, Hui Wang wrote:
On some HP machines, there will be pop noise when the machine is shutting down, rebooting or booting up from poweroff state.
Set EAPD enable only when stream starts can help to fix
this problem.
[The patch was originally written by Kailang, we tested it
and rebased
it on latest kernel.]
Signed-off-by: Kailang Yang kailang@realtek.com Signed-off-by: Hui Wang hui.wang@canonical.com
sound/pci/hda/patch_realtek.c | 55 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 52 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 48d6d10..51811a6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4282,6 +4282,47 @@ static void
alc290_fixup_mono_speakers(struct hda_codec *codec,
} }
+/*
- ALC290 PCM hooks
- */
+static void alc290_playback_pcm_hook(struct hda_pcm_stream *hinfo,
struct hda_codec *codec,struct snd_pcm_substream*substream,
int action)+{
- int val;
- switch (action) {
- case HDA_GEN_PCM_ACT_OPEN:
val = alc_read_coef_idx(codec, 0x4); /* EAPDmanual high */
if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val | (1<<14));break;- }
+}
+static void alc290_fixup_pop_noise(struct hda_codec *codec,
const struct hda_fixup *fix,int action) {
- struct alc_spec *spec = codec->spec;
- int val;
- switch (action) {
- case HDA_FIXUP_ACT_PRE_PROBE:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
Why do you need this...
This is reauest by HP. They say Keep this to output will lower pop noise from woofer speaker.
OK, then please add the comment.
val = alc_read_coef_idx(codec, 0x4);if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val |(3<<14)); /* EAPD low */
spec->gen.pcm_playback_hook = alc290_playback_pcm_hook;break;- case HDA_FIXUP_ACT_INIT:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
... and this? There is no explanation about this change.
Also, can't you just set EAPD low in the shutdown callback instead?
In your patch, if the machine goes shutdown/reboot while playing a stream (or before runtime PM), it's still EAPD high, so the noise should be heard, if I understand correctly.
EAPD keep high, no change state will no pop noise. EC will control the delay for 30s to do AMP pin to high. When it enter to S3, EAPD will go low. Resume back, the eapd will go high. It will show pop noise.
The bug description is about the shutdown or the bootup, not S3. But the cause is the same?
This is not have method to improve for this hardware issue in this state.
Well, we really need more detailed description what the exact problem is, what the patch does and how it fixes the issue. The code change itself looks trivial enough, but the more important thing -- the information -- is missing in the patch.
thanks,
Takashi
On 08/29/2014 06:06 PM, Takashi Iwai wrote:
At Fri, 29 Aug 2014 08:29:52 +0000, Kailang wrote:
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Friday, August 29, 2014 4:03 PM To: Hui Wang Cc: alsa-devel@alsa-project.org; Kailang; stable@vger.kernel.org Subject: Re: [PATCH] ALSA: hda - Add a de-pop quirk for some HP machines
At Fri, 29 Aug 2014 15:47:05 +0800, Hui Wang wrote:
On some HP machines, there will be pop noise when the machine is shutting down, rebooting or booting up from poweroff state.
Set EAPD enable only when stream starts can help to fix
this problem.
[The patch was originally written by Kailang, we tested it
and rebased
it on latest kernel.]
Signed-off-by: Kailang Yang kailang@realtek.com Signed-off-by: Hui Wang hui.wang@canonical.com
sound/pci/hda/patch_realtek.c | 55 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 52 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 48d6d10..51811a6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4282,6 +4282,47 @@ static void
alc290_fixup_mono_speakers(struct hda_codec *codec,
} }
+/*
- ALC290 PCM hooks
- */
+static void alc290_playback_pcm_hook(struct hda_pcm_stream *hinfo,
struct hda_codec *codec,struct snd_pcm_substream*substream,
int action)+{
- int val;
- switch (action) {
- case HDA_GEN_PCM_ACT_OPEN:
val = alc_read_coef_idx(codec, 0x4); /* EAPDmanual high */
if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val | (1<<14));break;- }
+}
+static void alc290_fixup_pop_noise(struct hda_codec *codec,
const struct hda_fixup *fix,int action) {
- struct alc_spec *spec = codec->spec;
- int val;
- switch (action) {
- case HDA_FIXUP_ACT_PRE_PROBE:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
Why do you need this...
This is reauest by HP. They say Keep this to output will lower pop noise from woofer speaker.
OK, then please add the comment.
val = alc_read_coef_idx(codec, 0x4);if ((val & 0xc000) != 0xc000)alc_write_coef_idx(codec, 0x4, val |(3<<14)); /* EAPD low */
spec->gen.pcm_playback_hook = alc290_playback_pcm_hook;break;- case HDA_FIXUP_ACT_INIT:
snd_hda_codec_write(codec, 0x17, 0,AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
... and this? There is no explanation about this change.
Also, can't you just set EAPD low in the shutdown callback instead?
In your patch, if the machine goes shutdown/reboot while playing a stream (or before runtime PM), it's still EAPD high, so the noise should be heard, if I understand correctly.
EAPD keep high, no change state will no pop noise. EC will control the delay for 30s to do AMP pin to high. When it enter to S3, EAPD will go low. Resume back, the eapd will go high. It will show pop noise.
The bug description is about the shutdown or the bootup, not S3. But the cause is the same?
This is not have method to improve for this hardware issue in this state.
Well, we really need more detailed description what the exact problem is, what the patch does and how it fixes the issue. The code change itself looks trivial enough, but the more important thing -- the information -- is missing in the patch.
I just checked again, this fix is for two bugs, one is the pop noise occurs when resume from S3, another is the pop noise occurs when shutdown, reboot, and boot from poweroff. It seems this bug can fix all of them.
I will gather more information and add detailed description in the V2.
Thanks, Hui.
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (4)
-
Hui Wang -
hwang4
-
Kailang -
Takashi Iwai