[PATCH] regmap: sdw: add required header files
From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Explicitly add header files used by regmap SoundWire support.
Suggested-by: Guennadi Liakhovetski guennadi.liakhovetski@linux.intel.com Reviewed-by: Rander Wang rander.wang@linux.intel.com Reviewed-by: Guennadi Liakhovetski guennadi.liakhovetski@linux.intel.com Reviewed-by: Kai Vehmanen kai.vehmanen@linux.intel.com Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com Signed-off-by: Bard Liao yung-chuan.liao@linux.intel.com --- drivers/base/regmap/regmap-sdw.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/base/regmap/regmap-sdw.c b/drivers/base/regmap/regmap-sdw.c index c92d614b4943..c83be26434e7 100644 --- a/drivers/base/regmap/regmap-sdw.c +++ b/drivers/base/regmap/regmap-sdw.c @@ -2,7 +2,9 @@ // Copyright(c) 2015-17 Intel Corporation.
#include <linux/device.h> +#include <linux/errno.h> #include <linux/module.h> +#include <linux/regmap.h> #include <linux/soundwire/sdw.h> #include "internal.h"
On Wed, Nov 25, 2020 at 09:01:28PM +0800, Bard Liao wrote:
From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Explicitly add header files used by regmap SoundWire support.
What is failing to build without this?
thanks,
greg k-h
-----Original Message----- From: Greg KH gregkh@linuxfoundation.org Sent: Thursday, November 26, 2020 1:35 PM To: Bard Liao yung-chuan.liao@linux.intel.com Cc: alsa-devel@alsa-project.org; vkoul@kernel.org; vinod.koul@linaro.org; linux-kernel@vger.kernel.org; tiwai@suse.de; broonie@kernel.org; jank@cadence.com; srinivas.kandagatla@linaro.org; rander.wang@linux.intel.com; ranjani.sridharan@linux.intel.com; hui.wang@canonical.com; pierre-louis.bossart@linux.intel.com; Kale, Sanyog R sanyog.r.kale@intel.com; Liao, Bard bard.liao@intel.com Subject: Re: [PATCH] regmap: sdw: add required header files
On Wed, Nov 25, 2020 at 09:01:28PM +0800, Bard Liao wrote:
From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Explicitly add header files used by regmap SoundWire support.
What is failing to build without this?
I didn't see build errors. But, Documentation/process/submit-checklist.rst says. 1) If you use a facility then #include the file that defines/declares that facility. Don't depend on other header files pulling in ones that you use.
thanks,
greg k-h
On Wed, 25 Nov 2020 21:01:28 +0800, Bard Liao wrote:
Explicitly add header files used by regmap SoundWire support.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next
Thanks!
[1/1] regmap: sdw: add required header files commit: d9a500b2985b139d7019231ec16e379d2031cb40
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (4)
-
Bard Liao -
Greg KH -
Liao, Bard -
Mark Brown