[PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message
In commit <c3ecef21c3f26> ("ASoC: fsl_sai: add sai master mode support") the loop was changed to start iterating from 1 instead of 0. The error message however was not updated, reporting the wrong clock to the user.
Signed-off-by: Pieterjan Camerlynck pieterjan.camerlynck@gmail.com --- sound/soc/fsl/fsl_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index ffc24afb5a7a..f0602077b385 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -1054,7 +1054,7 @@ static int fsl_sai_probe(struct platform_device *pdev) sai->mclk_clk[i] = devm_clk_get(&pdev->dev, tmp); if (IS_ERR(sai->mclk_clk[i])) { dev_err(&pdev->dev, "failed to get mclk%d clock: %ld\n", - i + 1, PTR_ERR(sai->mclk_clk[i])); + i, PTR_ERR(sai->mclk_clk[i])); sai->mclk_clk[i] = NULL; } }
On Sat, May 7, 2022 at 8:31 PM Pieterjan Camerlynck < pieterjan.camerlynck@gmail.com> wrote:
In commit <c3ecef21c3f26> ("ASoC: fsl_sai: add sai master mode support") the loop was changed to start iterating from 1 instead of 0. The error message however was not updated, reporting the wrong clock to the user.
Signed-off-by: Pieterjan Camerlynck pieterjan.camerlynck@gmail.com
Acked-by: Shengjiu Wang shengjiu.wang@gmail.com
Best Regards Wang Shengjiu
sound/soc/fsl/fsl_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index ffc24afb5a7a..f0602077b385 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -1054,7 +1054,7 @@ static int fsl_sai_probe(struct platform_device *pdev) sai->mclk_clk[i] = devm_clk_get(&pdev->dev, tmp); if (IS_ERR(sai->mclk_clk[i])) { dev_err(&pdev->dev, "failed to get mclk%d clock: %ld\n",
i + 1, PTR_ERR(sai->mclk_clk[i]));
i, PTR_ERR(sai->mclk_clk[i])); sai->mclk_clk[i] = NULL; } }-- 2.25.1
On Sat, May 7, 2022 at 8:31 PM Pieterjan Camerlynck < pieterjan.camerlynck@gmail.com> wrote:
In commit <c3ecef21c3f26> ("ASoC: fsl_sai: add sai master mode support") the loop was changed to start iterating from 1 instead of 0. The error message however was not updated, reporting the wrong clock to the user.
Signed-off-by: Pieterjan Camerlynck pieterjan.camerlynck@gmail.com
Please resend it and cc Mark
Best regards Wang shengjiu
sound/soc/fsl/fsl_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index ffc24afb5a7a..f0602077b385 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -1054,7 +1054,7 @@ static int fsl_sai_probe(struct platform_device *pdev) sai->mclk_clk[i] = devm_clk_get(&pdev->dev, tmp); if (IS_ERR(sai->mclk_clk[i])) { dev_err(&pdev->dev, "failed to get mclk%d clock: %ld\n",
i + 1, PTR_ERR(sai->mclk_clk[i]));
i, PTR_ERR(sai->mclk_clk[i])); sai->mclk_clk[i] = NULL; } }-- 2.25.1
participants (2)
-
Pieterjan Camerlynck -
Shengjiu Wang