[PATCH v3 3/5] ASoC: tas2781: Add tas2781 driver
Create tas2781 driver.
Signed-off-by: Shenghao Ding 13916275206@139.com
--- Changes in v3: - fixed issue | Reported-by: kernel test robot lkp@intel.com | Link: https://lore.kernel.org/oe-kbuild-all/202305022033.LiI7Ojm4-lkp@intel.com/ - fixed issue | Reported-by: kernel test robot lkp@intel.com | Link: https://lore.kernel.org/oe-kbuild-all/202305022338.ZA1okoZW-lkp@intel.com/ Changes to be committed: modified: sound/soc/codecs/Kconfig modified: sound/soc/codecs/Makefile new file: sound/soc/codecs/tas2781-comlib.c new file: sound/soc/codecs/tas2781-i2c.c --- sound/soc/codecs/Kconfig | 24 + sound/soc/codecs/Makefile | 6 + sound/soc/codecs/tas2781-comlib.c | 581 ++++++++++++++++++++++++ sound/soc/codecs/tas2781-i2c.c | 722 ++++++++++++++++++++++++++++++ 4 files changed, 1333 insertions(+) create mode 100644 sound/soc/codecs/tas2781-comlib.c create mode 100644 sound/soc/codecs/tas2781-i2c.c
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 8020097d4e4c..4ee7d8fee526 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -234,6 +234,9 @@ config SND_SOC_ALL_CODECS imply SND_SOC_TAS2764 imply SND_SOC_TAS2770 imply SND_SOC_TAS2780 + imply SND_SOC_TAS2781_COMLIB + imply SND_SOC_TAS2781_FMWLIB + imply SND_SOC_TAS2781 imply SND_SOC_TAS5086 imply SND_SOC_TAS571X imply SND_SOC_TAS5720 @@ -1699,6 +1702,27 @@ config SND_SOC_TAS2780 Enable support for Texas Instruments TAS2780 high-efficiency digital input mono Class-D audio power amplifiers.
+config SND_SOC_TAS2781_COMLIB + select CRC8 + select REGMAP_I2C + tristate + +config SND_SOC_TAS2781_FMWLIB + tristate + default n + +config SND_SOC_TAS2781 + tristate "Texas Instruments TAS2781 speaker amplifier" + depends on I2C + select SND_SOC_TAS2781_COMLIB + select SND_SOC_TAS2781_FMWLIB + help + Enable support for Texas Instruments TAS2781 Smart Amplifier + Digital input mono Class-D and DSP-inside audio power amplifiers. + Note the TAS2781 driver implements a flexible and configurable + algo coefficient setting, for one, two or even multiple TAS2781 + chips. + config SND_SOC_TAS5086 tristate "Texas Instruments TAS5086 speaker amplifier" depends on I2C diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile index 5cdbae88e6e3..97c3881ed587 100644 --- a/sound/soc/codecs/Makefile +++ b/sound/soc/codecs/Makefile @@ -269,6 +269,9 @@ snd-soc-tas5805m-objs := tas5805m.o snd-soc-tas6424-objs := tas6424.o snd-soc-tda7419-objs := tda7419.o snd-soc-tas2770-objs := tas2770.o +snd-soc-tas2781-comlib-objs := tas2781-comlib.o +snd-soc-tas2781-fmwlib-objs := tas2781-fmwlib.o +snd-soc-tas2781-objs := tas2781-i2c.o snd-soc-tfa9879-objs := tfa9879.o snd-soc-tfa989x-objs := tfa989x.o snd-soc-tlv320adc3xxx-objs := tlv320adc3xxx.o @@ -633,6 +636,9 @@ obj-$(CONFIG_SND_SOC_TAS2552) += snd-soc-tas2552.o obj-$(CONFIG_SND_SOC_TAS2562) += snd-soc-tas2562.o obj-$(CONFIG_SND_SOC_TAS2764) += snd-soc-tas2764.o obj-$(CONFIG_SND_SOC_TAS2780) += snd-soc-tas2780.o +obj-$(CONFIG_SND_SOC_TAS2781_COMLIB) += snd-soc-tas2781-comlib.o +obj-$(CONFIG_SND_SOC_TAS2781_FMWLIB) += snd-soc-tas2781-fmwlib.o +obj-$(CONFIG_SND_SOC_TAS2781) += snd-soc-tas2781.o obj-$(CONFIG_SND_SOC_TAS5086) += snd-soc-tas5086.o obj-$(CONFIG_SND_SOC_TAS571X) += snd-soc-tas571x.o obj-$(CONFIG_SND_SOC_TAS5720) += snd-soc-tas5720.o diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-comlib.c new file mode 100644 index 000000000000..5994698326b1 --- /dev/null +++ b/sound/soc/codecs/tas2781-comlib.c @@ -0,0 +1,581 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// tas2781-lib.c -- TAS2781 Common functions for HDA and ASoC Audio drivers +// +// Copyright 2023 Texas Instruments, Inc. +// +// Author: Shenghao Ding shenghao-ding@ti.com + +#include <linux/crc8.h> +#include <linux/firmware.h> +#include <linux/gpio/consumer.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/interrupt.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_gpio.h> +#include <linux/of_irq.h> +#include <linux/regmap.h> +#include <linux/slab.h> +#include <sound/pcm_params.h> +#include <sound/soc.h> +#include <sound/tas2781.h> + +#define TASDEVICE_CRC8_POLYNOMIAL 0x4d + +static const struct regmap_range_cfg tasdevice_ranges[] = { + { + .range_min = 0, + .range_max = 256 * 128, + .selector_reg = TASDEVICE_PAGE_SELECT, + .selector_mask = 0xff, + .selector_shift = 0, + .window_start = 0, + .window_len = 128, + }, +}; + +static const struct regmap_config tasdevice_regmap = { + .reg_bits = 8, + .val_bits = 8, + .cache_type = REGCACHE_RBTREE, + .ranges = tasdevice_ranges, + .num_ranges = ARRAY_SIZE(tasdevice_ranges), + .max_register = 256 * 128, +}; + +static int tasdevice_change_chn_book(struct tasdevice_priv *tas_priv, + enum channel chn, int book) +{ + struct i2c_client *client = (struct i2c_client *)tas_priv->client; + int ret = 0; + int i; + + if (chn < tas_priv->ndev) { + struct tasdevice *tasdev = &tas_priv->tasdevice[chn]; + + if (tas_priv->glb_addr.ref_cnt != 0) { + tas_priv->glb_addr.ref_cnt = 0; + tas_priv->glb_addr.cur_book = -1; + } + client->addr = tasdev->dev_addr; + if (tasdev->cur_book != book) { + ret = regmap_write(tas_priv->regmap, + TASDEVICE_BOOKCTL_REG, book); + if (ret < 0) { + dev_err(tas_priv->dev, "%s, E=%d\n", + __func__, ret); + goto out; + } + tasdev->cur_book = book; + } + } else if (chn == tas_priv->ndev) { + struct global_addr *glb_addr = &tas_priv->glb_addr; + + /* Chn == device number will enable global broadcast mode*/ + if (tas_priv->glb_addr.ref_cnt == 0) + for (i = 0; i < tas_priv->ndev; i++) + tas_priv->tasdevice[i].cur_book = -1; + client->addr = glb_addr->dev_addr; + if (glb_addr->cur_book != book) { + ret = regmap_write(tas_priv->regmap, + TASDEVICE_BOOKCTL_REG, book); + if (ret < 0) { + dev_err(tas_priv->dev, "%s, book%x, E=%d\n", + __func__, book, ret); + goto out; + } + glb_addr->cur_book = book; + } + + glb_addr->ref_cnt++; + } else { + ret = -EINVAL; + dev_err(tas_priv->dev, "%s, no such channel(%d)\n", __func__, + chn); + } + +out: + return ret; +} + +int tasdevice_dev_read(struct tasdevice_priv *tas_priv, + enum channel chn, unsigned int reg, unsigned int *val) +{ + int ret = 0; + + if (chn < tas_priv->ndev) { + ret = tasdevice_change_chn_book(tas_priv, chn, + TASDEVICE_BOOK_ID(reg)); + if (ret < 0) + goto out; + + ret = regmap_read(tas_priv->regmap, TASDEVICE_PGRG(reg), val); + if (ret < 0) + dev_err(tas_priv->dev, "%s, E=%d\n", __func__, ret); + } else { + ret = -EINVAL; + dev_err(tas_priv->dev, "%s, no such channel(%d)\n", __func__, + chn); + } + +out: + return ret; +} +EXPORT_SYMBOL_GPL(tasdevice_dev_read); + +int tasdevice_dev_write(struct tasdevice_priv *tas_priv, + enum channel chn, unsigned int reg, unsigned int value) +{ + int ret = 0; + + /* chn <= tas_dev->ndev will support global broadcast mode*/ + if (chn <= tas_priv->ndev) { + ret = tasdevice_change_chn_book(tas_priv, chn, + TASDEVICE_BOOK_ID(reg)); + if (ret < 0) + goto out; + + ret = regmap_write(tas_priv->regmap, TASDEVICE_PGRG(reg), + value); + if (ret < 0) + dev_err(tas_priv->dev, "%s, E=%d\n", __func__, ret); + } else { + ret = -EINVAL; + dev_err(tas_priv->dev, "%s, no such channel(%d)\n", __func__, + chn); + } + +out: + return ret; +} +EXPORT_SYMBOL_GPL(tasdevice_dev_write); + +int tasdevice_dev_bulk_write( + struct tasdevice_priv *tas_priv, enum channel chn, + unsigned int reg, unsigned char *data, + unsigned int len) +{ + int ret = 0; + + /* chn <= tas_dev->ndev will support global broadcast mode*/ + if (chn <= tas_priv->ndev) { + ret = tasdevice_change_chn_book(tas_priv, chn, + TASDEVICE_BOOK_ID(reg)); + if (ret < 0) + goto out; + + ret = regmap_bulk_write(tas_priv->regmap, TASDEVICE_PGRG(reg), + data, len); + if (ret < 0) + dev_err(tas_priv->dev, "%s, E=%d\n", __func__, ret); + } else { + ret = -EINVAL; + dev_err(tas_priv->dev, "%s, no such channel(%d)\n", __func__, + chn); + } + +out: + return ret; +} +EXPORT_SYMBOL_GPL(tasdevice_dev_bulk_write); + +int tasdevice_dev_bulk_read(struct tasdevice_priv *tas_priv, + enum channel chn, unsigned int reg, unsigned char *data, + unsigned int len) +{ + int ret = 0; + + if (chn < tas_priv->ndev) { + ret = tasdevice_change_chn_book(tas_priv, chn, + TASDEVICE_BOOK_ID(reg)); + if (ret < 0) + goto out; + + ret = regmap_bulk_read(tas_priv->regmap, TASDEVICE_PGRG(reg), + data, len); + if (ret < 0) + dev_err(tas_priv->dev, "%s, E=%d\n", __func__, ret); + } else + dev_err(tas_priv->dev, "%s, no such channel(%d)\n", __func__, + chn); + +out: + return ret; +} +EXPORT_SYMBOL_GPL(tasdevice_dev_bulk_read); + +int tasdevice_dev_update_bits( + struct tasdevice_priv *tas_priv, enum channel chn, + unsigned int reg, unsigned int mask, unsigned int value) +{ + int ret = 0; + + /* update-bits can't support global broadcast mode, + * because this operation contains a reading operation + * for register value. In global mode, reading register + * from all of the tas2781 will cause confusion. + */ + if (chn < tas_priv->ndev) { + ret = tasdevice_change_chn_book(tas_priv, chn, + TASDEVICE_BOOK_ID(reg)); + if (ret < 0) + goto out; + + ret = regmap_update_bits(tas_priv->regmap, + TASDEVICE_PGRG(reg), mask, value); + if (ret < 0) + dev_err(tas_priv->dev, "%s, E=%d\n", __func__, ret); + } else { + dev_err(tas_priv->dev, "%s, no such channel(%d)\n", __func__, + chn); + ret = -EINVAL; + } + +out: + return ret; +} +EXPORT_SYMBOL_GPL(tasdevice_dev_update_bits); + +/* Only register write and bulk write support global mode + * Other cases, such as bits update, register read and bulk + * only support device-by-device operation + */ +static void tas2781_set_global_mode(struct tasdevice_priv *tas_priv) +{ + int i, ret; + + for (i = 0; i < tas_priv->ndev; i++) { + ret = tasdevice_dev_update_bits(tas_priv, i, + TAS2781_MISC_CFG2, TAS2781_GLOBAL_ADDR_MASK, + TAS2781_GLOBAL_ADDR_ENABLE); + if (ret < 0) { + dev_err(tas_priv->dev, "%s: chn %d set glb fail, %d\n", + __func__, i, ret); + continue; + } + } +} + +struct tasdevice_priv *tasdevice_kzalloc(struct i2c_client *i2c) +{ + struct tasdevice_priv *tas_priv; + + tas_priv = devm_kzalloc(&i2c->dev, sizeof(*tas_priv), GFP_KERNEL); + if (!tas_priv) + return NULL; + tas_priv->dev = &i2c->dev; + tas_priv->client = (void *)i2c; + + return tas_priv; +} +EXPORT_SYMBOL_GPL(tasdevice_kzalloc); + +void tas2781_reset(struct tasdevice_priv *tas_dev) +{ + int ret, i; + + if (tas_dev->reset) { + gpiod_set_value_cansleep(tas_dev->reset, 0); + usleep_range(500, 1000); + gpiod_set_value_cansleep(tas_dev->reset, 1); + } else { + for (i = 0; i < tas_dev->ndev; i++) { + ret = tasdevice_dev_write(tas_dev, i, + TAS2781_REG_SWRESET, + TAS2781_REG_SWRESET_RESET); + if (ret < 0) + dev_err(tas_dev->dev, + "dev %d swreset fail, %d\n", + i, ret); + } + } + usleep_range(1000, 1050); +} +EXPORT_SYMBOL_GPL(tas2781_reset); + +int tascodec_init(struct tasdevice_priv *tas_priv, void *codec, + void (*cont)(const struct firmware *fw, void *context)) +{ + int ret = 0; + + /* Codec Lock Hold to ensure that codec_probe and firmware parsing and + * loading do not simultaneously execute. + */ + mutex_lock(&tas_priv->codec_lock); + + scnprintf(tas_priv->rca_binaryname, 64, "%srca%d.bin", + tas_priv->dev_name, tas_priv->ndev); + crc8_populate_msb(tas_priv->crc8_lkp_tbl, TASDEVICE_CRC8_POLYNOMIAL); + tas_priv->codec = codec; + ret = request_firmware_nowait(THIS_MODULE, FW_ACTION_UEVENT, + tas_priv->rca_binaryname, tas_priv->dev, GFP_KERNEL, tas_priv, + cont); + if (ret) + dev_err(tas_priv->dev, "request_firmware_nowait err:0x%08x\n", + ret); + + tas2781_reset(tas_priv); + if (tas_priv->set_global_mode) + tas_priv->set_global_mode(tas_priv); + + /* Codec Lock Release*/ + mutex_unlock(&tas_priv->codec_lock); + return ret; +} +EXPORT_SYMBOL_GPL(tascodec_init); + +int tasdevice_init(struct tasdevice_priv *tas_priv) +{ + int ret = 0; + int i; + + tas_priv->regmap = devm_regmap_init_i2c(tas_priv->client, + &tasdevice_regmap); + if (IS_ERR(tas_priv->regmap)) { + ret = PTR_ERR(tas_priv->regmap); + dev_err(tas_priv->dev, "Failed to allocate register map: %d\n", + ret); + goto out; + } + + tas_priv->cur_prog = -1; + tas_priv->cur_conf = -1; + + for (i = 0; i < tas_priv->ndev; i++) { + tas_priv->tasdevice[i].cur_book = -1; + tas_priv->tasdevice[i].cur_prog = -1; + tas_priv->tasdevice[i].cur_conf = -1; + } + + if (tas_priv->glb_addr.dev_addr != 0 + && tas_priv->glb_addr.dev_addr < 0x7F) + tas_priv->set_global_mode = tas2781_set_global_mode; + dev_set_drvdata(tas_priv->dev, tas_priv); + + mutex_init(&tas_priv->codec_lock); + +out: + return ret; +} +EXPORT_SYMBOL_GPL(tasdevice_init); + +static void tasdev_dsp_prog_blk_remove(struct tasdevice_prog *prog) +{ + struct tasdevice_data *im; + struct tasdev_blk *blk; + unsigned int nr_blk; + + if (!prog) + return; + + im = &(prog->dev_data); + + if (!im->dev_blks) + return; + + for (nr_blk = 0; nr_blk < im->nr_blk; nr_blk++) { + blk = &(im->dev_blks[nr_blk]); + kfree(blk->data); + } + kfree(im->dev_blks); +} + +static void tasdev_dsp_prog_remove(struct tasdevice_prog *prog, + unsigned short nr) +{ + int i; + + for (i = 0; i < nr; i++) + tasdev_dsp_prog_blk_remove(&prog[i]); + kfree(prog); +} + +static void tasdev_dsp_cfg_blk_remove(struct tasdevice_config *cfg) +{ + struct tasdevice_data *im; + struct tasdev_blk *blk; + unsigned int nr_blk; + + if (cfg) { + im = &(cfg->dev_data); + + if (!im->dev_blks) + return; + + for (nr_blk = 0; nr_blk < im->nr_blk; nr_blk++) { + blk = &(im->dev_blks[nr_blk]); + kfree(blk->data); + } + kfree(im->dev_blks); + } +} + +static void tasdev_dsp_cfg_remove(struct tasdevice_config *config, + unsigned short nr) +{ + int i; + + for (i = 0; i < nr; i++) + tasdev_dsp_cfg_blk_remove(&config[i]); + kfree(config); +} + +void tasdevice_dsp_remove(void *context) +{ + struct tasdevice_priv *tas_dev = (struct tasdevice_priv *) context; + struct tasdevice_fw *tas_fmw = tas_dev->fmw; + + if (!tas_dev->fmw) + return; + + if (tas_fmw->programs) + tasdev_dsp_prog_remove(tas_fmw->programs, + tas_fmw->nr_programs); + if (tas_fmw->configs) + tasdev_dsp_cfg_remove(tas_fmw->configs, + tas_fmw->nr_configurations); + kfree(tas_fmw); + tas_dev->fmw = NULL; +} +EXPORT_SYMBOL_GPL(tasdevice_dsp_remove); + +void tasdevice_remove(struct tasdevice_priv *tas_priv) +{ + if (gpio_is_valid(tas_priv->irq_info.irq_gpio)) + gpio_free(tas_priv->irq_info.irq_gpio); + kfree(tas_priv->acpi_subsystem_id); + mutex_destroy(&tas_priv->codec_lock); +} +EXPORT_SYMBOL_GPL(tasdevice_remove); + +static int tasdevice_clamp(int val, int max, unsigned int invert) +{ + if (val > max) + val = max; + if (invert) + val = max - val; + if (val < 0) + val = 0; + return val; +} + +int tasdevice_amp_putvol(struct tasdevice_priv *tas_priv, + struct snd_ctl_elem_value *ucontrol, struct soc_mixer_control *mc) +{ + unsigned int invert = mc->invert; + unsigned char mask; + int max = mc->max; + int err_cnt = 0; + int val, i, ret; + + mask = (1 << fls(max)) - 1; + mask <<= mc->shift; + val = tasdevice_clamp(ucontrol->value.integer.value[0], max, invert); + for (i = 0; i < tas_priv->ndev; i++) { + ret = tasdevice_dev_update_bits(tas_priv, i, + mc->reg, mask, (unsigned int)(val << mc->shift)); + if (!ret) + continue; + err_cnt++; + dev_err(tas_priv->dev, "set AMP vol error in dev %d\n", i); + } + + /* All the devices set error, return 0 */ + return (err_cnt == tas_priv->ndev) ? 0 : 1; +} +EXPORT_SYMBOL_GPL(tasdevice_amp_putvol); + +int tasdevice_amp_getvol(struct tasdevice_priv *tas_priv, + struct snd_ctl_elem_value *ucontrol, struct soc_mixer_control *mc) +{ + unsigned int invert = mc->invert; + unsigned char mask = 0; + int max = mc->max; + int ret = 0; + int val; + + /* Read the primary device */ + ret = tasdevice_dev_read(tas_priv, 0, mc->reg, &val); + if (ret) { + dev_err(tas_priv->dev, "%s, get AMP vol error\n", __func__); + goto out; + } + + mask = (1 << fls(max)) - 1; + mask <<= mc->shift; + val = (val & mask) >> mc->shift; + val = tasdevice_clamp(val, max, invert); + ucontrol->value.integer.value[0] = val; + +out: + return ret; + +} +EXPORT_SYMBOL_GPL(tasdevice_amp_getvol); + +int tasdevice_digital_putvol(struct tasdevice_priv *tas_priv, + struct snd_ctl_elem_value *ucontrol, struct soc_mixer_control *mc) +{ + unsigned int invert = mc->invert; + int max = mc->max; + int err_cnt = 0; + int ret = 1; + int val, i; + + val = tasdevice_clamp(ucontrol->value.integer.value[0], max, invert); + + if (tas_priv->set_global_mode) { + ret = tasdevice_dev_write(tas_priv, tas_priv->ndev, + mc->reg, (unsigned int)val); + if (ret) + dev_err(tas_priv->dev, "%s, error in global mode\n", + __func__); + } + + if (!tas_priv->set_global_mode || ret != 0) { + for (i = 0; i < tas_priv->ndev; i++) { + ret = tasdevice_dev_write(tas_priv, i, mc->reg, + (unsigned int)val); + if (!ret) + continue; + err_cnt++; + dev_err(tas_priv->dev, + "set digital vol err in dev %d\n", i); + } + } + + /* All the devices set error, return 0 */ + return (err_cnt == tas_priv->ndev) ? 0 : 1; + +} +EXPORT_SYMBOL_GPL(tasdevice_digital_putvol); + +int tasdevice_digital_getvol(struct tasdevice_priv *tas_priv, + struct snd_ctl_elem_value *ucontrol, struct soc_mixer_control *mc) +{ + unsigned int invert = mc->invert; + int max = mc->max; + int ret, val; + + /* Read the primary device as the whole */ + ret = tasdevice_dev_read(tas_priv, 0, mc->reg, &val); + if (ret) { + dev_err(tas_priv->dev, "%s, get digital vol error\n", + __func__); + goto out; + } + + val = tasdevice_clamp(val, max, invert); + ucontrol->value.integer.value[0] = val; + +out: + return ret; + +} +EXPORT_SYMBOL_GPL(tasdevice_digital_getvol); + +MODULE_DESCRIPTION("TAS2781 common library"); +MODULE_AUTHOR("Shenghao Ding, TI, shenghao-ding@ti.com"); +MODULE_LICENSE("GPL"); diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c new file mode 100644 index 000000000000..343cb04d1ecf --- /dev/null +++ b/sound/soc/codecs/tas2781-i2c.c @@ -0,0 +1,722 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// ALSA SoC Texas Instruments TAS2781 Audio Smart Amplifier +// +// Copyright (C) 2022 - 2023 Texas Instruments Incorporated +// https://www.ti.com +// +// The TAS2781 driver implements a flexible and configurable +// algo coefficient setting for one, two, or even multiple +// TAS2781 chips. +// +// Author: Shenghao Ding shenghao-ding@ti.com +// Author: Kevin Lu kevin-lu@ti.com +// + +#include <linux/crc8.h> +#include <linux/firmware.h> +#include <linux/gpio/consumer.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/interrupt.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_gpio.h> +#include <linux/of_irq.h> +#include <linux/regmap.h> +#include <linux/slab.h> +#include <sound/pcm_params.h> +#include <sound/soc.h> +#include <sound/tas2781.h> +#include <sound/tlv.h> +#include <sound/tas2781-tlv.h> + +static const struct i2c_device_id tasdevice_id[] = { + { "tas2781", TAS2781 }, + {} +}; +MODULE_DEVICE_TABLE(i2c, tasdevice_id); + +#ifdef CONFIG_OF +static const struct of_device_id tasdevice_of_match[] = { + { .compatible = "ti,tas2781" }, + {}, +}; +MODULE_DEVICE_TABLE(of, tasdevice_of_match); +#endif + +/** + * tas2781_digital_getvol - get the volum control + * @kcontrol: control pointer + * @ucontrol: User data + * Customer Kcontrol for tas2781 is primarily for regmap booking, paging + * depends on internal regmap mechanism. + * tas2781 contains book and page two-level register map, especially + * book switching will set the register BXXP00R7F, after switching to the + * correct book, then leverage the mechanism for paging to access the + * register. + */ +static int tas2781_digital_getvol(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + struct soc_mixer_control *mc = + (struct soc_mixer_control *)kcontrol->private_value; + + return tasdevice_digital_getvol(tas_priv, ucontrol, mc); +} + +static int tas2781_digital_putvol(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + struct soc_mixer_control *mc = + (struct soc_mixer_control *)kcontrol->private_value; + + return tasdevice_digital_putvol(tas_priv, ucontrol, mc); +} + +static int tas2781_amp_getvol(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + struct soc_mixer_control *mc = + (struct soc_mixer_control *)kcontrol->private_value; + + return tasdevice_amp_getvol(tas_priv, ucontrol, mc); +} + +static int tas2781_amp_putvol(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = + snd_soc_component_get_drvdata(codec); + struct soc_mixer_control *mc = + (struct soc_mixer_control *)kcontrol->private_value; + + return tasdevice_amp_putvol(tas_priv, ucontrol, mc); +} + +static const struct snd_kcontrol_new tas2781_snd_controls[] = { + SOC_SINGLE_RANGE_EXT_TLV("Amp Gain Volume", TAS2781_AMP_LEVEL, + 1, 0, 20, 0, tas2781_amp_getvol, + tas2781_amp_putvol, amp_vol_tlv), + SOC_SINGLE_RANGE_EXT_TLV("Digital Volume", TAS2781_DVC_LVL, + 0, 0, 200, 1, tas2781_digital_getvol, + tas2781_digital_putvol, dvc_tlv), +}; + +static int tasdevice_set_profile_id(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + + tas_priv->rcabin.profile_cfg_id = ucontrol->value.integer.value[0]; + + return 1; +} + +static int tasdevice_info_programs(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_info *uinfo) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + struct tasdevice_fw *tas_fw = tas_priv->fmw; + + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; + uinfo->count = 1; + uinfo->value.integer.min = 0; + uinfo->value.integer.max = (int)tas_fw->nr_programs; + + return 0; +} + +static int tasdevice_info_configurations( + struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo) +{ + struct snd_soc_component *codec = + snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + struct tasdevice_fw *tas_fw = tas_priv->fmw; + + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; + uinfo->count = 1; + uinfo->value.integer.min = 0; + uinfo->value.integer.max = (int)tas_fw->nr_configurations - 1; + + return 0; +} + +static int tasdevice_info_profile(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_info *uinfo) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; + uinfo->count = 1; + uinfo->value.integer.min = 1; + uinfo->value.integer.max = max(0, tas_priv->rcabin.ncfgs); + + return 0; +} + +static int tasdevice_get_profile_id(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + + ucontrol->value.integer.value[0] = tas_priv->rcabin.profile_cfg_id; + + return 0; +} + +static int tasdevice_create_control(struct tasdevice_priv *tas_priv) +{ + struct snd_kcontrol_new *prof_ctrls; + int nr_controls = 1; + int mix_index = 0; + int ret; + char *name; + + prof_ctrls = devm_kcalloc(tas_priv->dev, nr_controls, + sizeof(prof_ctrls[0]), GFP_KERNEL); + if (!prof_ctrls) { + ret = -ENOMEM; + goto out; + } + + /* Create a mixer item for selecting the active profile */ + name = devm_kzalloc(tas_priv->dev, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, + GFP_KERNEL); + if (!name) { + ret = -ENOMEM; + goto out; + } + scnprintf(name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, "tasdev-profile-id"); + prof_ctrls[mix_index].name = name; + prof_ctrls[mix_index].iface = SNDRV_CTL_ELEM_IFACE_MIXER; + prof_ctrls[mix_index].info = tasdevice_info_profile; + prof_ctrls[mix_index].get = tasdevice_get_profile_id; + prof_ctrls[mix_index].put = tasdevice_set_profile_id; + mix_index++; + + ret = snd_soc_add_component_controls(tas_priv->codec, + prof_ctrls, nr_controls < mix_index ? nr_controls : mix_index); + +out: + return ret; +} + +static int tasdevice_program_get(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + + ucontrol->value.integer.value[0] = tas_priv->cur_prog; + + return 0; +} + +static int tasdevice_program_put(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + unsigned int nr_program = ucontrol->value.integer.value[0]; + + tas_priv->cur_prog = nr_program; + + return 1; +} + +static int tasdevice_configuration_get(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + + ucontrol->value.integer.value[0] = tas_priv->cur_conf; + + return 0; +} + +static int tasdevice_configuration_put( + struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + unsigned int nr_configuration = ucontrol->value.integer.value[0]; + + tas_priv->cur_conf = nr_configuration; + + return 1; +} + +static int tasdevice_dsp_create_ctrls( + struct tasdevice_priv *tas_priv) +{ + struct snd_kcontrol_new *dsp_ctrls; + char *prog_name, *conf_name; + int nr_controls = 2; + int mix_index = 0; + int ret; + + /* Alloc kcontrol via devm_kzalloc, which don't manually + * free the kcontrol + */ + dsp_ctrls = devm_kcalloc(tas_priv->dev, nr_controls, + sizeof(dsp_ctrls[0]), GFP_KERNEL); + if (!dsp_ctrls) { + ret = -ENOMEM; + goto out; + } + + /* Create a mixer item for selecting the active profile */ + prog_name = devm_kzalloc(tas_priv->dev, + SNDRV_CTL_ELEM_ID_NAME_MAXLEN, GFP_KERNEL); + conf_name = devm_kzalloc(tas_priv->dev, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, + GFP_KERNEL); + if (!prog_name || !conf_name) { + ret = -ENOMEM; + goto out; + } + + scnprintf(prog_name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, + "tasdev-prog-id"); + dsp_ctrls[mix_index].name = prog_name; + dsp_ctrls[mix_index].iface = SNDRV_CTL_ELEM_IFACE_MIXER; + dsp_ctrls[mix_index].info = tasdevice_info_programs; + dsp_ctrls[mix_index].get = tasdevice_program_get; + dsp_ctrls[mix_index].put = tasdevice_program_put; + mix_index++; + + scnprintf(conf_name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, + "tasdev-conf-id"); + dsp_ctrls[mix_index].name = conf_name; + dsp_ctrls[mix_index].iface = SNDRV_CTL_ELEM_IFACE_MIXER; + dsp_ctrls[mix_index].info = tasdevice_info_configurations; + dsp_ctrls[mix_index].get = tasdevice_configuration_get; + dsp_ctrls[mix_index].put = tasdevice_configuration_put; + mix_index++; + + ret = snd_soc_add_component_controls(tas_priv->codec, dsp_ctrls, + nr_controls < mix_index ? nr_controls : mix_index); + +out: + return ret; +} + +static void tasdevice_fw_ready(const struct firmware *fmw, + void *context) +{ + struct tasdevice_priv *tas_priv = (struct tasdevice_priv *)context; + int ret = 0; + int i; + + mutex_lock(&tas_priv->codec_lock); + + ret = tasdevice_rca_parser(tas_priv, fmw); + if (ret) + goto out; + tasdevice_create_control(tas_priv); + + tasdevice_dsp_remove(tas_priv); + tasdevice_calbin_remove(tas_priv); + tas_priv->fw_state = TASDEVICE_DSP_FW_PENDING; + scnprintf(tas_priv->coef_binaryname, 64, "%s_coef.bin", + tas_priv->dev_name); + ret = tasdevice_dsp_parser(tas_priv); + if (ret) { + dev_err(tas_priv->dev, "dspfw load %s error\n", + tas_priv->coef_binaryname); + tas_priv->fw_state = TASDEVICE_DSP_FW_FAIL; + goto out; + } + tasdevice_dsp_create_ctrls(tas_priv); + + tas_priv->fw_state = TASDEVICE_DSP_FW_ALL_OK; + + /* If calibrated data occurs error, dsp will still works with default + * calibrated data inside algo. + */ + for (i = 0; i < tas_priv->ndev; i++) { + scnprintf(tas_priv->cal_binaryname[i], 64, "%s_cal_0x%02x.bin", + tas_priv->dev_name, tas_priv->tasdevice[i].dev_addr); + ret = tas2781_load_calibration(tas_priv, + tas_priv->cal_binaryname[i], i); + if (ret != 0) + dev_err(tas_priv->dev, + "%s: load %s error, default will effect\n", + __func__, tas_priv->cal_binaryname[i]); + } + + tasdevice_prmg_calibdata_load(tas_priv, 0); + tas_priv->cur_prog = 0; +out: + if (tas_priv->fw_state == TASDEVICE_DSP_FW_FAIL) { + /*If DSP FW fail, kcontrol won't be created */ + tasdevice_config_info_remove(tas_priv); + tasdevice_dsp_remove(tas_priv); + } + mutex_unlock(&tas_priv->codec_lock); + if (fmw) + release_firmware(fmw); +} + +static int tasdevice_dapm_event(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *kcontrol, int event) +{ + struct snd_soc_component *codec = snd_soc_dapm_to_component(w->dapm); + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + int state = 0; + + /* Codec Lock Hold */ + mutex_lock(&tas_priv->codec_lock); + if (event == SND_SOC_DAPM_PRE_PMD) + state = 1; + tasdevice_tuning_switch(tas_priv, state); + /* Codec Lock Release*/ + mutex_unlock(&tas_priv->codec_lock); + + return 0; +} + +static const struct snd_soc_dapm_widget tasdevice_dapm_widgets[] = { + SND_SOC_DAPM_AIF_IN("ASI", "ASI Playback", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT_E("ASI OUT", "ASI Capture", 0, SND_SOC_NOPM, + 0, 0, tasdevice_dapm_event, + SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD), + SND_SOC_DAPM_SPK("SPK", tasdevice_dapm_event), + SND_SOC_DAPM_OUTPUT("OUT"), + SND_SOC_DAPM_INPUT("DMIC") +}; + +static const struct snd_soc_dapm_route tasdevice_audio_map[] = { + {"SPK", NULL, "ASI"}, + {"OUT", NULL, "SPK"}, + {"ASI OUT", NULL, "DMIC"} +}; + +static int tasdevice_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) +{ + struct snd_soc_component *codec = dai->component; + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + int ret = 0; + + if (tas_priv->fw_state != TASDEVICE_DSP_FW_ALL_OK) { + dev_err(tas_priv->dev, "DSP bin file not loaded\n"); + ret = -EINVAL; + } + + return ret; +} + +static int tasdevice_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params, struct snd_soc_dai *dai) +{ + struct tasdevice_priv *tas_priv = snd_soc_dai_get_drvdata(dai); + unsigned int slot_width; + unsigned int fsrate; + int bclk_rate; + int rc = 0; + + fsrate = params_rate(params); + switch (fsrate) { + case 48000: + case 44100: + break; + default: + dev_err(tas_priv->dev, "%s: incorrect sample rate = %u\n", + __func__, fsrate); + rc = -EINVAL; + goto out; + } + + slot_width = params_width(params); + switch (slot_width) { + case 16: + case 20: + case 24: + case 32: + break; + default: + dev_err(tas_priv->dev, "%s: incorrect slot width = %u\n", + __func__, slot_width); + rc = -EINVAL; + goto out; + } + + bclk_rate = snd_soc_params_to_bclk(params); + if (bclk_rate < 0) { + dev_err(tas_priv->dev, "%s: incorrect bclk rate = %d\n", + __func__, bclk_rate); + rc = bclk_rate; + goto out; + } + +out: + return rc; +} + +static int tasdevice_set_dai_sysclk(struct snd_soc_dai *codec_dai, + int clk_id, unsigned int freq, int dir) +{ + struct tasdevice_priv *tas_priv = snd_soc_dai_get_drvdata(codec_dai); + + tas_priv->sysclk = freq; + + return 0; +} + +static const struct snd_soc_dai_ops tasdevice_dai_ops = { + .startup = tasdevice_startup, + .hw_params = tasdevice_hw_params, + .set_sysclk = tasdevice_set_dai_sysclk, +}; + +static struct snd_soc_dai_driver tasdevice_dai_driver[] = { + { + .name = "tas2781_codec", + .id = 0, + .playback = { + .stream_name = "Playback", + .channels_min = 1, + .channels_max = 4, + .rates = TASDEVICE_RATES, + .formats = TASDEVICE_FORMATS, + }, + .capture = { + .stream_name = "Capture", + .channels_min = 1, + .channels_max = 4, + .rates = TASDEVICE_RATES, + .formats = TASDEVICE_FORMATS, + }, + .ops = &tasdevice_dai_ops, + .symmetric_rate = 1, + }, +}; + +static int tasdevice_codec_probe(struct snd_soc_component *codec) +{ + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + + return tascodec_init(tas_priv, codec, tasdevice_fw_ready); +} + +static void tasdevice_deinit(void *context) +{ + struct tasdevice_priv *tas_priv = (struct tasdevice_priv *) context; + + tasdevice_config_info_remove(tas_priv); + tasdevice_dsp_remove(tas_priv); + tasdevice_calbin_remove(tas_priv); + tas_priv->fw_state = TASDEVICE_DSP_FW_PENDING; +} + +static void tasdevice_codec_remove( + struct snd_soc_component *codec) +{ + struct tasdevice_priv *tas_priv = snd_soc_component_get_drvdata(codec); + + tasdevice_deinit(tas_priv); +} + +static const struct snd_soc_component_driver + soc_codec_driver_tasdevice = { + .probe = tasdevice_codec_probe, + .remove = tasdevice_codec_remove, + .controls = tas2781_snd_controls, + .num_controls = ARRAY_SIZE(tas2781_snd_controls), + .dapm_widgets = tasdevice_dapm_widgets, + .num_dapm_widgets = ARRAY_SIZE(tasdevice_dapm_widgets), + .dapm_routes = tasdevice_audio_map, + .num_dapm_routes = ARRAY_SIZE(tasdevice_audio_map), + .idle_bias_on = 1, + .endianness = 1, +}; + +static void tasdevice_parse_dt(struct tasdevice_priv *tas_priv) +{ + struct i2c_client *client = (struct i2c_client *)tas_priv->client; + unsigned int dev_addrs[max_chn]; + int rc, i, ndev = 0; + + if (tas_priv->isacpi) { + ndev = device_property_read_u32_array(&client->dev, + "ti,audio-slots", NULL, 0); + if (ndev <= 0) { + ndev = 1; + dev_addrs[0] = client->addr; + } else { + ndev = (ndev < ARRAY_SIZE(dev_addrs)) + ? ndev : ARRAY_SIZE(dev_addrs); + ndev = device_property_read_u32_array(&client->dev, + "ti,audio-slots", dev_addrs, ndev); + } + + tas_priv->irq_info.irq_gpio = + acpi_dev_gpio_irq_get(ACPI_COMPANION(&client->dev), 0); + } else { + struct device_node *np = tas_priv->dev->of_node; +#ifdef CONFIG_OF + const unsigned int *reg, *reg_end; + int len, sw, aw; + + aw = of_n_addr_cells(np); + sw = of_n_size_cells(np); + if (sw == 0) { + reg = (const unsigned int *)of_get_property(np, + "reg", &len); + reg_end = reg + len/sizeof(*reg); + ndev = 0; + do { + dev_addrs[ndev] = of_read_number(reg, aw); + reg += aw; + ndev++; + } while (reg < reg_end); + } else { + ndev = 1; + dev_addrs[0] = client->addr; + } +#else + ndev = 1; + dev_addrs[0] = client->addr; +#endif + tas_priv->irq_info.irq_gpio = of_irq_get(np, 0); + } + tas_priv->ndev = ndev; + for (i = 0; i < ndev; i++) + tas_priv->tasdevice[i].dev_addr = dev_addrs[i]; + + if (ndev > 1) { + rc = device_property_read_u32(&client->dev, + "ti,broadcast-addr", + &(tas_priv->glb_addr.dev_addr)); + if (rc) { + dev_err(tas_priv->dev, + "Looking up broadcast-addr failed %d\n", rc); + tas_priv->glb_addr.dev_addr = 0; + } + } + + tas_priv->reset = devm_gpiod_get_optional(&client->dev, + "reset-gpios", GPIOD_OUT_HIGH); + if (IS_ERR(tas_priv->reset)) + dev_err(tas_priv->dev, "%s Can't get reset GPIO\n", + __func__); + + strcpy(tas_priv->dev_name, tasdevice_id[tas_priv->chip_id].name); + + if (gpio_is_valid(tas_priv->irq_info.irq_gpio)) { + rc = gpio_request(tas_priv->irq_info.irq_gpio, + "AUDEV-IRQ"); + if (!rc) { + gpio_direction_input( + tas_priv->irq_info.irq_gpio); + + tas_priv->irq_info.irq = + gpio_to_irq(tas_priv->irq_info.irq_gpio); + } else + dev_err(tas_priv->dev, "%s: GPIO %d request error\n", + __func__, tas_priv->irq_info.irq_gpio); + } else + dev_err(tas_priv->dev, + "Looking up irq-gpio property failed %d\n", + tas_priv->irq_info.irq_gpio); +} + +static int tasdevice_i2c_probe(struct i2c_client *i2c) +{ + const struct i2c_device_id *id = i2c_match_id(tasdevice_id, i2c); + const struct acpi_device_id *acpi_id; + struct tasdevice_priv *tas_priv; + int ret; + + tas_priv = tasdevice_kzalloc(i2c); + if (!tas_priv) + return -ENOMEM; + + if (ACPI_HANDLE(&i2c->dev)) { + acpi_id = acpi_match_device(i2c->dev.driver->acpi_match_table, + &i2c->dev); + if (!acpi_id) { + dev_err(&i2c->dev, "No driver data\n"); + ret = -EINVAL; + goto err; + } + tas_priv->chip_id = acpi_id->driver_data; + tas_priv->isacpi = true; + } else { + tas_priv->chip_id = id ? id->driver_data : 0; + tas_priv->isacpi = false; + } + + tasdevice_parse_dt(tas_priv); + + ret = tasdevice_init(tas_priv); + if (ret) + goto err; + + ret = devm_snd_soc_register_component(tas_priv->dev, + &soc_codec_driver_tasdevice, + tasdevice_dai_driver, ARRAY_SIZE(tasdevice_dai_driver)); + if (ret) { + dev_err(tas_priv->dev, "%s: codec register error:0x%08x\n", + __func__, ret); + goto err; + } +err: + if (ret < 0) + tasdevice_remove(tas_priv); + return ret; +} + +static void tasdevice_i2c_remove(struct i2c_client *client) +{ + struct tasdevice_priv *tas_priv = i2c_get_clientdata(client); + + tasdevice_remove(tas_priv); +} + +#ifdef CONFIG_ACPI +static const struct acpi_device_id tasdevice_acpi_match[] = { + { "TAS2781", TAS2781 }, + {}, +}; + +MODULE_DEVICE_TABLE(acpi, tasdevice_acpi_match); +#endif + +static struct i2c_driver tasdevice_i2c_driver = { + .driver = { + .name = "tas2781-codec", + .owner = THIS_MODULE, + .of_match_table = of_match_ptr(tasdevice_of_match), +#ifdef CONFIG_ACPI + .acpi_match_table = ACPI_PTR(tasdevice_acpi_match), +#endif + }, + .probe = tasdevice_i2c_probe, + .remove = tasdevice_i2c_remove, + .id_table = tasdevice_id, +}; + +module_i2c_driver(tasdevice_i2c_driver); + +MODULE_AUTHOR("Shenghao Ding shenghao-ding@ti.com"); +MODULE_AUTHOR("Kevin Lu kevin-lu@ti.com"); +MODULE_DESCRIPTION("ASoC TAS2781 Driver"); +MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS(SND_SOC_TAS2781_FMWLIB);
Hi Shenghao,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-sound/for-next] [also build test WARNING on tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.4-rc2 next-20230519] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shenghao-Ding/ASoC-tas2781-fi... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20230519080211.20205-1-13916275206%40139.com patch subject: [PATCH v3 3/5] ASoC: tas2781: Add tas2781 driver config: arm64-randconfig-s033-20230518 compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/1138e1878d682a13d5ba424d90bb89... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shenghao-Ding/ASoC-tas2781-firmware-lib/20230519-160451 git checkout 1138e1878d682a13d5ba424d90bb89dd7a05b637 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash sound/soc/codecs/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com | Closes: https://lore.kernel.org/oe-kbuild-all/202305192322.gBZ4JIyr-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
sound/soc/codecs/tas2781-i2c.c:585:66: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *cell @@ got unsigned int const *[assigned] reg @@
sound/soc/codecs/tas2781-i2c.c:585:66: sparse: expected restricted __be32 const [usertype] *cell sound/soc/codecs/tas2781-i2c.c:585:66: sparse: got unsigned int const *[assigned] reg
vim +585 sound/soc/codecs/tas2781-i2c.c
549 550 static void tasdevice_parse_dt(struct tasdevice_priv *tas_priv) 551 { 552 struct i2c_client *client = (struct i2c_client *)tas_priv->client; 553 unsigned int dev_addrs[max_chn]; 554 int rc, i, ndev = 0; 555 556 if (tas_priv->isacpi) { 557 ndev = device_property_read_u32_array(&client->dev, 558 "ti,audio-slots", NULL, 0); 559 if (ndev <= 0) { 560 ndev = 1; 561 dev_addrs[0] = client->addr; 562 } else { 563 ndev = (ndev < ARRAY_SIZE(dev_addrs)) 564 ? ndev : ARRAY_SIZE(dev_addrs); 565 ndev = device_property_read_u32_array(&client->dev, 566 "ti,audio-slots", dev_addrs, ndev); 567 } 568 569 tas_priv->irq_info.irq_gpio = 570 acpi_dev_gpio_irq_get(ACPI_COMPANION(&client->dev), 0); 571 } else { 572 struct device_node *np = tas_priv->dev->of_node; 573 #ifdef CONFIG_OF 574 const unsigned int *reg, *reg_end; 575 int len, sw, aw; 576 577 aw = of_n_addr_cells(np); 578 sw = of_n_size_cells(np); 579 if (sw == 0) { 580 reg = (const unsigned int *)of_get_property(np, 581 "reg", &len); 582 reg_end = reg + len/sizeof(*reg); 583 ndev = 0; 584 do {
585 dev_addrs[ndev] = of_read_number(reg, aw);
586 reg += aw; 587 ndev++; 588 } while (reg < reg_end); 589 } else { 590 ndev = 1; 591 dev_addrs[0] = client->addr; 592 } 593 #else 594 ndev = 1; 595 dev_addrs[0] = client->addr; 596 #endif 597 tas_priv->irq_info.irq_gpio = of_irq_get(np, 0); 598 } 599 tas_priv->ndev = ndev; 600 for (i = 0; i < ndev; i++) 601 tas_priv->tasdevice[i].dev_addr = dev_addrs[i]; 602 603 if (ndev > 1) { 604 rc = device_property_read_u32(&client->dev, 605 "ti,broadcast-addr", 606 &(tas_priv->glb_addr.dev_addr)); 607 if (rc) { 608 dev_err(tas_priv->dev, 609 "Looking up broadcast-addr failed %d\n", rc); 610 tas_priv->glb_addr.dev_addr = 0; 611 } 612 } 613 614 tas_priv->reset = devm_gpiod_get_optional(&client->dev, 615 "reset-gpios", GPIOD_OUT_HIGH); 616 if (IS_ERR(tas_priv->reset)) 617 dev_err(tas_priv->dev, "%s Can't get reset GPIO\n", 618 __func__); 619 620 strcpy(tas_priv->dev_name, tasdevice_id[tas_priv->chip_id].name); 621 622 if (gpio_is_valid(tas_priv->irq_info.irq_gpio)) { 623 rc = gpio_request(tas_priv->irq_info.irq_gpio, 624 "AUDEV-IRQ"); 625 if (!rc) { 626 gpio_direction_input( 627 tas_priv->irq_info.irq_gpio); 628 629 tas_priv->irq_info.irq = 630 gpio_to_irq(tas_priv->irq_info.irq_gpio); 631 } else 632 dev_err(tas_priv->dev, "%s: GPIO %d request error\n", 633 __func__, tas_priv->irq_info.irq_gpio); 634 } else 635 dev_err(tas_priv->dev, 636 "Looking up irq-gpio property failed %d\n", 637 tas_priv->irq_info.irq_gpio); 638 } 639
Hi Shenghao,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-sound/for-next] [also build test ERROR on tiwai-sound/for-next tiwai-sound/for-linus robh/for-next linus/master v6.4-rc3 next-20230519] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shenghao-Ding/ASoC-tas2781-fi... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20230519080211.20205-1-13916275206%40139.com patch subject: [PATCH v3 3/5] ASoC: tas2781: Add tas2781 driver config: nios2-randconfig-r035-20230522 compiler: nios2-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1138e1878d682a13d5ba424d90bb89... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shenghao-Ding/ASoC-tas2781-firmware-lib/20230519-160451 git checkout 1138e1878d682a13d5ba424d90bb89dd7a05b637 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/base/regmap/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com | Closes: https://lore.kernel.org/oe-kbuild-all/202305221045.K3Bx6bts-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/base/regmap/regmap-i2c.c: In function 'regmap_smbus_byte_reg_read':
drivers/base/regmap/regmap-i2c.c:25:15: error: implicit declaration of function 'i2c_smbus_read_byte_data' [-Werror=implicit-function-declaration]
25 | ret = i2c_smbus_read_byte_data(i2c, reg); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_smbus_byte_reg_write':
drivers/base/regmap/regmap-i2c.c:43:16: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Werror=implicit-function-declaration]
43 | return i2c_smbus_write_byte_data(i2c, reg, val); | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_smbus_word_reg_read':
drivers/base/regmap/regmap-i2c.c:61:15: error: implicit declaration of function 'i2c_smbus_read_word_data' [-Werror=implicit-function-declaration]
61 | ret = i2c_smbus_read_word_data(i2c, reg); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_smbus_word_reg_write':
drivers/base/regmap/regmap-i2c.c:79:16: error: implicit declaration of function 'i2c_smbus_write_word_data' [-Werror=implicit-function-declaration]
79 | return i2c_smbus_write_word_data(i2c, reg, val); | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_smbus_word_read_swapped':
drivers/base/regmap/regmap-i2c.c:97:15: error: implicit declaration of function 'i2c_smbus_read_word_swapped' [-Werror=implicit-function-declaration]
97 | ret = i2c_smbus_read_word_swapped(i2c, reg); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_smbus_word_write_swapped':
drivers/base/regmap/regmap-i2c.c:115:16: error: implicit declaration of function 'i2c_smbus_write_word_swapped' [-Werror=implicit-function-declaration]
115 | return i2c_smbus_write_word_swapped(i2c, reg, val); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_i2c_write':
drivers/base/regmap/regmap-i2c.c:129:15: error: implicit declaration of function 'i2c_master_send' [-Werror=implicit-function-declaration]
129 | ret = i2c_master_send(i2c, data, count); | ^~~~~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_i2c_gather_write':
drivers/base/regmap/regmap-i2c.c:150:14: error: implicit declaration of function 'i2c_check_functionality' [-Werror=implicit-function-declaration]
150 | if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_NOSTART)) | ^~~~~~~~~~~~~~~~~~~~~~~
drivers/base/regmap/regmap-i2c.c:163:15: error: implicit declaration of function 'i2c_transfer' [-Werror=implicit-function-declaration]
163 | ret = i2c_transfer(i2c->adapter, xfer, 2); | ^~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_i2c_smbus_i2c_write':
drivers/base/regmap/regmap-i2c.c:218:16: error: implicit declaration of function 'i2c_smbus_write_i2c_block_data' [-Werror=implicit-function-declaration]
218 | return i2c_smbus_write_i2c_block_data(i2c, ((u8 *)data)[0], count, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_i2c_smbus_i2c_read':
drivers/base/regmap/regmap-i2c.c:233:15: error: implicit declaration of function 'i2c_smbus_read_i2c_block_data' [-Werror=implicit-function-declaration]
233 | ret = i2c_smbus_read_i2c_block_data(i2c, ((u8 *)reg)[0], val_size, val); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/base/regmap/regmap-i2c.c: In function 'regmap_i2c_smbus_i2c_read_reg16':
drivers/base/regmap/regmap-i2c.c:282:23: error: implicit declaration of function 'i2c_smbus_read_byte' [-Werror=implicit-function-declaration]
282 | ret = i2c_smbus_read_byte(i2c); | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors
Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for REGMAP_I2C Depends on [n]: I2C [=n] Selected by [y]: - SND_SOC_TAS2781_COMLIB [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y]
vim +/i2c_smbus_read_byte_data +25 drivers/base/regmap/regmap-i2c.c
b42261078a91db Boris Brezillon 2014-04-21 14 b42261078a91db Boris Brezillon 2014-04-21 15 static int regmap_smbus_byte_reg_read(void *context, unsigned int reg, b42261078a91db Boris Brezillon 2014-04-21 16 unsigned int *val) b42261078a91db Boris Brezillon 2014-04-21 17 { b42261078a91db Boris Brezillon 2014-04-21 18 struct device *dev = context; b42261078a91db Boris Brezillon 2014-04-21 19 struct i2c_client *i2c = to_i2c_client(dev); b42261078a91db Boris Brezillon 2014-04-21 20 int ret; b42261078a91db Boris Brezillon 2014-04-21 21 b42261078a91db Boris Brezillon 2014-04-21 22 if (reg > 0xff) b42261078a91db Boris Brezillon 2014-04-21 23 return -EINVAL; b42261078a91db Boris Brezillon 2014-04-21 24 b42261078a91db Boris Brezillon 2014-04-21 @25 ret = i2c_smbus_read_byte_data(i2c, reg); b42261078a91db Boris Brezillon 2014-04-21 26 if (ret < 0) b42261078a91db Boris Brezillon 2014-04-21 27 return ret; b42261078a91db Boris Brezillon 2014-04-21 28 b42261078a91db Boris Brezillon 2014-04-21 29 *val = ret; b42261078a91db Boris Brezillon 2014-04-21 30 b42261078a91db Boris Brezillon 2014-04-21 31 return 0; b42261078a91db Boris Brezillon 2014-04-21 32 } b42261078a91db Boris Brezillon 2014-04-21 33 b42261078a91db Boris Brezillon 2014-04-21 34 static int regmap_smbus_byte_reg_write(void *context, unsigned int reg, b42261078a91db Boris Brezillon 2014-04-21 35 unsigned int val) b42261078a91db Boris Brezillon 2014-04-21 36 { b42261078a91db Boris Brezillon 2014-04-21 37 struct device *dev = context; b42261078a91db Boris Brezillon 2014-04-21 38 struct i2c_client *i2c = to_i2c_client(dev); b42261078a91db Boris Brezillon 2014-04-21 39 b42261078a91db Boris Brezillon 2014-04-21 40 if (val > 0xff || reg > 0xff) b42261078a91db Boris Brezillon 2014-04-21 41 return -EINVAL; b42261078a91db Boris Brezillon 2014-04-21 42 b42261078a91db Boris Brezillon 2014-04-21 @43 return i2c_smbus_write_byte_data(i2c, reg, val); b42261078a91db Boris Brezillon 2014-04-21 44 } b42261078a91db Boris Brezillon 2014-04-21 45 14e01b5f335881 Michał Mirosław 2020-01-04 46 static const struct regmap_bus regmap_smbus_byte = { b42261078a91db Boris Brezillon 2014-04-21 47 .reg_write = regmap_smbus_byte_reg_write, b42261078a91db Boris Brezillon 2014-04-21 48 .reg_read = regmap_smbus_byte_reg_read, b42261078a91db Boris Brezillon 2014-04-21 49 }; b42261078a91db Boris Brezillon 2014-04-21 50 b42261078a91db Boris Brezillon 2014-04-21 51 static int regmap_smbus_word_reg_read(void *context, unsigned int reg, b42261078a91db Boris Brezillon 2014-04-21 52 unsigned int *val) b42261078a91db Boris Brezillon 2014-04-21 53 { b42261078a91db Boris Brezillon 2014-04-21 54 struct device *dev = context; b42261078a91db Boris Brezillon 2014-04-21 55 struct i2c_client *i2c = to_i2c_client(dev); b42261078a91db Boris Brezillon 2014-04-21 56 int ret; b42261078a91db Boris Brezillon 2014-04-21 57 b42261078a91db Boris Brezillon 2014-04-21 58 if (reg > 0xff) b42261078a91db Boris Brezillon 2014-04-21 59 return -EINVAL; b42261078a91db Boris Brezillon 2014-04-21 60 b42261078a91db Boris Brezillon 2014-04-21 @61 ret = i2c_smbus_read_word_data(i2c, reg); b42261078a91db Boris Brezillon 2014-04-21 62 if (ret < 0) b42261078a91db Boris Brezillon 2014-04-21 63 return ret; b42261078a91db Boris Brezillon 2014-04-21 64 b42261078a91db Boris Brezillon 2014-04-21 65 *val = ret; b42261078a91db Boris Brezillon 2014-04-21 66 b42261078a91db Boris Brezillon 2014-04-21 67 return 0; b42261078a91db Boris Brezillon 2014-04-21 68 } b42261078a91db Boris Brezillon 2014-04-21 69 b42261078a91db Boris Brezillon 2014-04-21 70 static int regmap_smbus_word_reg_write(void *context, unsigned int reg, b42261078a91db Boris Brezillon 2014-04-21 71 unsigned int val) b42261078a91db Boris Brezillon 2014-04-21 72 { b42261078a91db Boris Brezillon 2014-04-21 73 struct device *dev = context; b42261078a91db Boris Brezillon 2014-04-21 74 struct i2c_client *i2c = to_i2c_client(dev); b42261078a91db Boris Brezillon 2014-04-21 75 b42261078a91db Boris Brezillon 2014-04-21 76 if (val > 0xffff || reg > 0xff) b42261078a91db Boris Brezillon 2014-04-21 77 return -EINVAL; b42261078a91db Boris Brezillon 2014-04-21 78 b42261078a91db Boris Brezillon 2014-04-21 @79 return i2c_smbus_write_word_data(i2c, reg, val); b42261078a91db Boris Brezillon 2014-04-21 80 } b42261078a91db Boris Brezillon 2014-04-21 81 14e01b5f335881 Michał Mirosław 2020-01-04 82 static const struct regmap_bus regmap_smbus_word = { b42261078a91db Boris Brezillon 2014-04-21 83 .reg_write = regmap_smbus_word_reg_write, b42261078a91db Boris Brezillon 2014-04-21 84 .reg_read = regmap_smbus_word_reg_read, b42261078a91db Boris Brezillon 2014-04-21 85 }; b42261078a91db Boris Brezillon 2014-04-21 86 5892ded23c8e9e Guenter Roeck 2015-02-03 87 static int regmap_smbus_word_read_swapped(void *context, unsigned int reg, 5892ded23c8e9e Guenter Roeck 2015-02-03 88 unsigned int *val) 5892ded23c8e9e Guenter Roeck 2015-02-03 89 { 5892ded23c8e9e Guenter Roeck 2015-02-03 90 struct device *dev = context; 5892ded23c8e9e Guenter Roeck 2015-02-03 91 struct i2c_client *i2c = to_i2c_client(dev); 5892ded23c8e9e Guenter Roeck 2015-02-03 92 int ret; 5892ded23c8e9e Guenter Roeck 2015-02-03 93 5892ded23c8e9e Guenter Roeck 2015-02-03 94 if (reg > 0xff) 5892ded23c8e9e Guenter Roeck 2015-02-03 95 return -EINVAL; 5892ded23c8e9e Guenter Roeck 2015-02-03 96 5892ded23c8e9e Guenter Roeck 2015-02-03 @97 ret = i2c_smbus_read_word_swapped(i2c, reg); 5892ded23c8e9e Guenter Roeck 2015-02-03 98 if (ret < 0) 5892ded23c8e9e Guenter Roeck 2015-02-03 99 return ret; 5892ded23c8e9e Guenter Roeck 2015-02-03 100 5892ded23c8e9e Guenter Roeck 2015-02-03 101 *val = ret; 5892ded23c8e9e Guenter Roeck 2015-02-03 102 5892ded23c8e9e Guenter Roeck 2015-02-03 103 return 0; 5892ded23c8e9e Guenter Roeck 2015-02-03 104 } 5892ded23c8e9e Guenter Roeck 2015-02-03 105 5892ded23c8e9e Guenter Roeck 2015-02-03 106 static int regmap_smbus_word_write_swapped(void *context, unsigned int reg, 5892ded23c8e9e Guenter Roeck 2015-02-03 107 unsigned int val) 5892ded23c8e9e Guenter Roeck 2015-02-03 108 { 5892ded23c8e9e Guenter Roeck 2015-02-03 109 struct device *dev = context; 5892ded23c8e9e Guenter Roeck 2015-02-03 110 struct i2c_client *i2c = to_i2c_client(dev); 5892ded23c8e9e Guenter Roeck 2015-02-03 111 5892ded23c8e9e Guenter Roeck 2015-02-03 112 if (val > 0xffff || reg > 0xff) 5892ded23c8e9e Guenter Roeck 2015-02-03 113 return -EINVAL; 5892ded23c8e9e Guenter Roeck 2015-02-03 114 5892ded23c8e9e Guenter Roeck 2015-02-03 @115 return i2c_smbus_write_word_swapped(i2c, reg, val); 5892ded23c8e9e Guenter Roeck 2015-02-03 116 } 5892ded23c8e9e Guenter Roeck 2015-02-03 117 14e01b5f335881 Michał Mirosław 2020-01-04 118 static const struct regmap_bus regmap_smbus_word_swapped = { 5892ded23c8e9e Guenter Roeck 2015-02-03 119 .reg_write = regmap_smbus_word_write_swapped, 5892ded23c8e9e Guenter Roeck 2015-02-03 120 .reg_read = regmap_smbus_word_read_swapped, 5892ded23c8e9e Guenter Roeck 2015-02-03 121 }; 5892ded23c8e9e Guenter Roeck 2015-02-03 122 0135bbcc7a0cc0 Stephen Warren 2012-04-04 123 static int regmap_i2c_write(void *context, const void *data, size_t count) 9943fa300a5dcd Mark Brown 2011-06-20 124 { 0135bbcc7a0cc0 Stephen Warren 2012-04-04 125 struct device *dev = context; 9943fa300a5dcd Mark Brown 2011-06-20 126 struct i2c_client *i2c = to_i2c_client(dev); 9943fa300a5dcd Mark Brown 2011-06-20 127 int ret; 9943fa300a5dcd Mark Brown 2011-06-20 128 9943fa300a5dcd Mark Brown 2011-06-20 @129 ret = i2c_master_send(i2c, data, count); 9943fa300a5dcd Mark Brown 2011-06-20 130 if (ret == count) 9943fa300a5dcd Mark Brown 2011-06-20 131 return 0; 9943fa300a5dcd Mark Brown 2011-06-20 132 else if (ret < 0) 9943fa300a5dcd Mark Brown 2011-06-20 133 return ret; 9943fa300a5dcd Mark Brown 2011-06-20 134 else 9943fa300a5dcd Mark Brown 2011-06-20 135 return -EIO; 9943fa300a5dcd Mark Brown 2011-06-20 136 } 9943fa300a5dcd Mark Brown 2011-06-20 137 0135bbcc7a0cc0 Stephen Warren 2012-04-04 138 static int regmap_i2c_gather_write(void *context, 9943fa300a5dcd Mark Brown 2011-06-20 139 const void *reg, size_t reg_size, 9943fa300a5dcd Mark Brown 2011-06-20 140 const void *val, size_t val_size) 9943fa300a5dcd Mark Brown 2011-06-20 141 { 0135bbcc7a0cc0 Stephen Warren 2012-04-04 142 struct device *dev = context; 9943fa300a5dcd Mark Brown 2011-06-20 143 struct i2c_client *i2c = to_i2c_client(dev); 9943fa300a5dcd Mark Brown 2011-06-20 144 struct i2c_msg xfer[2]; 9943fa300a5dcd Mark Brown 2011-06-20 145 int ret; 9943fa300a5dcd Mark Brown 2011-06-20 146 9943fa300a5dcd Mark Brown 2011-06-20 147 /* If the I2C controller can't do a gather tell the core, it 9943fa300a5dcd Mark Brown 2011-06-20 148 * will substitute in a linear write for us. 9943fa300a5dcd Mark Brown 2011-06-20 149 */ 14674e70119ea0 Mark Brown 2012-05-30 @150 if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_NOSTART)) 9943fa300a5dcd Mark Brown 2011-06-20 151 return -ENOTSUPP; 9943fa300a5dcd Mark Brown 2011-06-20 152 9943fa300a5dcd Mark Brown 2011-06-20 153 xfer[0].addr = i2c->addr; 9943fa300a5dcd Mark Brown 2011-06-20 154 xfer[0].flags = 0; 9943fa300a5dcd Mark Brown 2011-06-20 155 xfer[0].len = reg_size; 9943fa300a5dcd Mark Brown 2011-06-20 156 xfer[0].buf = (void *)reg; 9943fa300a5dcd Mark Brown 2011-06-20 157 9943fa300a5dcd Mark Brown 2011-06-20 158 xfer[1].addr = i2c->addr; 9943fa300a5dcd Mark Brown 2011-06-20 159 xfer[1].flags = I2C_M_NOSTART; 9943fa300a5dcd Mark Brown 2011-06-20 160 xfer[1].len = val_size; 9943fa300a5dcd Mark Brown 2011-06-20 161 xfer[1].buf = (void *)val; 9943fa300a5dcd Mark Brown 2011-06-20 162 9943fa300a5dcd Mark Brown 2011-06-20 @163 ret = i2c_transfer(i2c->adapter, xfer, 2); 9943fa300a5dcd Mark Brown 2011-06-20 164 if (ret == 2) 9943fa300a5dcd Mark Brown 2011-06-20 165 return 0; 9943fa300a5dcd Mark Brown 2011-06-20 166 if (ret < 0) 9943fa300a5dcd Mark Brown 2011-06-20 167 return ret; 9943fa300a5dcd Mark Brown 2011-06-20 168 else 9943fa300a5dcd Mark Brown 2011-06-20 169 return -EIO; 9943fa300a5dcd Mark Brown 2011-06-20 170 } 9943fa300a5dcd Mark Brown 2011-06-20 171 0135bbcc7a0cc0 Stephen Warren 2012-04-04 172 static int regmap_i2c_read(void *context, 9943fa300a5dcd Mark Brown 2011-06-20 173 const void *reg, size_t reg_size, 9943fa300a5dcd Mark Brown 2011-06-20 174 void *val, size_t val_size) 9943fa300a5dcd Mark Brown 2011-06-20 175 { 0135bbcc7a0cc0 Stephen Warren 2012-04-04 176 struct device *dev = context; 9943fa300a5dcd Mark Brown 2011-06-20 177 struct i2c_client *i2c = to_i2c_client(dev); 9943fa300a5dcd Mark Brown 2011-06-20 178 struct i2c_msg xfer[2]; 9943fa300a5dcd Mark Brown 2011-06-20 179 int ret; 9943fa300a5dcd Mark Brown 2011-06-20 180 9943fa300a5dcd Mark Brown 2011-06-20 181 xfer[0].addr = i2c->addr; 9943fa300a5dcd Mark Brown 2011-06-20 182 xfer[0].flags = 0; 9943fa300a5dcd Mark Brown 2011-06-20 183 xfer[0].len = reg_size; 9943fa300a5dcd Mark Brown 2011-06-20 184 xfer[0].buf = (void *)reg; 9943fa300a5dcd Mark Brown 2011-06-20 185 9943fa300a5dcd Mark Brown 2011-06-20 186 xfer[1].addr = i2c->addr; 9943fa300a5dcd Mark Brown 2011-06-20 187 xfer[1].flags = I2C_M_RD; 9943fa300a5dcd Mark Brown 2011-06-20 188 xfer[1].len = val_size; 9943fa300a5dcd Mark Brown 2011-06-20 189 xfer[1].buf = val; 9943fa300a5dcd Mark Brown 2011-06-20 190 9943fa300a5dcd Mark Brown 2011-06-20 191 ret = i2c_transfer(i2c->adapter, xfer, 2); 9943fa300a5dcd Mark Brown 2011-06-20 192 if (ret == 2) 9943fa300a5dcd Mark Brown 2011-06-20 193 return 0; 9943fa300a5dcd Mark Brown 2011-06-20 194 else if (ret < 0) 9943fa300a5dcd Mark Brown 2011-06-20 195 return ret; 9943fa300a5dcd Mark Brown 2011-06-20 196 else 9943fa300a5dcd Mark Brown 2011-06-20 197 return -EIO; 9943fa300a5dcd Mark Brown 2011-06-20 198 } 9943fa300a5dcd Mark Brown 2011-06-20 199 14e01b5f335881 Michał Mirosław 2020-01-04 200 static const struct regmap_bus regmap_i2c = { 9943fa300a5dcd Mark Brown 2011-06-20 201 .write = regmap_i2c_write, 9943fa300a5dcd Mark Brown 2011-06-20 202 .gather_write = regmap_i2c_gather_write, 9943fa300a5dcd Mark Brown 2011-06-20 203 .read = regmap_i2c_read, d647c199510c2c Xiubo Li 2014-07-15 204 .reg_format_endian_default = REGMAP_ENDIAN_BIG, d647c199510c2c Xiubo Li 2014-07-15 205 .val_format_endian_default = REGMAP_ENDIAN_BIG, 9943fa300a5dcd Mark Brown 2011-06-20 206 }; 9943fa300a5dcd Mark Brown 2011-06-20 207 29332534e2b68b Markus Pargmann 2015-08-30 208 static int regmap_i2c_smbus_i2c_write(void *context, const void *data, 29332534e2b68b Markus Pargmann 2015-08-30 209 size_t count) 29332534e2b68b Markus Pargmann 2015-08-30 210 { 29332534e2b68b Markus Pargmann 2015-08-30 211 struct device *dev = context; 29332534e2b68b Markus Pargmann 2015-08-30 212 struct i2c_client *i2c = to_i2c_client(dev); 29332534e2b68b Markus Pargmann 2015-08-30 213 29332534e2b68b Markus Pargmann 2015-08-30 214 if (count < 1) 29332534e2b68b Markus Pargmann 2015-08-30 215 return -EINVAL; 29332534e2b68b Markus Pargmann 2015-08-30 216 29332534e2b68b Markus Pargmann 2015-08-30 217 --count; 29332534e2b68b Markus Pargmann 2015-08-30 @218 return i2c_smbus_write_i2c_block_data(i2c, ((u8 *)data)[0], count, 29332534e2b68b Markus Pargmann 2015-08-30 219 ((u8 *)data + 1)); 29332534e2b68b Markus Pargmann 2015-08-30 220 } 29332534e2b68b Markus Pargmann 2015-08-30 221
participants (2)
-
kernel test robot
-
Shenghao Ding