[PATCH] ALSA: hda: cs35l41: fix double free on error in probe()
If we encounter an error after the kfree(acpi_hw_cfg); then the goto err; will result in a double free.
Fixes: 7b2f3eb492da ("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com --- sound/pci/hda/cs35l41_hda.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index aa5bb6977792..30b40d865863 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -477,6 +477,7 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i if (ret) goto err; kfree(acpi_hw_cfg); + acpi_hw_cfg = NULL;
if (cs35l41->reg_seq->probe) { ret = regmap_register_patch(cs35l41->regmap, cs35l41->reg_seq->probe,
On Tue, 11 Jan 2022 08:22:32 +0100, Dan Carpenter wrote:
If we encounter an error after the kfree(acpi_hw_cfg); then the goto err; will result in a double free.
Fixes: 7b2f3eb492da ("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
Thanks, applied now.
Takashi
participants (2)
-
Dan Carpenter
-
Takashi Iwai