[alsa-devel] [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/max9867 head: 79e139744508105bd749300f364563934bff23f2 commit: 8b9c716aada77e72e2fe82320aba5a95b75ca400 [2/4] ASoC: max9867: Improve error logging config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 8b9c716aada77e72e2fe82320aba5a95b75ca400 # save the attached .config to linux build tree make ARCH=i386
All errors (new ones prefixed by >>):
sound/soc/codecs/max9867.c: In function 'max9867_set_dai_sysclk':
sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared (first use in this function); did you mean 'complete'?
dev_err(component->dev, ^~~~~~~~~ complete sound/soc/codecs/max9867.c:294:11: note: each undeclared identifier is reported only once for each function it appears in
vim +294 sound/soc/codecs/max9867.c
275 276 static int max9867_set_dai_sysclk(struct snd_soc_dai *codec_dai, 277 int clk_id, unsigned int freq, int dir) 278 { 279 struct snd_soc_codec *codec = codec_dai->codec; 280 struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec); 281 int value = 0; 282 283 /* Set the prescaler based on the master clock frequency*/ 284 if (freq >= 10000000 && freq <= 20000000) { 285 value |= MAX9867_PSCLK_10_20; 286 max9867->pclk = freq; 287 } else if (freq >= 20000000 && freq <= 40000000) { 288 value |= MAX9867_PSCLK_20_40; 289 max9867->pclk = freq/2; 290 } else if (freq >= 40000000 && freq <= 60000000) { 291 value |= MAX9867_PSCLK_40_60; 292 max9867->pclk = freq/4; 293 } else {
294 dev_err(component->dev,
295 "Invalid clock frequency %uHz (required 10-60MHz)\n", 296 freq); 297 return -EINVAL; 298 } 299 value = value << MAX9867_PSCLK_SHIFT; 300 max9867->sysclk = freq; 301 /* exact integer mode is not supported */ 302 value &= ~MAX9867_FREQ_MASK; 303 regmap_update_bits(max9867->regmap, MAX9867_SYSCLK, 304 MAX9867_PSCLK_MASK, value); 305 return 0; 306 } 307
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Mark,
On Fri, Mar 02, 2018 at 03:45:16AM +0800, kbuild test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/max9867 head: 79e139744508105bd749300f364563934bff23f2 commit: 8b9c716aada77e72e2fe82320aba5a95b75ca400 [2/4] ASoC: max9867: Improve error logging config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 8b9c716aada77e72e2fe82320aba5a95b75ca400 # save the attached .config to linux build tree make ARCH=i386
All errors (new ones prefixed by >>):
sound/soc/codecs/max9867.c: In function 'max9867_set_dai_sysclk':
sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared (first use in this function); did you mean 'complete'?
dev_err(component->dev, ^~~~~~~~~ completesound/soc/codecs/max9867.c:294:11: note: each undeclared identifier is reported only once for each function it appears in
your topic/max9867 seems to be 4.16-rc1 based, while patch was tested in today's -next. Fixing it for 4.16-rc1 would mean it fails to compile once you merge topic branches.
What am I supposed to do here?
Thank you, ladis
vim +294 sound/soc/codecs/max9867.c
275 276 static int max9867_set_dai_sysclk(struct snd_soc_dai *codec_dai, 277 int clk_id, unsigned int freq, int dir) 278 { 279 struct snd_soc_codec *codec = codec_dai->codec; 280 struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec); 281 int value = 0; 282 283 /* Set the prescaler based on the master clock frequency*/ 284 if (freq >= 10000000 && freq <= 20000000) { 285 value |= MAX9867_PSCLK_10_20; 286 max9867->pclk = freq; 287 } else if (freq >= 20000000 && freq <= 40000000) { 288 value |= MAX9867_PSCLK_20_40; 289 max9867->pclk = freq/2; 290 } else if (freq >= 40000000 && freq <= 60000000) { 291 value |= MAX9867_PSCLK_40_60; 292 max9867->pclk = freq/4; 293 } else {
294 dev_err(component->dev,
295 "Invalid clock frequency %uHz (required 10-60MHz)\n", 296 freq); 297 return -EINVAL; 298 } 299 value = value << MAX9867_PSCLK_SHIFT; 300 max9867->sysclk = freq; 301 /* exact integer mode is not supported */ 302 value &= ~MAX9867_FREQ_MASK; 303 regmap_update_bits(max9867->regmap, MAX9867_SYSCLK, 304 MAX9867_PSCLK_MASK, value); 305 return 0; 306 } 307
0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Thu, Mar 01, 2018 at 09:01:56PM +0100, Ladislav Michl wrote:
On Fri, Mar 02, 2018 at 03:45:16AM +0800, kbuild test robot wrote:
sound/soc/codecs/max9867.c:294:11: note: each undeclared identifier is reported only once for each function it appears in
your topic/max9867 seems to be 4.16-rc1 based, while patch was tested in today's -next. Fixing it for 4.16-rc1 would mean it fails to compile once you merge topic branches.
What am I supposed to do here?
Which other commits in my tree does this depend on?
On Thu, Mar 01, 2018 at 08:04:30PM +0000, Mark Brown wrote:
On Thu, Mar 01, 2018 at 09:01:56PM +0100, Ladislav Michl wrote:
On Fri, Mar 02, 2018 at 03:45:16AM +0800, kbuild test robot wrote:
sound/soc/codecs/max9867.c:294:11: note: each undeclared identifier is reported only once for each function it appears in
your topic/max9867 seems to be 4.16-rc1 based, while patch was tested in today's -next. Fixing it for 4.16-rc1 would mean it fails to compile once you merge topic branches.
What am I supposed to do here?
Which other commits in my tree does this depend on?
91880a6b6ba3 ("ASoC: wm9867: replace codec to component") Note, we have naming problem here...
On Thu, Mar 01, 2018 at 10:34:37PM +0100, Ladislav Michl wrote:
On Thu, Mar 01, 2018 at 08:04:30PM +0000, Mark Brown wrote:
Which other commits in my tree does this depend on?
91880a6b6ba3 ("ASoC: wm9867: replace codec to component") Note, we have naming problem here...
Ah, I see. Like I say, please resend.
participants (3)
-
kbuild test robot -
Ladislav Michl -
Mark Brown