[alsa-devel] Verb for 0x17 pin config
Hi Takashi,
commit http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=977e6... ALSA: hda/realtek - Support Dell headset mode for ALC298
Dell had use verb to do speaker preset. So, The same SSID maybe 0x17 verb was different.
0x17 0x90170110 0x17 0x90170140 0x17 0x90170150
Upper verb will show on this case.
Could I change it to quirk for SSID?
BR, Kailang
On Wed, 05 Aug 2015 08:42:03 +0200, Kailang wrote:
Hi Takashi,
commit http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=977e6... ALSA: hda/realtek - Support Dell headset mode for ALC298
Dell had use verb to do speaker preset. So, The same SSID maybe 0x17 verb was different.
0x17 0x90170110 0x17 0x90170140 0x17 0x90170150
Upper verb will show on this case.
Could I change it to quirk for SSID?
It would be one option. OTOH, right now we have a patch to add 0x90170110, so the only missing is 0x90170150. Just adding it would be an easier option, I suppose.
Takashi
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Wednesday, August 05, 2015 2:59 PM To: Kailang Cc: (alsa-devel@alsa-project.org) Subject: Re: Verb for 0x17 pin config
On Wed, 05 Aug 2015 08:42:03 +0200, Kailang wrote:
Hi Takashi,
commit
http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id
=977e627684df0f60bdf2a768ec4772f42fe843fc ALSA: hda/realtek - Support Dell headset mode for ALC298
Dell had use verb to do speaker preset. So, The same SSID
maybe 0x17 verb was different.
0x17 0x90170110 0x17 0x90170140 0x17 0x90170150
Upper verb will show on this case.
Could I change it to quirk for SSID?
It would be one option. OTOH, right now we have a patch to add 0x90170110, so the only missing is 0x90170150. Just adding it would be an easier option, I suppose.
So, you mean I add as below patch.
+ SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, + ALC298_STANDARD_PINS, + {0x12, 0x90a60130}, + {0x13, 0x40000000}, + {0x14, 0x411111f0}, + {0x17, 0x90170110}, + {0x1d, 0x4068a36d}, + {0x21, 0x03211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, + ALC298_STANDARD_PINS, + {0x12, 0x90a60130}, + {0x13, 0x40000000}, + {0x14, 0x411111f0}, + {0x17, 0x90170150}, + {0x1d, 0x4068a36d}, + {0x21, 0x03211020}),
Right?
Takashi
------Please consider the environment before printing this e-mail.
On Wed, 05 Aug 2015 09:07:06 +0200, Kailang wrote:
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Wednesday, August 05, 2015 2:59 PM To: Kailang Cc: (alsa-devel@alsa-project.org) Subject: Re: Verb for 0x17 pin config
On Wed, 05 Aug 2015 08:42:03 +0200, Kailang wrote:
Hi Takashi,
commit
http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id
=977e627684df0f60bdf2a768ec4772f42fe843fc ALSA: hda/realtek - Support Dell headset mode for ALC298
Dell had use verb to do speaker preset. So, The same SSID
maybe 0x17 verb was different.
0x17 0x90170110 0x17 0x90170140 0x17 0x90170150
Upper verb will show on this case.
Could I change it to quirk for SSID?
It would be one option. OTOH, right now we have a patch to add 0x90170110, so the only missing is 0x90170150. Just adding it would be an easier option, I suppose.
So, you mean I add as below patch.
SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
ALC298_STANDARD_PINS,{0x12, 0x90a60130},{0x13, 0x40000000},{0x14, 0x411111f0},{0x17, 0x90170110},{0x1d, 0x4068a36d},{0x21, 0x03211020}),SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
ALC298_STANDARD_PINS,{0x12, 0x90a60130},{0x13, 0x40000000},{0x14, 0x411111f0},{0x17, 0x90170150},{0x1d, 0x4068a36d},{0x21, 0x03211020}),Right?
With the latest code, only the following would be needed:
@@ -5579,6 +5579,9 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, ALC298_STANDARD_PINS, {0x17, 0x90170110}), + SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, + ALC298_STANDARD_PINS, + {0x17, 0x90170150}), {} };
Takashi
Hi Takashi,
Update patch as attach. Thanks.
BR, Kailang
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Wednesday, August 05, 2015 3:17 PM To: Kailang Cc: (alsa-devel@alsa-project.org) Subject: Re: Verb for 0x17 pin config
On Wed, 05 Aug 2015 09:07:06 +0200, Kailang wrote:
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Wednesday, August 05, 2015 2:59 PM To: Kailang Cc: (alsa-devel@alsa-project.org) Subject: Re: Verb for 0x17 pin config
On Wed, 05 Aug 2015 08:42:03 +0200, Kailang wrote:
Hi Takashi,
commit
http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?
id
=977e627684df0f60bdf2a768ec4772f42fe843fc ALSA: hda/realtek - Support Dell headset mode for ALC298
Dell had use verb to do speaker preset. So, The same SSID
maybe 0x17 verb was different.
0x17 0x90170110 0x17 0x90170140 0x17 0x90170150
Upper verb will show on this case.
Could I change it to quirk for SSID?
It would be one option. OTOH, right now we have a patch to add 0x90170110, so the only missing is 0x90170150. Just
adding it would
be an easier option, I suppose.
So, you mean I add as below patch.
- SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell",
ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
ALC298_STANDARD_PINS,{0x12, 0x90a60130},{0x13, 0x40000000},{0x14, 0x411111f0},{0x17, 0x90170110},{0x1d, 0x4068a36d},{0x21, 0x03211020}),SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell",
ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
ALC298_STANDARD_PINS,{0x12, 0x90a60130},{0x13, 0x40000000},{0x14, 0x411111f0},{0x17, 0x90170150},{0x1d, 0x4068a36d},{0x21, 0x03211020}),Right?
With the latest code, only the following would be needed:
@@ -5579,6 +5579,9 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, ALC298_STANDARD_PINS, {0x17, 0x90170110}),
- SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell",
ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
ALC298_STANDARD_PINS,{0x17, 0x90170150}),};
Takashi
------Please consider the environment before printing this e-mail.
On Wed, 05 Aug 2015 10:13:33 +0200, Kailang wrote:
Hi Takashi,
Update patch as attach.
Thanks. The addition for 0x90170110 was already done by Woodrow's patch, so only 0x90170150 is missing.
Below is the patch I'm going to apply on top.
Takashi
--- From: Takashi Iwai tiwai@suse.de Subject: [PATCH] ALSA: hda - yet another fix for Dell headset mic with ALC3266
It turned out that there are three variants of pin config values of NID 0x17 on Dell laptops with ALC3266 (alias of ALC298): 0x90170110, 0x90170140 and 0x90170150. The first two have been already covered by commits 703867e2f252 and 977e627684df, so this commit adds the missing last entry.
While we're at it, rearrange the three entries in the order of pincfg values.
Reported-by: Kailang Yang kailang@realtek.com Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/pci/hda/patch_realtek.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 9107929dc545..88ddbb0668b7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5574,10 +5574,13 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x13, 0x90a60140}), SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, ALC298_STANDARD_PINS, + {0x17, 0x90170110}), + SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, + ALC298_STANDARD_PINS, {0x17, 0x90170140}), SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, ALC298_STANDARD_PINS, - {0x17, 0x90170110}), + {0x17, 0x90170150}), {} };
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Wednesday, August 05, 2015 6:45 PM To: Kailang Cc: Woodrow Shen; (alsa-devel@alsa-project.org) Subject: Re: Verb for 0x17 pin config
On Wed, 05 Aug 2015 10:13:33 +0200, Kailang wrote:
Hi Takashi,
Update patch as attach.
Thanks. The addition for 0x90170110 was already done by Woodrow's patch, so only 0x90170150 is missing.
Below is the patch I'm going to apply on top.
Many Thanks.
Takashi
From: Takashi Iwai tiwai@suse.de Subject: [PATCH] ALSA: hda - yet another fix for Dell headset mic with ALC3266
It turned out that there are three variants of pin config values of NID 0x17 on Dell laptops with ALC3266 (alias of ALC298): 0x90170110, 0x90170140 and 0x90170150. The first two have been already covered by commits 703867e2f252 and 977e627684df, so this commit adds the missing last entry.
While we're at it, rearrange the three entries in the order of pincfg values.
Reported-by: Kailang Yang kailang@realtek.com Signed-off-by: Takashi Iwai tiwai@suse.de
sound/pci/hda/patch_realtek.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 9107929dc545..88ddbb0668b7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5574,10 +5574,13 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x13, 0x90a60140}), SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, ALC298_STANDARD_PINS,
{0x17, 0x90170110}),- SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell",
ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
ALC298_STANDARD_PINS,ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, ALC298_STANDARD_PINS,
{0x17, 0x90170110}),
{0x17, 0x90170150}),};
-- 2.5.0
------Please consider the environment before printing this e-mail.
participants (2)
-
Kailang -
Takashi Iwai