[alsa-devel] commit b1ef29725865 (ACPI _REV=2) causes sound regression on Dell XPS 13 [Was: Discussion around quirking the _REV behavior for the XPS 13 (2015) until 4.2]
Hi,
(CC'ing sound experts)
indeed, commit b1ef29725865 causes a severe regression -- actually, it causes sound to be totally unusuable on the Dell XPS 13 (2015) on Debian jessie, while it works fine in 4.0 / with b1ef29725865 reverted.
According to an off-list discussion, the sound breakage (and not just some jack detection issue) seems to be caused due to alsa-lib being too old. The matter is further complicated by the issue that the driver asks for some firmware blob intel/IntcPP01.bin which (at least) I cannot find anywhere.
Under the no-regression rule, this means that either b1ef29725865 needs to be reverted or we need to find another solution to this matter, such as an override. And I think it is needed for longer than just for 4.1, as it will continue to be cause regressions on quite recent userspace.
Best, Dominik
PS/OT: Probably I'm preaching to the choir, but @Mario: it's a pity the XPS (or some versions of it) with pre-installed Ubuntu actually ships with a Wifi adapter which seems to be unsupported by upstream Linux...
On Mon, May 04, 2015 at 06:26:25PM -0500, Mario Limonciello wrote:
On 04/28/2015 06:21 PM, Mario Limonciello wrote:
Hi,
Due to b1ef2972586577e0ca9675254ee141f65a8824e5 landing recently as a result of some previous ACPI community discussion, the Dell XPS 13 (2015) no longer has fully functional audio. In case you aren't aware, the XPS 13 (2015) switches audio modes based upon a combination of what's detected for the _OSI string and _REV values. When "Windows 2013" is found with _REV=2 the audio codec will be configured for I2S audio mode. When "Windows 2013" with _REV=5 is found it will be configured for HDA audio mode.
I2S audio is improving, but not as mature as HDA audio mode is at this point. Currently jack detection does not work properly in 4.1 with I2S audio codecs. I've been notified that the support for jack detection will be landing in 4.2. I'd like to discuss the possibility of including a quirk for the _REV behavior when the DMI information corresponding to the Dell XPS 13 (2015) is detected for 4.1. This will let it continue to run in HDA mode until I2S mode is mature.
I'd also like to plan for the quirk to be dropped when jack detection has landed for 4.2 (or if it gets pushed out further when it lands for 4.3).
Would you guys be open to that?
Thanks,
Hello,
I just wanted to follow up on this, I would like to come up with a solution before it's too late for 4.1 on the XPS 13 (2015).
Thanks,
On 05/11/2015 01:26 PM, Dominik Brodowski wrote:
Hi,
(CC'ing sound experts)
indeed, commit b1ef29725865 causes a severe regression -- actually, it causes sound to be totally unusuable on the Dell XPS 13 (2015) on Debian jessie, while it works fine in 4.0 / with b1ef29725865 reverted.
According to an off-list discussion, the sound breakage (and not just some jack detection issue) seems to be caused due to alsa-lib being too old. The matter is further complicated by the issue that the driver asks for some firmware blob intel/IntcPP01.bin which (at least) I cannot find anywhere.
Under the no-regression rule, this means that either b1ef29725865 needs to be reverted or we need to find another solution to this matter, such as an override. And I think it is needed for longer than just for 4.1, as it will continue to be cause regressions on quite recent userspace.
Best, Dominik
PS/OT: Probably I'm preaching to the choir, but @Mario: it's a pity the XPS (or some versions of it) with pre-installed Ubuntu actually ships with a Wifi adapter which seems to be unsupported by upstream Linux...
Dominik,
Yes I've noticed it's acting much worse for me too with 4.1-rc2 on Ubuntu 15.04 userspace (which is quite new indeed). I really think the right solution is some sort of quirk against the XPS 13 on the _REV behavior until this is reasonably mature.
OT: Yes, this feedback has been taken to heart by the team. We're working on adding more variants with alternate adapters. :)
+Liam.
-----Original Message----- From: Dominik Brodowski [mailto:linux@dominikbrodowski.net] Sent: Tuesday, May 12, 2015 2:27 AM To: Mario Limonciello; Moore, Robert; Zheng, Lv; Wysocki, Rafael J Cc: linux-acpi@vger.kernel.org; broonie@kernel.org; Lu, Han; Jie, Yang; alsa- devel@alsa-project.org Subject: commit b1ef29725865 (ACPI _REV=2) causes sound regression on Dell XPS 13 [Was: Discussion around quirking the _REV behavior for the XPS 13 (2015) until 4.2]
Hi,
(CC'ing sound experts)
indeed, commit b1ef29725865 causes a severe regression -- actually, it causes sound to be totally unusuable on the Dell XPS 13 (2015) on Debian jessie, while it works fine in 4.0 / with b1ef29725865 reverted.
According to an off-list discussion, the sound breakage (and not just some jack detection issue) seems to be caused due to alsa-lib being too old. The matter is further complicated by the issue that the driver asks for some firmware blob intel/IntcPP01.bin which (at least) I cannot find anywhere.
Lacking of IntcPP01.bin should not block Broadwell ADSP audio functions.
Suppose these should be the same issues Mark told us, right?
Yes, we are doing some fixes in alsa-lib/ucm/config part, without these fixes, You can do manual volume +/- and switches on/off in alsamixer GUI interface.
BTW, if you can create kernel.org bugs to descript these issues, it will be helpful for to trace and fix them after we got this XPS 13 machine.
Thanks, ~Keyon
Under the no-regression rule, this means that either b1ef29725865 needs to be reverted or we need to find another solution to this matter, such as an override. And I think it is needed for longer than just for 4.1, as it will continue to be cause regressions on quite recent userspace.
Best, Dominik
PS/OT: Probably I'm preaching to the choir, but @Mario: it's a pity the XPS (or some versions of it) with pre-installed Ubuntu actually ships with a Wifi adapter which seems to be unsupported by upstream Linux...
On Mon, May 04, 2015 at 06:26:25PM -0500, Mario Limonciello wrote:
On 04/28/2015 06:21 PM, Mario Limonciello wrote:
Hi,
Due to b1ef2972586577e0ca9675254ee141f65a8824e5 landing recently as a
result of some previous ACPI community discussion, the Dell XPS 13 (2015) no longer has fully functional audio. In case you aren't aware, the XPS 13 (2015) switches audio modes based upon a combination of what's detected for the _OSI string and _REV values. When "Windows 2013" is found with _REV=2 the audio codec will be configured for I2S audio mode. When "Windows 2013" with _REV=5 is found it will be configured for HDA audio mode.
I2S audio is improving, but not as mature as HDA audio mode is at this
point. Currently jack detection does not work properly in 4.1 with I2S audio codecs. I've been notified that the support for jack detection will be landing in 4.2. I'd like to discuss the possibility of including a quirk for the _REV behavior when the DMI information corresponding to the Dell XPS 13 (2015) is detected for 4.1. This will let it continue to run in HDA mode until I2S mode is mature.
I'd also like to plan for the quirk to be dropped when jack detection has
landed for 4.2 (or if it gets pushed out further when it lands for 4.3).
Would you guys be open to that?
Thanks,
Hello,
I just wanted to follow up on this, I would like to come up with a solution
before it's too late for 4.1 on the XPS 13 (2015).
Thanks,
On Mon, May 11, 2015 at 08:26:58PM +0200, Dominik Brodowski wrote:
Also CCing Matthew who came up with the original version of the version change and Liam who is one of Intel's audio experts.
According to an off-list discussion, the sound breakage (and not just some jack detection issue) seems to be caused due to alsa-lib being too old.
Right, it needs the userspace configuration files installing.
The matter is further complicated by the issue that the driver asks for some firmware blob intel/IntcPP01.bin which (at least) I cannot find anywhere.
As previously advised that firmware is optional.
Under the no-regression rule, this means that either b1ef29725865 needs to be reverted or we need to find another solution to this matter, such as an override. And I think it is needed for longer than just for 4.1, as it will continue to be cause regressions on quite recent userspace.
Does this also affect other behaviour of the system? I'd be pretty unhappy if it introduce power regressions for example, I mostly don't use audio on my laptops but I care a lot about how long it'll run disconnected. It *is* quite a new laptop and my experience installing was very much that it was in bringup (though quite a bit of this was userspace).
On 05/12/2015 05:12 AM, Mark Brown wrote:
On Mon, May 11, 2015 at 08:26:58PM +0200, Dominik Brodowski wrote:
Also CCing Matthew who came up with the original version of the version change and Liam who is one of Intel's audio experts.
According to an off-list discussion, the sound breakage (and not just some jack detection issue) seems to be caused due to alsa-lib being too old.
Right, it needs the userspace configuration files installing.
Is it just configuration files? With 4.1-rc3 I've not been able to get sound working mucking with any mixers.
The matter is further complicated by the issue that the driver asks for some firmware blob intel/IntcPP01.bin which (at least) I cannot find anywhere.
As previously advised that firmware is optional.
The errors in dmesg make it seem like that was related to the firmware missing, but that is a red herring it sounds like.
Under the no-regression rule, this means that either b1ef29725865 needs to be reverted or we need to find another solution to this matter, such as an override. And I think it is needed for longer than just for 4.1, as it will continue to be cause regressions on quite recent userspace.
Does this also affect other behaviour of the system? I'd be pretty unhappy if it introduce power regressions for example, I mostly don't use audio on my laptops but I care a lot about how long it'll run disconnected. It *is* quite a new laptop and my experience installing was very much that it was in bringup (though quite a bit of this was userspace).
I just tried it with 4.1-rc3 from Ubuntu's mainline PPA and an Ubuntu 15.04 userspace. It does affect the behavior of the system. See all the PCM errors in dmesg: https://bugzilla.kernel.org/attachment.cgi?id=176511
At least with BIOS A03 (latest), Ubuntu 15.04 (3.19ish and modern userspace) or with 4.0 and recent userspace the experience shouldn't be bringup.
Keyon,
There is a bug opened at https://bugzilla.kernel.org/show_bug.cgi?id=93361. I've added updated notes to this for 4.1-rc3 experience.
On Tue, May 12, 2015 at 10:26:24AM -0500, Mario Limonciello wrote:
On 05/12/2015 05:12 AM, Mark Brown wrote:
On Mon, May 11, 2015 at 08:26:58PM +0200, Dominik Brodowski wrote:
Please fix your mail client to word wrap within paragraphs and leave blank lines between paragraphs. Your current mail client is doing neither which makes your mails hard to read.
Also CCing Matthew who came up with the original version of the version change and Liam who is one of Intel's audio experts.
According to an off-list discussion, the sound breakage (and not just some jack detection issue) seems to be caused due to alsa-lib being too old.
Right, it needs the userspace configuration files installing.
Is it just configuration files? With 4.1-rc3 I've not been able to get sound working mucking with any mixers.
You need PulseAudio 6.0 but otherwise yes, it works for me.
The matter is further complicated by the issue that the driver asks for some firmware blob intel/IntcPP01.bin which (at least) I cannot find anywhere.
As previously advised that firmware is optional.
The errors in dmesg make it seem like that was related to the firmware missing, but that is a red herring it sounds like.
Yes, it is.
Does this also affect other behaviour of the system? I'd be pretty unhappy if it introduce power regressions for example, I mostly don't use audio on my laptops but I care a lot about how long it'll run disconnected. It *is* quite a new laptop and my experience installing was very much that it was in bringup (though quite a bit of this was userspace).
I just tried it with 4.1-rc3 from Ubuntu's mainline PPA and an Ubuntu 15.04 userspace. It does affect the behavior of the system. See all the PCM errors in dmesg:
That wasn't my question. I'm asking what else the firmware is changing based on detecting Linux, we don't want to just move onto a different set of bugs somewhere else.
At least with BIOS A03 (latest), Ubuntu 15.04 (3.19ish and modern userspace) or with 4.0 and recent userspace the experience shouldn't be bringup.
I'm not seeing any of the hw_params() issues with v4.1 - are you perhaps using an old linux-firmware? I don't know how up to date Ubuntu is there.
On 05/12/2015 11:18 AM, Mark Brown wrote:
Please fix your mail client to word wrap within paragraphs and leave blank lines between paragraphs. Your current mail client is doing neither which makes your mails hard to read.
Sorry about that, I've adjusted my mail client settings.
You need PulseAudio 6.0 but otherwise yes, it works for me.
Ubuntu 15.04 is running Pulseaudio 6.0.
That wasn't my question. I'm asking what else the firmware is changing based on detecting Linux, we don't want to just move onto a different set of bugs somewhere else.
These are the different flows supported and what changes in the different flows. This is up to date as of BIOS A03:
When Linux is detected (_OSI Windows 2013 & _REV 5): * EC configures the audio controller for HDA mode on next cold boot. * HDA audio device is included in PCI address space. * Touchpad is put into I2C mode.
When Windows 8.1 is detected or currently Linux 4.1 (_OSI Windows 2013 & _REV 2): * EC configures the audio controller for I2S mode on next cold boot. * ADSP audio device included in ACPI (INT3438). * Touchpad is put in I2C mode.
When Windows 7 is detected (_OSI Windows 2009): * EC configures the audio controller for HDA mode on the next cold boot. * HDA audio device included in PCI address space. * Touchpad is put in PS2 mode.
I'm not seeing any of the hw_params() issues with v4.1 - are you perhaps using an old linux-firmware? I don't know how up to date Ubuntu is there.
linux-firmware ubuntu 15.04 version: 1.143. This is based off upstream cef33368c4d3425f11306496f0250f8ef1cf3c1f, updated on March 4 2015.
On Tue, May 12, 2015 at 11:45:40AM -0500, Mario Limonciello wrote:
I'm not seeing any of the hw_params() issues with v4.1 - are you perhaps using an old linux-firmware? I don't know how up to date Ubuntu is there.
linux-firmware ubuntu 15.04 version: 1.143. This is based off upstream cef33368c4d3425f11306496f0250f8ef1cf3c1f, updated on March 4 2015.
That's the same firmware I have. Weird, I don't know if the Intel guys have any bright ideas here?
-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Wednesday, May 13, 2015 1:35 AM To: Mario Limonciello Cc: Dominik Brodowski; Moore, Robert; Zheng, Lv; Wysocki, Rafael J; linux- acpi@vger.kernel.org; Lu, Han; Jie, Yang; alsa-devel@alsa-project.org; Matthew Garrett; Girdwood, Liam R Subject: Re: commit b1ef29725865 (ACPI _REV=2) causes sound regression on Dell XPS 13 [Was: Discussion around quirking the _REV behavior for the XPS 13 (2015) until 4.2]
On Tue, May 12, 2015 at 11:45:40AM -0500, Mario Limonciello wrote:
I'm not seeing any of the hw_params() issues with v4.1 - are you perhaps using an old linux-firmware? I don't know how up to date Ubuntu is there.
linux-firmware ubuntu 15.04 version: 1.143. This is based off upstream cef33368c4d3425f11306496f0250f8ef1cf3c1f, updated on March 4 2015.
That's the same firmware I have. Weird, I don't know if the Intel guys have any bright ideas here?
Hi Mario, can you try disabling pulseaudio to see if anything change? Once I got one XPS 13 9343, I can debug on it, we have ordered it, but been told still need wait 4 more weeks for lacking of the LCD screen materials.
~Keyon
On 05/12/2015 09:14 PM, Jie, Yang wrote:
Hi Mario, can you try disabling pulseaudio to see if anything change? Once I got one XPS 13 9343, I can debug on it, we have ordered it, but been told still need wait 4 more weeks for lacking of the LCD screen materials.
~Keyon
Keyon,
Yes, if I kill pulseaudio (and prevent it from starting back up), I am able to get audio by running: speaker-test -c 2 -t wav -D plughw:broadwellrt286
I've tried to remove .config/pulse, but it's still not working at all when pulse launches up.
Thanks,
Mark,
On Tue, May 12, 2015 at 11:12:58AM +0100, Mark Brown wrote:
According to an off-list discussion, the sound breakage (and not just some jack detection issue) seems to be caused due to alsa-lib being too old.
Right, it needs the userspace configuration files installing.
... and PulseAudio 6.0, as you stated in another message, but which is not in Debian jessie. Therefore, commit b1ef29725865 does cause a regression (even though it's just a side effect): the Dell XPS 13 (2013) works just fine with a standard Debian jessie install and a current kernel. Sound worked fine until commit b1ef29725865 / works fine with commit b1ef29725865 reverted.
New kernels should continue to work on (reasonably) old userspace; and currently I do not see how this can be made to work with commit b1ef29725865 and no quirk / override. As soon as I find the time for that, I'll try to create a patch for that -- unless someone beats me to that.
Under the no-regression rule, this means that either b1ef29725865 needs to be reverted or we need to find another solution to this matter, such as an override. And I think it is needed for longer than just for 4.1, as it will continue to be cause regressions on quite recent userspace.
Does this also affect other behaviour of the system? I'd be pretty unhappy if it introduce power regressions for example, I mostly don't use audio on my laptops but I care a lot about how long it'll run disconnected. It *is* quite a new laptop and my experience installing was very much that it was in bringup (though quite a bit of this was userspace).
Well, sound _is_ quite important to me; and as stated above, the laptop works just fine otherwise on Debian jessie (well, except the WiFi adapter, but that's another story).
Best, Dominik
On Tue, May 12, 2015 at 07:13:46PM +0200, Dominik Brodowski wrote:
... and PulseAudio 6.0, as you stated in another message, but which is not in Debian jessie. Therefore, commit b1ef29725865 does cause a regression (even though it's just a side effect): the Dell XPS 13 (2013) works just fine with a standard Debian jessie install and a current kernel. Sound worked fine until commit b1ef29725865 / works fine with commit b1ef29725865 reverted.
New kernels should continue to work on (reasonably) old userspace; and currently I do not see how this can be made to work with commit b1ef29725865 and no quirk / override. As soon as I find the time for that, I'll try to create a patch for that -- unless someone beats me to that.
IIRC I wasn't getting a useful GUI out of the box with Jessie either, though that could've been installer stuff - I can't remember any more (and the support for high DPI displays within the installer itself makes me happy I've got an eye checkup booked soon).
Well, sound _is_ quite important to me; and as stated above, the laptop works just fine otherwise on Debian jessie (well, except the WiFi adapter, but that's another story).
I just swapped my WiFi adaptor out for an Intel card, fairly easy to do.
participants (4)
-
Dominik Brodowski -
Jie, Yang -
Mario Limonciello -
Mark Brown