On Wed, Aug 04, 2010 at 08:59:49AM -0400, Bill Pemberton wrote:

...

No, just stomping over the variable to shut up the warning doesn't improve anything at all. You need to make sure that the compiler can actually follow the control flow to see that the data is always initialised rather than disabling the check and missing any actual issues.

I did, hence the comment in the commit that the variable is initialized by fll_factors().

You're completely missing the point here. What I said was that you need to make sure that the *compiler* can actually follow the control flow. You've not done that, you've stomped over the warning to shut both this and any valid warnings related to the structure up.