[alsa-devel] [PATCH] alsactl: avoid needless wakeups in monitor loop.
The timeout wasn't really being used for anything; disabling it should reduce idle energy consumption slightly.
Signed-off-by: Zev Weiss zev@bewilderbeest.net --- alsactl/monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/alsactl/monitor.c b/alsactl/monitor.c index 6b090e4f5c92..6d9328d899a4 100644 --- a/alsactl/monitor.c +++ b/alsactl/monitor.c @@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs, int count; int i;
- count = epoll_wait(epfd, epev, max_ev_count, 200); + count = epoll_wait(epfd, epev, max_ev_count, -1); if (count < 0) { err = count; break;
Ping -- it's been a while since I sent this and https://mailman.alsa-project.org/pipermail/alsa-devel/2019-October/156866.ht..., never saw any response though. Any problems with these patches?
Thanks, Zev Weiss
On Mon, Oct 14, 2019 at 11:38:02PM CDT, Zev Weiss wrote:
The timeout wasn't really being used for anything; disabling it should reduce idle energy consumption slightly.
Signed-off-by: Zev Weiss zev@bewilderbeest.net
alsactl/monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/alsactl/monitor.c b/alsactl/monitor.c index 6b090e4f5c92..6d9328d899a4 100644 --- a/alsactl/monitor.c +++ b/alsactl/monitor.c @@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs, int count; int i;
count = epoll_wait(epfd, epev, max_ev_count, 200);
count = epoll_wait(epfd, epev, max_ev_count, -1);-- 2.23.0
Hi,
On Mon, Oct 14, 2019 at 11:38:02PM -0500, Zev Weiss wrote:
The timeout wasn't really being used for anything; disabling it should reduce idle energy consumption slightly.
Signed-off-by: Zev Weiss zev@bewilderbeest.net
alsactl/monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I overlooked it as well... It looks good to me.
Reviewed-by: Takashi Sakamoto o-takashi@sakamocchi.jp Tested-by: Takashi Sakamoto o-takashi@sakamocchi.jp
diff --git a/alsactl/monitor.c b/alsactl/monitor.c index 6b090e4f5c92..6d9328d899a4 100644 --- a/alsactl/monitor.c +++ b/alsactl/monitor.c @@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs, int count; int i;
count = epoll_wait(epfd, epev, max_ev_count, 200);
count = epoll_wait(epfd, epev, max_ev_count, -1);-- 2.23.0
Regards
Takashi Sakamoto
Dne 12. 04. 20 v 4:19 Takashi Sakamoto napsal(a):
Hi,
On Mon, Oct 14, 2019 at 11:38:02PM -0500, Zev Weiss wrote:
The timeout wasn't really being used for anything; disabling it should reduce idle energy consumption slightly.
Signed-off-by: Zev Weiss zev@bewilderbeest.net
alsactl/monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I overlooked it as well... It looks good to me.
Reviewed-by: Takashi Sakamoto o-takashi@sakamocchi.jp Tested-by: Takashi Sakamoto o-takashi@sakamocchi.jp
Applied. Thanks.
Jaroslav
diff --git a/alsactl/monitor.c b/alsactl/monitor.c index 6b090e4f5c92..6d9328d899a4 100644 --- a/alsactl/monitor.c +++ b/alsactl/monitor.c @@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs, int count; int i;
count = epoll_wait(epfd, epev, max_ev_count, 200);
count = epoll_wait(epfd, epev, max_ev_count, -1);-- 2.23.0
Regards
Takashi Sakamoto
participants (3)
-
Jaroslav Kysela -
Takashi Sakamoto -
Zev Weiss