[alsa-devel] [PATCH v2] ASoC: sta32x: fix register range in regmap.
The STA32X_AUTO3 is a writable register that currently does not appear in the regmap ranges(neither read nor write). By adding this register to the register ranges there is no gap anymore and the existing register ranges can be joined. This fixes a regression introduced in commit a1be4cead9b9504aa6fc93b624975601cec8c188 where the driver was moved to direct regmap usage and the STA32X_AUTO3 register was missed. That made it impossible to choose the preset EQ mode set through the STA32X_AUTO3 register.
Signed-off-by: Thomas Niederprüm niederp@physik.uni-kl.de ---
changes since v1: - updated to apply to linux-next. - added commit id that introduced the regression in the commit message.
sound/soc/codecs/sta32x.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index e28c185..fc686ca 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c @@ -106,13 +106,11 @@ static const struct reg_default sta32x_regs[] = { };
static const struct regmap_range sta32x_write_regs_range[] = { - regmap_reg_range(STA32X_CONFA, STA32X_AUTO2), - regmap_reg_range(STA32X_C1CFG, STA32X_FDRC2), + regmap_reg_range(STA32X_CONFA, STA32X_FDRC2), };
static const struct regmap_range sta32x_read_regs_range[] = { - regmap_reg_range(STA32X_CONFA, STA32X_AUTO2), - regmap_reg_range(STA32X_C1CFG, STA32X_FDRC2), + regmap_reg_range(STA32X_CONFA, STA32X_FDRC2), };
static const struct regmap_range sta32x_volatile_regs_range[] = {
On Sat, Feb 21, 2015 at 05:22:38PM +0100, Thomas Niederprüm wrote:
register ranges can be joined. This fixes a regression introduced in commit a1be4cead9b9504aa6fc93b624975601cec8c188 where the driver was
changes since v1:
- updated to apply to linux-next.
- added commit id that introduced the regression in the commit message.
Applied, but when referencing commits please remember to always include a human readable description of the commit so people can understand the commit message and if it's a fix use the Fixes: tag. It's also better to abbreviate the commit ID to twelve characters, it's much more manageable.
participants (2)
-
Mark Brown
-
Thomas Niederprüm