[alsa-devel] [PATCH] snd-aoa-i2sbus: use MODULE_DEVICE_TABLE instead of plain MODULE_ALIAS
This patch changes snd-aoa-i2sbus to use MODULE_DEVICE_TABLE instead of a hardcoded MODULE_ALIAS. Thanks to Sylvain Munaut for pointing this out.
Signed-off-by: Johannes Berg johannes@sipsolutions.net
--- Please apply to the alsa tree.
sound/aoa/soundbus/i2sbus/i2sbus-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
--- wireless-dev.orig/sound/aoa/soundbus/i2sbus/i2sbus-core.c 2007-03-28 13:08:25.903457795 +0200 +++ wireless-dev/sound/aoa/soundbus/i2sbus/i2sbus-core.c 2007-03-28 13:09:21.253457795 +0200 @@ -23,9 +23,6 @@ MODULE_LICENSE("GPL"); MODULE_AUTHOR("Johannes Berg johannes@sipsolutions.net"); MODULE_DESCRIPTION("Apple Soundbus: I2S support"); -/* for auto-loading, declare that we handle this weird - * string that macio puts into the relevant device */ -MODULE_ALIAS("of:Ni2sTi2sC");
static int force; module_param(force, int, 0444); @@ -37,6 +34,8 @@ static struct of_device_id i2sbus_match[ { } };
+MODULE_DEVICE_TABLE(of, i2sbus_match); + static int alloc_dbdma_descriptor_ring(struct i2sbus_dev *i2sdev, struct dbdma_command_mem *r, int numcmds)
At Wed, 28 Mar 2007 13:18:20 +0200, Johannes Berg wrote:
This patch changes snd-aoa-i2sbus to use MODULE_DEVICE_TABLE instead of a hardcoded MODULE_ALIAS. Thanks to Sylvain Munaut for pointing this out.
Signed-off-by: Johannes Berg johannes@sipsolutions.net
Applied to ALSA tree now. Thanks.
Takashi
Hi Takashi,
On Wed, 2007-03-28 at 13:56 +0200, Takashi Iwai wrote:
At Wed, 28 Mar 2007 13:18:20 +0200, Johannes Berg wrote:
This patch changes snd-aoa-i2sbus to use MODULE_DEVICE_TABLE instead of a hardcoded MODULE_ALIAS. Thanks to Sylvain Munaut for pointing this out.
Signed-off-by: Johannes Berg johannes@sipsolutions.net
Applied to ALSA tree now. Thanks.
What happened to this patch? It seems it hasn't shown up in Linus's tree yet, but IIRC it's required with some modalias changes from Sylvain.
johannes
At Thu, 10 May 2007 17:51:16 +0200, Johannes Berg wrote:
Hi Takashi,
On Wed, 2007-03-28 at 13:56 +0200, Takashi Iwai wrote:
At Wed, 28 Mar 2007 13:18:20 +0200, Johannes Berg wrote:
This patch changes snd-aoa-i2sbus to use MODULE_DEVICE_TABLE instead of a hardcoded MODULE_ALIAS. Thanks to Sylvain Munaut for pointing this out.
Signed-off-by: Johannes Berg johannes@sipsolutions.net
Applied to ALSA tree now. Thanks.
What happened to this patch? It seems it hasn't shown up in Linus's tree yet, but IIRC it's required with some modalias changes from Sylvain.
Well, the alsa.git push request was already posted twice, but it wasn't merged yet... Hopefully Linus will catch up soon.
Takashi
On Thu, 2007-05-10 at 18:00 +0200, Takashi Iwai wrote:
Well, the alsa.git push request was already posted twice, but it wasn't merged yet... Hopefully Linus will catch up soon.
This patch doesn't seem to be in perex/alsa.git either though, or are you pushing through some other tree now?
johannes
At Thu, 10 May 2007 18:18:33 +0200, Johannes Berg wrote:
On Thu, 2007-05-10 at 18:00 +0200, Takashi Iwai wrote:
Well, the alsa.git push request was already posted twice, but it wasn't merged yet... Hopefully Linus will catch up soon.
This patch doesn't seem to be in perex/alsa.git either though, or are you pushing through some other tree now?
It's in linus branch.
Takashi
On Thu, 2007-05-10 at 18:19 +0200, Johannes Berg wrote:
This patch doesn't seem to be in perex/alsa.git either though, or are you pushing through some other tree now?
Ah, sorry, it's on the "linus" branch.
johannes
-
Johannes Berg -
Takashi Iwai