[RESEND v3 0/2] Add support for QCM6490 and QCS6490
This patchset adds support for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Changes since v2: - Modify qcm6490 compatible name as qcm6490-idp. Suggested by Dmitry
Changes since v1: - Use existing sc8280xp machine driver instead of separate driver. - Modify qcs6490 compatible name as qcs6490-rb3gen2.
Mohammad Rafi Shaik (2): ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card ASoC: qcom: sc8280xp: Add support for QCM6490 and QCS6490
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ sound/soc/qcom/sc8280xp.c | 2 ++ 2 files changed, 4 insertions(+)
Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 board specific sound card.
The bindings are the same as for other newer Qualcomm ADSP sound cards, thus keep them in existing qcom,sm8250.yaml file, even though Linux driver is separate.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com --- Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 2ab6871e89e5..b2e15ebbd1bc 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -29,6 +29,8 @@ properties: - enum: - qcom,apq8016-sbc-sndcard - qcom,msm8916-qdsp6-sndcard + - qcom,qcm6490-idp-sndcard + - qcom,qcs6490-rb3gen2-sndcard - qcom,qrb5165-rb5-sndcard - qcom,sc7180-qdsp6-sndcard - qcom,sc8280xp-sndcard
On 08/04/2024 06:23, Mohammad Rafi Shaik wrote:
Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 board specific sound card.
The bindings are the same as for other newer Qualcomm ADSP sound cards, thus keep them in existing qcom,sm8250.yaml file, even though Linux driver is separate.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com
Acked-by: Krzysztof Kozlowski krzk@kernel.org
Best regards, Krzysztof
Add compatibles for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com --- sound/soc/qcom/sc8280xp.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index b7fd503a1666..878bd50ad4a7 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) }
static const struct of_device_id snd_sc8280xp_dt_match[] = { + {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"}, + {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"}, {.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"}, {.compatible = "qcom,sm8450-sndcard", "sm8450"}, {.compatible = "qcom,sm8550-sndcard", "sm8550"},
On Mon, Apr 08, 2024 at 09:53:31AM +0530, Mohammad Rafi Shaik wrote:
Add compatibles for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com
sound/soc/qcom/sc8280xp.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index b7fd503a1666..878bd50ad4a7 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) }
static const struct of_device_id snd_sc8280xp_dt_match[] = {
- {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"},
- {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"},
We now have 4 <platform>-sndcard and two <board>-sndcard compatibles here.
Not saying that your patch is wrong, but is this driver board-specific or soc-specific? Srinivas, Krzysztof?
Regards, Bjorn
{.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"}, {.compatible = "qcom,sm8450-sndcard", "sm8450"}, {.compatible = "qcom,sm8550-sndcard", "sm8550"}, -- 2.25.1
On 08/04/2024 14:45, Bjorn Andersson wrote:
On Mon, Apr 08, 2024 at 09:53:31AM +0530, Mohammad Rafi Shaik wrote:
Add compatibles for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com
sound/soc/qcom/sc8280xp.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index b7fd503a1666..878bd50ad4a7 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) }
static const struct of_device_id snd_sc8280xp_dt_match[] = {
- {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"},
- {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"},
We now have 4 <platform>-sndcard and two <board>-sndcard compatibles here.
Not saying that your patch is wrong, but is this driver board-specific or soc-specific? Srinivas, Krzysztof?
To my understanding this is mostly board specific, but it is also partially a software construct thus we simplify it by using SoC compatible for all boards with given SoC.
I have no clue whether this applies here. I think we asked about clarifying the differences, but as you can see nothing improved in the commit msg.
Best regards, Krzysztof
On 08/04/2024 13:45, Bjorn Andersson wrote:
On Mon, Apr 08, 2024 at 09:53:31AM +0530, Mohammad Rafi Shaik wrote:
Add compatibles for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com
sound/soc/qcom/sc8280xp.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index b7fd503a1666..878bd50ad4a7 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) }
static const struct of_device_id snd_sc8280xp_dt_match[] = {
- {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"},
- {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"},
We now have 4 <platform>-sndcard and two <board>-sndcard compatibles here.
Not saying that your patch is wrong, but is this driver board-specific or soc-specific? Srinivas, Krzysztof?
Normally this should be board specific.
In the past we made them SoC specific and provided a way to do board specific changes based on compatible. Recently we stopped adding new drivers as most of these drivers turned out to be identical and lots of code duplication.
Having these compatibles will help both the userspace UCM and provide hooks to do any board/soc specific configurations.
thanks, Srini
Regards, Bjorn
{.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"}, {.compatible = "qcom,sm8450-sndcard", "sm8450"}, {.compatible = "qcom,sm8550-sndcard", "sm8550"}, -- 2.25.1
On 08/04/2024 06:23, Mohammad Rafi Shaik wrote:
This patchset adds support for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Changes since v2:
- Modify qcm6490 compatible name as qcm6490-idp. Suggested by Dmitry
Changes since v1:
- Use existing sc8280xp machine driver instead of separate driver.
- Modify qcs6490 compatible name as qcs6490-rb3gen2.
Why are you resending 15 minutes after previous round?
Best regards, Krzysztof
On 4/8/2024 11:26 AM, Krzysztof Kozlowski wrote:
On 08/04/2024 06:23, Mohammad Rafi Shaik wrote:
This patchset adds support for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Changes since v2:
- Modify qcm6490 compatible name as qcm6490-idp. Suggested by Dmitry
Changes since v1:
- Use existing sc8280xp machine driver instead of separate driver.
- Modify qcs6490 compatible name as qcs6490-rb3gen2.
Why are you resending 15 minutes after previous round?
Best regards, Krzysztof
Found one mistake in cover-letter. Instead of qcm6490-idp given qcs6490-idp.
Modified the cover-letter and reposted.
Thanks & Regards, Rafi.
On 08/04/2024 05:23, Mohammad Rafi Shaik wrote:
This patchset adds support for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Changes since v2:
- Modify qcm6490 compatible name as qcm6490-idp. Suggested by Dmitry
Changes since v1:
- Use existing sc8280xp machine driver instead of separate driver.
- Modify qcs6490 compatible name as qcs6490-rb3gen2.
Mohammad Rafi Shaik (2): ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card ASoC: qcom: sc8280xp: Add support for QCM6490 and QCS6490
LGTM,
Reviewed-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org
--srini
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ sound/soc/qcom/sc8280xp.c | 2 ++ 2 files changed, 4 insertions(+)
On Mon, 08 Apr 2024 09:53:29 +0530, Mohammad Rafi Shaik wrote:
This patchset adds support for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Changes since v2:
- Modify qcm6490 compatible name as qcm6490-idp. Suggested by Dmitry
Changes since v1:
- Use existing sc8280xp machine driver instead of separate driver.
- Modify qcs6490 compatible name as qcs6490-rb3gen2.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card commit: c64c4e3f789123e82ffae3404d108cf826c9599a [2/2] ASoC: qcom: sc8280xp: Add support for QCM6490 and QCS6490 commit: 5485c3fa96f78314207a30e81dbe270424d70ede
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (5)
-
Bjorn Andersson -
Krzysztof Kozlowski -
Mark Brown -
Mohammad Rafi Shaik -
Srinivas Kandagatla