[PATCH] ASoC: fsl-asoc-card: Log error code when we fail to register
The chances are that any error we see here will be EPROBE_DEFER but let's actually tell the user so they know.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/fsl/fsl-asoc-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index c836848ef0a6..58834e56a278 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -855,7 +855,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
ret = devm_snd_soc_register_card(&pdev->dev, &priv->card); if (ret) { - dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed\n"); + dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed: %d\n", ret); goto asrc_fail; }
--- base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 change-id: 20230106-asoc-fsl-err-log-4915ba3fc6c4
Best regards,
On Sat, Jan 7, 2023 at 7:13 AM Mark Brown broonie@kernel.org wrote:
The chances are that any error we see here will be EPROBE_DEFER but let's actually tell the user so they know.
Signed-off-by: Mark Brown broonie@kernel.org
Acked-by: Shengjiu Wang shengjiu.wang@gmail.com
Best regards Wang shengjiu
sound/soc/fsl/fsl-asoc-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index c836848ef0a6..58834e56a278 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -855,7 +855,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
ret = devm_snd_soc_register_card(&pdev->dev, &priv->card); if (ret) {
dev_err_probe(&pdev->dev, ret, "snd_soc_register_cardfailed\n");
dev_err_probe(&pdev->dev, ret, "snd_soc_register_cardfailed: %d\n", ret); goto asrc_fail; }
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 change-id: 20230106-asoc-fsl-err-log-4915ba3fc6c4
Best regards,
Mark Brown broonie@kernel.org
On Fri, 06 Jan 2023 23:13:37 +0000, Mark Brown wrote:
The chances are that any error we see here will be EPROBE_DEFER but let's actually tell the user so they know.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: fsl-asoc-card: Log error code when we fail to register commit: 1a77d59e7e3917e311e91ff2908ef23c3250bec0
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (2)
-
Mark Brown -
Shengjiu Wang