[PATCH 00/11] ASoC: dt-bindings: audio-graph-port related update
Hi ASoC ML, DT ML Cc Geert, Nvidia member
These patches fixups audio-graph-port, and its related DT schema. Audio-Graph-Card and Simple-Audio-Card are similar Card and are sharing same utils. Thus we can also sharing same schema.
Renesas and Nvidia are main user of Audio-Graph-Card.
This patch-set fixup some Renesas's "make dtbs_check".
Geert Uytterhoeven (1): ASoC: dt-bindings: ti,pcm3168a: Convert to json-schema
Kuninori Morimoto (10): ASoC: dt-bindings: audio-graph-port: use definitions for port/endpoint ASoC: dt-bindings: audio-graph-port: add definitions/ports ASoC: dt-bindings: audio-graph-port: add missing mclk-fs ASoC: dt-bindings: audio-graph-port: add clocks on endpoint ASoC: dt-bindings: audio-graph-port: remove prefix ASoC: dt-bindings: nvidia: use audio-graph-port.yaml ports ASoC: dt-bindings: ak4613: enable Of-graph (Audio-Graph-Card) style ASoC: dt-bindings: renesas,rsnd: add missing playback/capture ASoC: dt-bindings: renesas,rsnd: #sound-dai-cells is not mandatory ASoC: dt-bindings: simple-card: add missing #address-cells/#size-cells
.../devicetree/bindings/sound/ak4613.yaml | 7 ++ .../bindings/sound/audio-graph-port.yaml | 65 ++++++++---- .../bindings/sound/nvidia,tegra186-asrc.yaml | 14 +-- .../bindings/sound/nvidia,tegra186-dspk.yaml | 21 ++-- .../sound/nvidia,tegra210-admaif.yaml | 7 +- .../bindings/sound/nvidia,tegra210-adx.yaml | 14 +-- .../bindings/sound/nvidia,tegra210-ahub.yaml | 7 +- .../bindings/sound/nvidia,tegra210-amx.yaml | 16 +-- .../bindings/sound/nvidia,tegra210-dmic.yaml | 21 ++-- .../bindings/sound/nvidia,tegra210-i2s.yaml | 21 ++-- .../bindings/sound/nvidia,tegra210-mixer.yaml | 14 +-- .../bindings/sound/nvidia,tegra210-mvc.yaml | 21 ++-- .../bindings/sound/nvidia,tegra210-ope.yaml | 21 ++-- .../bindings/sound/nvidia,tegra210-sfc.yaml | 21 ++-- .../bindings/sound/renesas,rsnd.yaml | 29 ++++- .../bindings/sound/simple-card.yaml | 4 + .../devicetree/bindings/sound/ti,pcm3168a.txt | 56 ---------- .../bindings/sound/ti,pcm3168a.yaml | 100 ++++++++++++++++++ 18 files changed, 228 insertions(+), 231 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/ti,pcm3168a.txt create mode 100644 Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Audio Graph base driver might need to add its own properties. In such case, having definitions for port/endpoint is easy to handle it. This patch adds definitions for port/endpoint.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- .../bindings/sound/audio-graph-port.yaml | 39 +++++++++++-------- 1 file changed, 22 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 64654ceef208..56d47dcab490 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -11,25 +11,22 @@ maintainers:
select: false
-allOf: - - $ref: /schemas/graph.yaml#/$defs/port-base - -properties: - prefix: - description: "device name prefix" - $ref: /schemas/types.yaml#/definitions/string - convert-rate: - $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-rate" - convert-channels: - $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-channels" - convert-sample-format: - $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-format" +definitions: + port-base: + $ref: /schemas/graph.yaml#/$defs/port-base + properties: + prefix: + description: "device name prefix" + $ref: /schemas/types.yaml#/definitions/string + convert-rate: + $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-rate" + convert-channels: + $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-channels" + convert-sample-format: + $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-format"
-patternProperties: - "^endpoint(@[0-9a-f]+)?": + endpoint-base: $ref: /schemas/graph.yaml#/$defs/endpoint-base - unevaluatedProperties: false - properties: mclk-fs: description: | @@ -100,4 +97,12 @@ patternProperties: minimum: 1 maximum: 64
+allOf: + - $ref: "#/definitions/port-base" + +patternProperties: + "^endpoint(@[0-9a-f]+)?": + $ref: "#/definitions/endpoint-base" + unevaluatedProperties: false + additionalProperties: true
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Audio Graph user needs "ports" not only "port". This patch adds new "ports" on audio-graph-port to use it easily.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- .../devicetree/bindings/sound/audio-graph-port.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 56d47dcab490..273da5a76b8a 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -97,6 +97,18 @@ definitions: minimum: 1 maximum: 64
+ ports: + $ref: "#/definitions/port-base" + unevaluatedProperties: false + patternProperties: + "^port(@[0-9a-f]+)?$": + $ref: "#/definitions/port-base" + unevaluatedProperties: false + patternProperties: + "^endpoint(@[0-9a-f]+)?": + $ref: "#/definitions/endpoint-base" + unevaluatedProperties: false + allOf: - $ref: "#/definitions/port-base"
On Wed, Dec 14, 2022 at 01:22:13AM +0000, Kuninori Morimoto wrote:
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Audio Graph user needs "ports" not only "port". This patch adds new "ports" on audio-graph-port to use it easily.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
.../devicetree/bindings/sound/audio-graph-port.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 56d47dcab490..273da5a76b8a 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -97,6 +97,18 @@ definitions: minimum: 1 maximum: 64
- ports:
- $ref: "#/definitions/port-base"
- unevaluatedProperties: false
- patternProperties:
"^port(@[0-9a-f]+)?$":$ref: "#/definitions/port-base"unevaluatedProperties: falsepatternProperties:"^endpoint(@[0-9a-f]+)?":$ref: "#/definitions/endpoint-base"unevaluatedProperties: false
This won't work because any user that uses 'ports' here cannot add any properties to port or endpoint nodes which I thought was the point of this series.
Rob
Hi Rob
- ports:
- $ref: "#/definitions/port-base"
- unevaluatedProperties: false
- patternProperties:
"^port(@[0-9a-f]+)?$":$ref: "#/definitions/port-base"unevaluatedProperties: falsepatternProperties:"^endpoint(@[0-9a-f]+)?":$ref: "#/definitions/endpoint-base"unevaluatedProperties: falseThis won't work because any user that uses 'ports' here cannot add any properties to port or endpoint nodes which I thought was the point of this series.
Now, we have port-base/endpoint-base on definitions. The user who want to have own properties can reuse it and redefine.
The user who don't use own properties can use above "ports" which is implemented under "definitions". It is for very standard "ports".
By having standard "ports" under "definitions", we can avoid duplicate "ports" IMO.
Thank you for your help !!
Best regards --- Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
audio-graph-port is missing "mclk-fs" on ports/port, it is used not only endpoint. It is already defined on simple-card. This patch fixup it. Without this patch, we will get below warning.
${LINUX}/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports: 'mclk-fs' does not match any of the regexes: '^port@[0-9a-f]+$', 'pinctrl-[0-9]+' From schema: ${LINUX}/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- .../devicetree/bindings/sound/audio-graph-port.yaml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 273da5a76b8a..25f7204c7c4a 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -24,16 +24,14 @@ definitions: $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-channels" convert-sample-format: $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-format" + mclk-fs: + $ref: "simple-card.yaml#/definitions/mclk-fs"
endpoint-base: $ref: /schemas/graph.yaml#/$defs/endpoint-base properties: mclk-fs: - description: | - Multiplication factor between stream rate and codec mclk. - When defined, mclk-fs property defined in dai-link sub nodes are - ignored. - $ref: /schemas/types.yaml#/definitions/uint32 + $ref: "simple-card.yaml#/definitions/mclk-fs" frame-inversion: description: dai-link uses frame clock inversion $ref: /schemas/types.yaml#/definitions/flag
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Audio Graph endpoint is possible to have clock, but it is missing its releated properties on audio-graph-port. It is already defined on simple-card. This patch adds it. Without this patch, we will get below warning
${LINUX}/arch/arm64/boot/dts/renesas/r8a77950-ulcb-kf.dtb: audio-codec@44: ports:port@0:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected) From schema: ${LINUX}/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- .../devicetree/bindings/sound/audio-graph-port.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 25f7204c7c4a..37c20cc8dc36 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -48,6 +48,15 @@ definitions: oneOf: - $ref: /schemas/types.yaml#/definitions/flag - $ref: /schemas/types.yaml#/definitions/phandle + clocks: + description: Indicates system clock + $ref: /schemas/types.yaml#/definitions/phandle + system-clock-frequency: + $ref: "simple-card.yaml#/definitions/system-clock-frequency" + system-clock-direction-out: + $ref: "simple-card.yaml#/definitions/system-clock-direction-out" + system-clock-fixed: + $ref: "simple-card.yaml#/definitions/system-clock-fixed"
dai-format: description: audio format.
On Wed, Dec 14, 2022 at 01:22:58AM +0000, Kuninori Morimoto wrote:
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Audio Graph endpoint is possible to have clock, but it is missing its releated properties on audio-graph-port. It is already defined on simple-card. This patch adds it. Without this patch, we will get below warning
${LINUX}/arch/arm64/boot/dts/renesas/r8a77950-ulcb-kf.dtb: audio-codec@44: ports:port@0:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected) From schema: ${LINUX}/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
.../devicetree/bindings/sound/audio-graph-port.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 25f7204c7c4a..37c20cc8dc36 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -48,6 +48,15 @@ definitions: oneOf: - $ref: /schemas/types.yaml#/definitions/flag - $ref: /schemas/types.yaml#/definitions/phandle
clocks:description: Indicates system clock$ref: /schemas/types.yaml#/definitions/phandle
Is this the standard 'clocks' or you defined your own. Because 'clocks' is not a 'phandle'. It's a phandle+args.
I don't think we should have 'clocks' in endpoint nodes. Or at least we don't want to endorse more cases of it. The graph describes data connections. The only properties on endpoints are properties of that connection. An endpoint can't really consume a clock.
system-clock-frequency:$ref: "simple-card.yaml#/definitions/system-clock-frequency"system-clock-direction-out:$ref: "simple-card.yaml#/definitions/system-clock-direction-out"system-clock-fixed:$ref: "simple-card.yaml#/definitions/system-clock-fixed"
We have standard clock bindings. Whatever you need here should use that instead.
dai-format: description: audio format.-- 2.25.1
Hi Rob
Thank you for your feedback
clocks:description: Indicates system clock$ref: /schemas/types.yaml#/definitions/phandleIs this the standard 'clocks' or you defined your own. Because 'clocks' is not a 'phandle'. It's a phandle+args.
Thanks. I will fix it.
I don't think we should have 'clocks' in endpoint nodes. Or at least we don't want to endorse more cases of it. The graph describes data connections. The only properties on endpoints are properties of that connection. An endpoint can't really consume a clock.
Hmmm.. but, it is already implemented.
system-clock-frequency:$ref: "simple-card.yaml#/definitions/system-clock-frequency"system-clock-direction-out:$ref: "simple-card.yaml#/definitions/system-clock-direction-out"system-clock-fixed:$ref: "simple-card.yaml#/definitions/system-clock-fixed"
(snip)
We have standard clock bindings. Whatever you need here should use that instead.
Audio-Graph-Card and Simple-Audio-Card/Card2 are sharing the code. So, simple-card.yaml is using "definitions" to sharing it. We can avoid duplicate definition ?
Thank you for your help !!
Best regards --- Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Audio Graph port doesn't use prefix. This patch removes it.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 3 --- 1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 37c20cc8dc36..25e9fe9b0df4 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -15,9 +15,6 @@ definitions: port-base: $ref: /schemas/graph.yaml#/$defs/port-base properties: - prefix: - description: "device name prefix" - $ref: /schemas/types.yaml#/definitions/string convert-rate: $ref: "/schemas/sound/dai-params.yaml#/$defs/dai-sample-rate" convert-channels:
From: Geert Uytterhoeven geert+renesas@glider.be
Convert the Texas Instruments PCM3168A Audio Codec Device Tree binding documentation to json-schema.
Add missing properties. Drop unneeded pinctrl properties from example.
Signed-off-by: Geert Uytterhoeven geert+renesas@glider.be Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- .../devicetree/bindings/sound/ti,pcm3168a.txt | 56 ---------- .../bindings/sound/ti,pcm3168a.yaml | 100 ++++++++++++++++++ 2 files changed, 100 insertions(+), 56 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/ti,pcm3168a.txt create mode 100644 Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
diff --git a/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt b/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt deleted file mode 100644 index a02ecaab5183..000000000000 --- a/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt +++ /dev/null @@ -1,56 +0,0 @@ -Texas Instruments pcm3168a DT bindings - -This driver supports both SPI and I2C bus access for this codec - -Required properties: - - - compatible: "ti,pcm3168a" - - - clocks : Contains an entry for each entry in clock-names - - - clock-names : Includes the following entries: - "scki" The system clock - - - VDD1-supply : Digital power supply regulator 1 (+3.3V) - - - VDD2-supply : Digital power supply regulator 2 (+3.3V) - - - VCCAD1-supply : ADC power supply regulator 1 (+5V) - - - VCCAD2-supply : ADC power supply regulator 2 (+5V) - - - VCCDA1-supply : DAC power supply regulator 1 (+5V) - - - VCCDA2-supply : DAC power supply regulator 2 (+5V) - -For required properties on SPI/I2C, consult SPI/I2C device tree documentation - -Optional properties: - - - reset-gpios : Optional reset gpio line connected to RST pin of the codec. - The RST line is low active: - RST = low: device power-down - RST = high: device is enabled - -Examples: - -i2c0: i2c0@0 { - - ... - - pcm3168a: audio-codec@44 { - compatible = "ti,pcm3168a"; - reg = <0x44>; - reset-gpios = <&gpio0 4 GPIO_ACTIVE_LOW>; - clocks = <&clk_core CLK_AUDIO>; - clock-names = "scki"; - VDD1-supply = <&supply3v3>; - VDD2-supply = <&supply3v3>; - VCCAD1-supply = <&supply5v0>; - VCCAD2-supply = <&supply5v0>; - VCCDA1-supply = <&supply5v0>; - VCCDA2-supply = <&supply5v0>; - pinctrl-names = "default"; - pinctrl-0 = <&dac_clk_pin>; - }; -}; diff --git a/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml new file mode 100644 index 000000000000..cb8ce6c6baf5 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml @@ -0,0 +1,100 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,pcm3168a.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments PCM3168A Audio Codec + +maintainers: + - Damien Horsley Damien.Horsley@imgtec.com + +description: + The Texas Instruments PCM3168A is a 24-bit Multi-channel Audio CODEC with + 96/192kHz sampling rate, supporting both SPI and I2C bus access. + +properties: + compatible: + const: ti,pcm3168a + + reg: + maxItems: 1 + + clocks: + items: + - description: System clock input + + clock-names: + items: + - const: scki + + reset-gpios: + items: + - description: | + GPIO line connected to the active-low RST pin of the codec. + RST = low: device power-down + RST = high: device is enabled + + "#sound-dai-cells": + enum: [0, 1] + + VDD1-supply: + description: Digital power supply regulator 1 (+3.3V) + + VDD2-supply: + description: Digital power supply regulator 2 (+3.3V) + + VCCAD1-supply: + description: ADC power supply regulator 1 (+5V) + + VCCAD2-supply: + description: ADC power supply regulator 2 (+5V) + + VCCDA1-supply: + description: DAC power supply regulator 1 (+5V) + + VCCDA2-supply: + description: DAC power supply regulator 2 (+5V) + + ports: + $ref: audio-graph-port.yaml#/definitions/ports + + port: + $ref: audio-graph-port.yaml# + +required: + - compatible + - reg + - clocks + - clock-names + - VDD1-supply + - VDD2-supply + - VCCAD1-supply + - VCCAD2-supply + - VCCDA1-supply + - VCCDA2-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pcm3168a: audio-codec@44 { + compatible = "ti,pcm3168a"; + reg = <0x44>; + reset-gpios = <&gpio0 4 GPIO_ACTIVE_LOW>; + clocks = <&clk_core 42>; + clock-names = "scki"; + VDD1-supply = <&supply3v3>; + VDD2-supply = <&supply3v3>; + VCCAD1-supply = <&supply5v0>; + VCCAD2-supply = <&supply5v0>; + VCCDA1-supply = <&supply5v0>; + VCCDA2-supply = <&supply5v0>; + }; + };
Hi Morimoto-san,
On Wed, Dec 14, 2022 at 2:23 AM Kuninori Morimoto kuninori.morimoto.gx@renesas.com wrote:
From: Geert Uytterhoeven geert+renesas@glider.be
Convert the Texas Instruments PCM3168A Audio Codec Device Tree binding documentation to json-schema.
Add missing properties. Drop unneeded pinctrl properties from example.
Signed-off-by: Geert Uytterhoeven geert+renesas@glider.be Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Thanks for your patch!
You forgot to list the changes you made to my patch: - Refer to audio-graph-port.yaml instead of describing ports and port@[01] subnodes explicitly.
--- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml @@ -0,0 +1,100 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,pcm3168a.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Texas Instruments PCM3168A Audio Codec
+maintainers:
- Damien Horsley Damien.Horsley@imgtec.com
For v2, I had planned
-+ - Damien Horsley Damien.Horsley@imgtec.com ++ - Jaroslav Kysela perex@perex.cz ++ - Takashi Iwai tiwai@suse.com
as Damien's address bounces.
Or perhaps you want to become the maintainer?
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Dec 15, 2022 at 12:03:02PM +0100, Geert Uytterhoeven wrote:
On Wed, Dec 14, 2022 at 2:23 AM Kuninori Morimoto
+maintainers:
- Damien Horsley Damien.Horsley@imgtec.com
For v2, I had planned
-+ - Damien Horsley <Damien.Horsley@imgtec.com> ++ - Jaroslav Kysela <perex@perex.cz> ++ - Takashi Iwai <tiwai@suse.com>
as Damien's address bounces.
I wouldn't do that, I gather the maintainers for DT bindings are supposed to be people who know and care about the specific binding in particular.
Hi Mark,
On Thu, Dec 15, 2022 at 12:47 PM Mark Brown broonie@kernel.org wrote:
On Thu, Dec 15, 2022 at 12:03:02PM +0100, Geert Uytterhoeven wrote:
On Wed, Dec 14, 2022 at 2:23 AM Kuninori Morimoto
+maintainers:
- Damien Horsley Damien.Horsley@imgtec.com
For v2, I had planned
-+ - Damien Horsley <Damien.Horsley@imgtec.com> ++ - Jaroslav Kysela <perex@perex.cz> ++ - Takashi Iwai <tiwai@suse.com>as Damien's address bounces.
I wouldn't do that, I gather the maintainers for DT bindings are supposed to be people who know and care about the specific binding in particular.
Sure. But how can they (still) care, if we cannot reach them? There's no email message from Damien to be found during the past 7 years.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Dec 15, 2022 at 01:10:44PM +0100, Geert Uytterhoeven wrote:
On Thu, Dec 15, 2022 at 12:47 PM Mark Brown broonie@kernel.org wrote:
I wouldn't do that, I gather the maintainers for DT bindings are supposed to be people who know and care about the specific binding in particular.
Sure. But how can they (still) care, if we cannot reach them? There's no email message from Damien to be found during the past 7 years.
The most sensible thing seems to be to allow bindings with no maintainer TBH.
Hi Geert
You forgot to list the changes you made to my patch:
- Refer to audio-graph-port.yaml instead of describing ports and
port@[01] subnodes explicitly.
Oops, thank you for pointing it. It was my fault. One note is that the port@x which it can use is depends on its connection style. Not only [01]. I will fix it.
Sure. But how can they (still) care, if we cannot reach them? There's no email message from Damien to be found during the past 7 years.
The most sensible thing seems to be to allow bindings with no maintainer TBH.
Hmm.. so I will keep current maintainer, so far. We can update it later if need ?
BTH Mark, this patch is included in this patch-set, but it can be stand alone patch if other patch-set were accepted. Is is possible to post this v2 patch as [1/1] ? or do I need [PATCH v2 11/11] ?
Thank you for your help !!
Best regards --- Kuninori Morimoto
Hi Geert
You forgot to list the changes you made to my patch:
- Refer to audio-graph-port.yaml instead of describing ports and
port@[01] subnodes explicitly.
Oops, thank you for pointing it. It was my fault. One note is that the port@x which it can use is depends on its connection style. Not only [01]. I will fix it.
Grr, my fault again. pcm3168a port are indeed fixed.
Thank you for your help !!
Best regards --- Kuninori Morimoto
On Thu, Dec 15, 2022 at 11:48:29PM +0000, Kuninori Morimoto wrote:
BTH Mark, this patch is included in this patch-set, but it can be stand alone patch if other patch-set were accepted. Is is possible to post this v2 patch as [1/1] ? or do I need [PATCH v2 11/11] ?
Just posting it as 1/1 is best - for both patch number and series version the numbering only makes sense within a single series, you can just drop this patch from v2 of the main series and send it separately as just a standalone patch.
On Thu, Dec 15, 2022 at 01:10:44PM +0100, Geert Uytterhoeven wrote:
Hi Mark,
On Thu, Dec 15, 2022 at 12:47 PM Mark Brown broonie@kernel.org wrote:
On Thu, Dec 15, 2022 at 12:03:02PM +0100, Geert Uytterhoeven wrote:
On Wed, Dec 14, 2022 at 2:23 AM Kuninori Morimoto
+maintainers:
- Damien Horsley Damien.Horsley@imgtec.com
For v2, I had planned
-+ - Damien Horsley <Damien.Horsley@imgtec.com> ++ - Jaroslav Kysela <perex@perex.cz> ++ - Takashi Iwai <tiwai@suse.com>as Damien's address bounces.
I wouldn't do that, I gather the maintainers for DT bindings are supposed to be people who know and care about the specific binding in particular.
Sure. But how can they (still) care, if we cannot reach them? There's no email message from Damien to be found during the past 7 years.
Then put someone that would care if the binding is deleted. As this is used on Renesas board(s), I can think of a few candidates.
Rob
Hi Rob,
CC Peter
On Fri, Dec 16, 2022 at 5:39 PM Rob Herring robh@kernel.org wrote:
On Thu, Dec 15, 2022 at 01:10:44PM +0100, Geert Uytterhoeven wrote:
On Thu, Dec 15, 2022 at 12:47 PM Mark Brown broonie@kernel.org wrote:
On Thu, Dec 15, 2022 at 12:03:02PM +0100, Geert Uytterhoeven wrote:
On Wed, Dec 14, 2022 at 2:23 AM Kuninori Morimoto
+maintainers:
- Damien Horsley Damien.Horsley@imgtec.com
For v2, I had planned
-+ - Damien Horsley <Damien.Horsley@imgtec.com> ++ - Jaroslav Kysela <perex@perex.cz> ++ - Takashi Iwai <tiwai@suse.com>as Damien's address bounces.
I wouldn't do that, I gather the maintainers for DT bindings are supposed to be people who know and care about the specific binding in particular.
Sure. But how can they (still) care, if we cannot reach them? There's no email message from Damien to be found during the past 7 years.
Then put someone that would care if the binding is deleted. As this is used on Renesas board(s), I can think of a few candidates.
Or perhaps someone from TI? ;-) This is a TI component, and also used on a TI K3 board...
/me weaseling out...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Oops, Peter is no longer at TI...
On Mon, Dec 19, 2022 at 9:43 AM Geert Uytterhoeven geert@linux-m68k.org wrote:
CC Peter
On Fri, Dec 16, 2022 at 5:39 PM Rob Herring robh@kernel.org wrote:
On Thu, Dec 15, 2022 at 01:10:44PM +0100, Geert Uytterhoeven wrote:
On Thu, Dec 15, 2022 at 12:47 PM Mark Brown broonie@kernel.org wrote:
On Thu, Dec 15, 2022 at 12:03:02PM +0100, Geert Uytterhoeven wrote:
On Wed, Dec 14, 2022 at 2:23 AM Kuninori Morimoto
+maintainers:
- Damien Horsley Damien.Horsley@imgtec.com
For v2, I had planned
-+ - Damien Horsley <Damien.Horsley@imgtec.com> ++ - Jaroslav Kysela <perex@perex.cz> ++ - Takashi Iwai <tiwai@suse.com>as Damien's address bounces.
I wouldn't do that, I gather the maintainers for DT bindings are supposed to be people who know and care about the specific binding in particular.
Sure. But how can they (still) care, if we cannot reach them? There's no email message from Damien to be found during the past 7 years.
Then put someone that would care if the binding is deleted. As this is used on Renesas board(s), I can think of a few candidates.
Or perhaps someone from TI? ;-) This is a TI component, and also used on a TI K3 board...
/me weaseling out...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert,
On 19/12/2022 10:45, Geert Uytterhoeven wrote:
Oops, Peter is no longer at TI...
Yup.
On Mon, Dec 19, 2022 at 9:43 AM Geert Uytterhoeven geert@linux-m68k.org wrote:
CC Peter
On Fri, Dec 16, 2022 at 5:39 PM Rob Herring robh@kernel.org wrote:
On Thu, Dec 15, 2022 at 01:10:44PM +0100, Geert Uytterhoeven wrote:
On Thu, Dec 15, 2022 at 12:47 PM Mark Brown broonie@kernel.org wrote:
On Thu, Dec 15, 2022 at 12:03:02PM +0100, Geert Uytterhoeven wrote:
On Wed, Dec 14, 2022 at 2:23 AM Kuninori Morimoto > +maintainers: > + - Damien Horsley Damien.Horsley@imgtec.com
For v2, I had planned
-+ - Damien Horsley <Damien.Horsley@imgtec.com> ++ - Jaroslav Kysela <perex@perex.cz> ++ - Takashi Iwai <tiwai@suse.com>as Damien's address bounces.
I wouldn't do that, I gather the maintainers for DT bindings are supposed to be people who know and care about the specific binding in particular.
Sure. But how can they (still) care, if we cannot reach them? There's no email message from Damien to be found during the past 7 years.
Then put someone that would care if the binding is deleted. As this is used on Renesas board(s), I can think of a few candidates.
Or perhaps someone from TI? ;-) This is a TI component, and also used on a TI K3 board...
Can it go w/o a Maintainer? ;) The driver is (close to) feature complete and only needs framework change updates. I don't particularly care about this driver as such. Yes, the j721e EVM uses it (which I still maintain along with the TI audio stack).
Unfortunately I don't know anyone at TI who could be assigned...
Nikita did a fix quite recently to the driver. Nikita, are you interested?
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
nvidia,xxx.yaml is using original ports schemas, but we can now use audio-graph-port.yaml#/definitions/ports[-base] for it. This patch switch to use it.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- .../bindings/sound/nvidia,tegra186-asrc.yaml | 14 +++---------- .../bindings/sound/nvidia,tegra186-dspk.yaml | 21 ++++++------------- .../sound/nvidia,tegra210-admaif.yaml | 7 +------ .../bindings/sound/nvidia,tegra210-adx.yaml | 14 +++---------- .../bindings/sound/nvidia,tegra210-ahub.yaml | 7 +------ .../bindings/sound/nvidia,tegra210-amx.yaml | 16 +++----------- .../bindings/sound/nvidia,tegra210-dmic.yaml | 21 ++++++------------- .../bindings/sound/nvidia,tegra210-i2s.yaml | 21 ++++++------------- .../bindings/sound/nvidia,tegra210-mixer.yaml | 14 +++---------- .../bindings/sound/nvidia,tegra210-mvc.yaml | 21 ++++++------------- .../bindings/sound/nvidia,tegra210-ope.yaml | 21 ++++++------------- .../bindings/sound/nvidia,tegra210-sfc.yaml | 21 ++++++------------- 12 files changed, 50 insertions(+), 148 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-asrc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-asrc.yaml index d82415c21271..7ab8dd2fc813 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-asrc.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-asrc.yaml @@ -45,23 +45,15 @@ properties: pattern: "^ASRC[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports + $ref: audio-graph-port.yaml#/definitions/ports description: | ASRC has seven input ports and six output ports. Accordingly ACIF (Audio Client Interfaces) port nodes are defined to represent the ASRC inputs (port 0 to 6) and outputs (port 7 to 12). These are connected to corresponding ports on AHUB (Audio Hub). Additional input (port 6) is for receiving ratio information from estimator. - - patternProperties: - '^port@[0-6]': - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: ASRC ACIF input ports - '^port@[7-9]|1[1-2]': - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: ASRC ACIF output ports + port@[0-6] are ASRC ACIF input ports + port@[7-12] are ASRC ACIF output ports
required: - compatible diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml index 3d538df878ea..6cfd36bf21e8 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml @@ -55,21 +55,12 @@ properties: pattern: "^DSPK[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports - properties: - port@0: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - DSPK ACIF (Audio Client Interface) port connected to the - corresponding AHUB (Audio Hub) ACIF port. - - port@1: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - DSPK DAP (Digital Audio Port) interface which can be connected - to external audio codec for playback. + $ref: audio-graph-port.yaml#/definitions/ports + description: | + port@0 is DSPK ACIF (Audio Client Interface) port connected to the + corresponding AHUB (Audio Hub) ACIF port. + port@1 is DSPK DAP (Digital Audio Port) interface which can be connected + to external audio codec for playback.
required: - compatible diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml index 15ab40aeab1e..82141af47dce 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml @@ -40,7 +40,7 @@ properties: dma-names: true
ports: - $ref: /schemas/graph.yaml#/properties/ports + $ref: audio-graph-port.yaml#/definitions/ports description: | Contains list of ACIF (Audio CIF) port nodes for ADMAIF channels. The number of port nodes depends on the number of ADMAIF channels @@ -48,11 +48,6 @@ properties: in AHUB (Audio Hub). Each port is capable of data transfers in both directions.
- patternProperties: - '^port@[0-9]': - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - if: properties: compatible: diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml index ea0dc0ece1bc..877ab4dea539 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml @@ -42,22 +42,14 @@ properties: pattern: "^ADX[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports + $ref: audio-graph-port.yaml#/definitions/ports description: | ADX has one input and four outputs. Accordingly ACIF (Audio Client Interface) port nodes are defined to represent ADX input (port 0) and outputs (ports 1 to 4). These are connected to corresponding ports on AHUB (Audio Hub). - properties: - port@0: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: ADX ACIF input port - patternProperties: - '^port@[1-4]': - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: ADX ACIF output ports + port@0 is ADX ACIF input port + port@[1-4] are ADX ACIF output ports
required: - compatible diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml index 89f7805de274..a64cd893deb0 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml @@ -58,18 +58,13 @@ properties: ranges: true
ports: - $ref: /schemas/graph.yaml#/properties/ports + $ref: audio-graph-port.yaml#/definitions/ports description: | Contains list of ACIF (Audio CIF) port nodes for AHUB (Audio Hub). These are connected to ACIF interfaces of AHUB clients. Thus the number of port nodes depend on the number of clients that AHUB may have depending on the SoC revision.
- patternProperties: - '^port@[0-9]': - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - patternProperties: '^i2s@[0-9a-f]+$': type: object diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml index 1aff61f072bb..cd5ca38bef75 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml @@ -42,24 +42,14 @@ properties: pattern: "^AMX[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports + $ref: audio-graph-port.yaml#/definitions/ports description: | AMX has four inputs and one output. Accordingly ACIF (Audio Client Interfaces) port nodes are defined to represent AMX inputs (port 0 to 3) and output (port 4). These are connected to corresponding ports on AHUB (Audio Hub). - - patternProperties: - '^port@[0-3]': - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: AMX ACIF input ports - - properties: - port@4: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: AMX ACIF output port + port@[0-3] are AMX ACIF input ports + port@4 is AMX ACIF output port
required: - compatible diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml index 0f9d2b461e02..9166c685ac05 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml @@ -55,21 +55,12 @@ properties: pattern: "^DMIC[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports - properties: - port@0: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - DMIC ACIF (Audio Client Interface) port connected to the - corresponding AHUB (Audio Hub) ACIF port. - - port@1: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - DMIC DAP (Digital Audio Port) interface which can be connected - to external audio codec for capture. + $ref: audio-graph-port.yaml#/definitions/ports + description: | + port@0 is DMIC ACIF (Audio Client Interface) port connected to the + corresponding AHUB (Audio Hub) ACIF port. + port@1 is DMIC DAP (Digital Audio Port) interface which can be connected + to external audio codec for capture.
required: - compatible diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml index 12cd17eede99..f8f71a453575 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml @@ -71,21 +71,12 @@ properties: pattern: "^I2S[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports - properties: - port@0: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - I2S ACIF (Audio Client Interface) port connected to the - corresponding AHUB (Audio Hub) ACIF port. - - port@1: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - I2S DAP (Digital Audio Port) interface which can be connected - to external audio codec for playback or capture. + $ref: audio-graph-port.yaml#/definitions/ports + description: | + port@0 is I2S ACIF (Audio Client Interface) port connected to the + corresponding AHUB (Audio Hub) ACIF port. + port@1 is I2S DAP (Digital Audio Port) interface which can be connected + to external audio codec for playback or capture.
required: - compatible diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml index 570b03282aeb..dd0ba9742c06 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml @@ -40,22 +40,14 @@ properties: pattern: "^MIXER[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports + $ref: audio-graph-port.yaml#/definitions/ports description: | Mixer has ten inputs and five outputs. Accordingly ACIF (Audio Client Interfaces) port nodes are defined to represent Mixer inputs (port 0 to 9) and outputs (port 10 to 14). These are connected to corresponding ports on AHUB (Audio Hub). - - patternProperties: - '^port@[0-9]': - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: Mixer ACIF input ports - '^port@[10-14]': - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: Mixer ACIF output ports + port@[0-9] are Mixer ACIF input ports + port@[10-14] are Mixer ACIF output ports
required: - compatible diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml index 4aecbc847b98..773b00b081fb 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml @@ -43,21 +43,12 @@ properties: pattern: "^MVC[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports - properties: - port@0: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - MVC ACIF (Audio Client Interface) input port. This is connected - to corresponding ACIF output port on AHUB (Audio Hub). - - port@1: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - MVC ACIF output port. This is connected to corresponding ACIF - input port on AHUB. + $ref: audio-graph-port.yaml#/definitions/ports + description: | + port@0 is MVC ACIF (Audio Client Interface) input port. This is connected + to corresponding ACIF output port on AHUB (Audio Hub). + port@1 is MVC ACIF output port. This is connected to corresponding ACIF + input port on AHUB.
required: - compatible diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml index 9dc9ba590fa3..89dff2e961db 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml @@ -45,21 +45,12 @@ properties: pattern: "^OPE[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports - properties: - port@0: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: - OPE ACIF (Audio Client Interface) input port. This is connected - to corresponding ACIF output port on AHUB (Audio Hub). - - port@1: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: - OPE ACIF output port. This is connected to corresponding ACIF - input port on AHUB. + $ref: audio-graph-port.yaml#/definitions/ports + description: | + port@0 is OPE ACIF (Audio Client Interface) input port. This is connected + to corresponding ACIF output port on AHUB (Audio Hub). + port@1: is OPE ACIF output port. This is connected to corresponding ACIF + input port on AHUB.
patternProperties: '^equalizer@[0-9a-f]+$': diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml index 694f890d6305..04c550863d88 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml @@ -40,21 +40,12 @@ properties: pattern: "^SFC[1-9]$"
ports: - $ref: /schemas/graph.yaml#/properties/ports - properties: - port@0: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - SFC ACIF (Audio Client Interface) input port. This is connected - to corresponding ACIF output port on AHUB (Audio Hub). - - port@1: - $ref: audio-graph-port.yaml# - unevaluatedProperties: false - description: | - SFC ACIF output port. This is connected to corresponding ACIF - input port on AHUB. + $ref: audio-graph-port.yaml#/definitions/ports + description: | + port@0 is SFC ACIF (Audio Client Interface) input port. This is connected + to corresponding ACIF output port on AHUB (Audio Hub). + port@1 is SFC ACIF output port. This is connected to corresponding ACIF + input port on AHUB.
required: - compatible
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
ak4613 is possible to use Of-graph (Audio-Graph-Card) style, but we need to indicate it. Otherwise we will get below warning. This patch add it.
${LINUX}/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dtb: codec@10: 'port' does not match any of the regexes: '^asahi-kasei,in[1-2]-single-end$', '^asahi-kasei,out[1-6]-single-end$', 'pinctrl-[0-9]+' From schema: ${LINUX}/Documentation/devicetree/bindings/sound/ak4613.yaml
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- Documentation/devicetree/bindings/sound/ak4613.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/ak4613.yaml b/Documentation/devicetree/bindings/sound/ak4613.yaml index aa8a258a9f1c..99a90095a76d 100644 --- a/Documentation/devicetree/bindings/sound/ak4613.yaml +++ b/Documentation/devicetree/bindings/sound/ak4613.yaml @@ -22,6 +22,13 @@ properties: "#sound-dai-cells": const: 0
+ ports: + $ref: audio-graph-port.yaml#/definitions/ports + + port: + $ref: audio-graph-port.yaml# + unevaluatedProperties: false + patternProperties: "^asahi-kasei,in[1-2]-single-end$": description: Input Pin 1 - 2.
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
renesas,rsnd.yaml is possible to use ports/port/endpoint if it is using Audio Graph Card/Card2 for sound. The schema is defined under audio-graph-port.yaml.
rsnd driver needs "playback/capture" property under endpoint, but it is not defined in audio-graph-port.yaml. This patch adds missing "playback/capture" properties under endpoint.
Without this patch, we will get below warning
${LINUX}/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dtb: sound@ec500000: ports:port@0:endpoint: Unevaluated properties are not allowed ('playback', 'capture' were unexpected) From schema: ${LINUX}/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- .../bindings/sound/renesas,rsnd.yaml | 27 ++++++++++++++++--- 1 file changed, 23 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml index 679a246dd666..637130b7c307 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml @@ -113,15 +113,34 @@ properties: - pattern: '^clk_(a|b|c|i)$'
ports: - $ref: /schemas/graph.yaml#/properties/ports + $ref: audio-graph-port.yaml#/definitions/port-base + unevaluatedProperties: false patternProperties: - port(@[0-9a-f]+)?: - $ref: audio-graph-port.yaml# + "^port(@[0-9a-f]+)?$": + $ref: audio-graph-port.yaml#/definitions/port-base unevaluatedProperties: false + patternProperties: + "^endpoint(@[0-9a-f]+)?": + $ref: audio-graph-port.yaml#/definitions/endpoint-base + properties: + playback: + $ref: /schemas/types.yaml#/definitions/phandle-array + capture: + $ref: /schemas/types.yaml#/definitions/phandle-array + unevaluatedProperties: false
port: - $ref: audio-graph-port.yaml# + $ref: audio-graph-port.yaml#/definitions/port-base unevaluatedProperties: false + patternProperties: + "^endpoint(@[0-9a-f]+)?": + $ref: audio-graph-port.yaml#/definitions/endpoint-base + properties: + playback: + $ref: /schemas/types.yaml#/definitions/phandle-array + capture: + $ref: /schemas/types.yaml#/definitions/phandle-array + unevaluatedProperties: false
rcar_sound,dvc: description: DVC subnode.
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Current renesas,rsnd is requesting #sound-dai-cells, but it is needed in case of it is using "simple-card", but not needed in case of "audio-graph". We will get below warning without this patch. This patch fiup it.
${LINUX}/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dtb: sound@ec500000: '#sound-dai-cells' is a required property From schema: ${LINUX}/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml index 637130b7c307..5dd41838538f 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml @@ -68,6 +68,7 @@ properties: description: | it must be 0 if your system is using single DAI it must be 1 if your system is using multi DAIs + This is used on simple-audio-card enum: [0, 1]
"#clock-cells": @@ -290,7 +291,6 @@ required: - reg-names - clocks - clock-names - - "#sound-dai-cells"
allOf: - if:
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
In case of using MIXer with Simple Audio Card, it needs below DT.
simple-audio-card,dai-link@1 { cpu@0 { ... }; cpu@1 { ... }; ... };
This case, it requires "reg = <xxx>" which needs #address-cells/#size-cells, but simple-audio-card.yaml is missing these. This patch adds it.
Without this patch, we will get below warning.
${LINUX}/arch/arm64/boot/dts/renesas/r8a77950-ulcb.dtb: sound: simple-audio-card,dai-link@0: '#address-cells', '#size-cells' do not match any of the regexes: '^codec(@[0-9a-f]+)?', '^cpu(@[0-9a-f]+)?', 'pinctrl-[0-9]+' From schema: ${LINUX}/Documentation/devicetree/bindings/sound/simple-card.yaml
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- Documentation/devicetree/bindings/sound/simple-card.yaml | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml index ed19899bc94b..a3d06e96205e 100644 --- a/Documentation/devicetree/bindings/sound/simple-card.yaml +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml @@ -215,6 +215,10 @@ patternProperties: reg: maxItems: 1
+ "#address-cells": + const: 1 + "#size-cells": + const: 0 # common properties frame-master: $ref: "#/definitions/frame-master"
participants (5)
-
Geert Uytterhoeven -
Kuninori Morimoto -
Mark Brown -
Péter Ujfalusi -
Rob Herring