[PATCH 0/3] Update lpass dt-bindings
Update va-macro driver dt-bindings and add missing properties in sc7280 machine driver dt-bindings.
Srinivasa Rao Mandadapu (3): ASoC: qcom: dt-bindings: lpass-va-macro: Update clock name ASoC: google: dt-bindings: sc7280: Add platform property ASoC: google: dt-bindings: sc7280: Add #sound-dai-cells property
.../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 14 ++++++++++++++ .../devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-)
Upadte clock name from core to macro in lpass-va-macro node to make it compatible with existing driver and device tree node.
Fixes: 67d99b23c881 ("ASoC: qcom: dt-bindings: add bindings for lpass va macro codec")
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Ratna Deepthi Kudaravalli quic_rkudarv@quicinc.com --- Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml index 26f0343..e468adb 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml @@ -36,7 +36,7 @@ properties: oneOf: - items: #for ADSP based platforms - const: mclk - - const: core + - const: macro - const: dcodec - items: #for ADSP bypass based platforms - const: mclk
On 19/01/2023 07:11, Srinivasa Rao Mandadapu wrote:
Upadte clock name from core to macro in lpass-va-macro node
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
to make it compatible with existing driver and device tree node.
Fixes: 67d99b23c881 ("ASoC: qcom: dt-bindings: add bindings for lpass va macro codec")
Drop blank line,
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Ratna Deepthi Kudaravalli quic_rkudarv@quicinc.com
Reported-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
https://lore.kernel.org/all/838e7657-817c-e5bd-5a45-d852560c7fe1@linaro.org/
Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml index 26f0343..e468adb 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml @@ -36,7 +36,7 @@ properties: oneOf: - items: #for ADSP based platforms - const: mclk
- const: core
- const: macro - const: dcodec - items: #for ADSP bypass based platforms - const: mclk
Best regards, Krzysztof
On Thu, 19 Jan 2023 11:41:12 +0530, Srinivasa Rao Mandadapu wrote:
Upadte clock name from core to macro in lpass-va-macro node to make it compatible with existing driver and device tree node.
Fixes: 67d99b23c881 ("ASoC: qcom: dt-bindings: add bindings for lpass va macro codec")
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Ratna Deepthi Kudaravalli quic_rkudarv@quicinc.com
Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.example.dtb: codec@3370000: clock-names: 'oneOf' conditional failed, one must be fixed: ['mclk', 'core', 'dcodec'] is too long 'macro' was expected From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.example.dtb: codec@3370000: Unevaluated properties are not allowed ('clock-names' was unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1674108674-83...
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Update sc7280 machine driver bindings with platform property for supporting ADSP based platform's DAI links.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Ratna Deepthi Kudaravalli quic_rkudarv@quicinc.com --- .../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml index 869b403..ccf1b1d 100644 --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml @@ -75,6 +75,17 @@ patternProperties:
additionalProperties: false
+ platform: + description: Holds subnode which indicates platform dai. + type: object + properties: + sound-dai: true + + required: + - sound-dai + + additionalProperties: false + required: - link-name - cpu
On 19/01/2023 07:11, Srinivasa Rao Mandadapu wrote:
Update sc7280 machine driver bindings with platform property for supporting ADSP based platform's DAI links.
Subject: ASoC: dt-bindings: google,sc7280-herobrine:
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Ratna Deepthi Kudaravalli quic_rkudarv@quicinc.com
This tested tag is a bit unusual. How were they tested? If dt_bindings_check why this is not the same person as you (submitter)?
.../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml index 869b403..ccf1b1d 100644 --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml @@ -75,6 +75,17 @@ patternProperties:
additionalProperties: false
platform:description: Holds subnode which indicates platform dai.
Neither commit msg nor this here explains why do you need it and what it really represents. Basically description repeats "platform" name of property - there is no single new information.
type: objectproperties:sound-dai: true
maxItems
required:- sound-daiadditionalProperties: false- required: - link-name - cpu
Best regards, Krzysztof
On 1/19/2023 5:43 PM, Krzysztof Kozlowski wrote:
On 19/01/2023 07:11, Srinivasa Rao Mandadapu wrote:
Update sc7280 machine driver bindings with platform property for supporting ADSP based platform's DAI links.
Subject: ASoC: dt-bindings: google,sc7280-herobrine:
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Ratna Deepthi Kudaravalli quic_rkudarv@quicinc.com
This tested tag is a bit unusual. How were they tested? If dt_bindings_check why this is not the same person as you (submitter)?
Okay. Will remove Tested-by tag.
.../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml index 869b403..ccf1b1d 100644 --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml @@ -75,6 +75,17 @@ patternProperties:
additionalProperties: false
platform:description: Holds subnode which indicates platform dai.Neither commit msg nor this here explains why do you need it and what it really represents. Basically description repeats "platform" name of property - there is no single new information.
Will modify accordingly and re-spin.
type: objectproperties:sound-dai: truemaxItems
Sorry. why max items required here?
required:- sound-daiadditionalProperties: falserequired: - link-name - cpuBest regards, Krzysztof
On 20/01/2023 08:36, Srinivasa Rao Mandadapu wrote:
Neither commit msg nor this here explains why do you need it and what it really represents. Basically description repeats "platform" name of property - there is no single new information.
Will modify accordingly and re-spin.
type: objectproperties:sound-dai: truemaxItems
Sorry. why max items required here?
Because we want bindings to be specific.
Best regards, Krzysztof
Update sc7280 machine driver bindings with #sound-dai-cells property. This is to fix dtbs_check errors.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Ratna Deepthi Kudaravalli quic_rkudarv@quicinc.com --- Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml index ccf1b1d..be5c60a 100644 --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml @@ -35,6 +35,9 @@ properties: "#size-cells": const: 0
+ "#sound-dai-cells": + const: 0 + patternProperties: "^dai-link@[0-9a-f]$": description:
On 19/01/2023 07:11, Srinivasa Rao Mandadapu wrote:
Update sc7280 machine driver bindings with #sound-dai-cells property. This is to fix dtbs_check errors.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Ratna Deepthi Kudaravalli quic_rkudarv@quicinc.com
Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml index ccf1b1d..be5c60a 100644 --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml @@ -35,6 +35,9 @@ properties: "#size-cells": const: 0
- "#sound-dai-cells":
- const: 0
That's not correct property for the sound card. Does the sound card exposes DAIs? Who uses these?
patternProperties: "^dai-link@[0-9a-f]$": description:
Best regards, Krzysztof
participants (2)
-
Krzysztof Kozlowski -
Rob Herring -
Srinivasa Rao Mandadapu