[alsa-devel] [PATCH] ALSA: opl3: Delete an error message for a failed memory allocation in snd_opl3_new()
From: Markus Elfring elfring@users.sourceforge.net Date: Sat, 12 Aug 2017 19:54:20 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net --- sound/drivers/opl3/opl3_lib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/drivers/opl3/opl3_lib.c b/sound/drivers/opl3/opl3_lib.c index d5e5b4657b4b..588963d6be28 100644 --- a/sound/drivers/opl3/opl3_lib.c +++ b/sound/drivers/opl3/opl3_lib.c @@ -355,10 +355,8 @@ int snd_opl3_new(struct snd_card *card,
*ropl3 = NULL; opl3 = kzalloc(sizeof(*opl3), GFP_KERNEL); - if (opl3 == NULL) { - snd_printk(KERN_ERR "opl3: cannot allocate\n"); + if (!opl3) return -ENOMEM; - }
opl3->card = card; opl3->hardware = hardware;
On Sat, 12 Aug 2017 20:02:14 +0200, SF Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Sat, 12 Aug 2017 19:54:20 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net
Applied, thanks.
Takashi
participants (2)
-
SF Markus Elfring
-
Takashi Iwai