[alsa-devel] [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers
These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt luis@debethencourt.com --- sound/soc/bcm/bcm2835-i2s.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c index 03fa1cb..8c435be 100644 --- a/sound/soc/bcm/bcm2835-i2s.c +++ b/sound/soc/bcm/bcm2835-i2s.c @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = { {}, };
+MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match); + static struct platform_driver bcm2835_i2s_driver = { .probe = bcm2835_i2s_probe, .driver = {
Luis de Bethencourt luis@debethencourt.com writes:
These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt luis@debethencourt.com
sound/soc/bcm/bcm2835-i2s.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c index 03fa1cb..8c435be 100644 --- a/sound/soc/bcm/bcm2835-i2s.c +++ b/sound/soc/bcm/bcm2835-i2s.c @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = { {}, };
+MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
static struct platform_driver bcm2835_i2s_driver = { .probe = bcm2835_i2s_probe, .driver = { --
It looks like this should go through the asoc tree, but I don't see it in there.
FWIW, it is also:
Acked-by: Eric Anholt eric@anholt.net
On Wed, Oct 14, 2015 at 05:44:46PM -0700, Eric Anholt wrote:
Luis de Bethencourt luis@debethencourt.com writes:
These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt luis@debethencourt.com
sound/soc/bcm/bcm2835-i2s.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c index 03fa1cb..8c435be 100644 --- a/sound/soc/bcm/bcm2835-i2s.c +++ b/sound/soc/bcm/bcm2835-i2s.c @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = { {}, };
+MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
static struct platform_driver bcm2835_i2s_driver = { .probe = bcm2835_i2s_probe, .driver = { --
It looks like this should go through the asoc tree, but I don't see it in there.
FWIW, it is also:
Acked-by: Eric Anholt eric@anholt.net
Hi Eric,
Should I resend adding somebody from the asoc tree to the CC?
Thanks for the review, Luis
participants (2)
-
Eric Anholt -
Luis de Bethencourt