Re: [alsa-devel] [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver
On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe berthe.ab@gmail.com wrote:
Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be applied. We're getting rid of the return value from gpiochip_remove().
this remove all reference to gpio_remove retval in all driver except pinctrl and gpio. the same thing is done for gpio and pinctrl in two different patches.
Signed-off-by: abdoulaye berthe berthe.ab@gmail.com
(...)
I think this patch probably needs to be broken down per-subsystem as it hits all over the map. But let's start requesting ACKs for the individual pieces. Actually I think it will be OK to merge because there is likely not much churn around these code sites.
I'm a bit torn between just wanting a big patch for this hitting drivers/gpio and smaller patches hitting one subsystem at a time. We should be able to hammer this in one switch strike.
arch/arm/common/scoop.c | 10 ++--------
ARM SoC folks, can you ACK this?
arch/mips/txx9/generic/setup.c | 4 ++--
Ralf can you ACK this?
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 3 ++-
Benji, can you ACK this?
arch/sh/boards/mach-x3proto/gpio.c | 6 ++----
Aha noone can ACK this, whatever...
drivers/bcma/driver_gpio.c | 3 ++-
Rafał can you ACK this?
drivers/hid/hid-cp2112.c | 6 ++----
Jiri can you ACK this?
drivers/input/keyboard/adp5588-keys.c | 4 +--- drivers/input/keyboard/adp5589-keys.c | 4 +--- drivers/input/touchscreen/ad7879.c | 10 +++-------
Dmitry can you ACK this?
drivers/leds/leds-pca9532.c | 10 ++-------- drivers/leds/leds-tca6507.c | 7 ++-----
Bryan can you ACK this?
drivers/media/dvb-frontends/cxd2820r_core.c | 10 +++-------
Mauro can you ACK this?
(Hm that looks weird. Mental note to look closer at this.)
drivers/mfd/asic3.c | 3 ++- drivers/mfd/htc-i2cpld.c | 8 +------- drivers/mfd/sm501.c | 17 +++-------------- drivers/mfd/tc6393xb.c | 13 ++++--------- drivers/mfd/ucb1x00-core.c | 8 ++------
Lee/Sam can either of you ACK this?
drivers/pinctrl/pinctrl-abx500.c | 15 +++------------ drivers/pinctrl/pinctrl-exynos5440.c | 6 +----- drivers/pinctrl/pinctrl-msm.c | 10 +++------- drivers/pinctrl/pinctrl-nomadik.c | 2 +- drivers/pinctrl/pinctrl-samsung.c | 14 ++++----------
Abdoulaye: these should be in the other patch for pinctrl.
drivers/platform/x86/intel_pmic_gpio.c | 3 +--
Matthew can you ACK this?
drivers/ssb/driver_gpio.c | 3 ++-
Michael can you (A) ACK this and (B) think of moving this driver to drivers/gpio... Patches welcome.
drivers/staging/vme/devices/vme_pio2_gpio.c | 4 +--- drivers/tty/serial/max310x.c | 10 ++++------
Greg can you ACK this?
drivers/video/fbdev/via/via-gpio.c | 10 +++-------
Tomi can you ACK this?
sound/soc/codecs/wm5100.c | 5 +---- sound/soc/codecs/wm8903.c | 6 +----- sound/soc/codecs/wm8962.c | 5 +---- sound/soc/codecs/wm8996.c | 6 +-----
Liam || Mark can you ACK this?
Yours, Linus Walleij
On Tue, Jul 22, 2014 at 05:08:13PM +0200, Linus Walleij wrote:
Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be applied. We're getting rid of the return value from gpiochip_remove().
Can someone send the patch please? Splitting it up per-subsystem would probably be easier...
On Tue, Jul 22, 2014 at 5:11 PM, Mark Brown broonie@kernel.org wrote:
On Tue, Jul 22, 2014 at 05:08:13PM +0200, Linus Walleij wrote:
Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be applied. We're getting rid of the return value from gpiochip_remove().
Can someone send the patch please? Splitting it up per-subsystem would probably be easier...
OK Abdoulaye maybe we can do it a piece at a time?
I have removed the __must_check attribute from gpiochip_remove() in the gpiolib, so the compiler won't complain about this being missing anymore as of kernel v3.17. I also dropped the check in the GPIO and pin control subsystem, and other subsystems can start dropping the checks too if they are OK with the build warnings from the kautobuild until the __must_check removal has propagated upstream.
Yours, Linus Walleij
On Tue, 22 Jul 2014 17:08:13 +0200 Linus Walleij linus.walleij@linaro.org wrote:
drivers/ssb/driver_gpio.c | 3 ++-
Michael can you (A) ACK this and
Acked-by: Michael Büsch m@bues.ch
(B) think of moving this driver to drivers/gpio... Patches welcome.
This is not that easy, as it is not a driver on its own, but integral part of ssb. I don't think it's a good idea to move it out.
I'll accept well tested patches, though.
On Tue, 22 Jul 2014, Linus Walleij wrote:
On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe berthe.ab@gmail.com wrote:
Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be applied. We're getting rid of the return value from gpiochip_remove().
this remove all reference to gpio_remove retval in all driver except pinctrl and gpio. the same thing is done for gpio and pinctrl in two different patches.
Signed-off-by: abdoulaye berthe berthe.ab@gmail.com
(...)
I think this patch probably needs to be broken down per-subsystem as it hits all over the map. But let's start requesting ACKs for the individual pieces. Actually I think it will be OK to merge because there is likely not much churn around these code sites.
I'm a bit torn between just wanting a big patch for this hitting drivers/gpio and smaller patches hitting one subsystem at a time. We should be able to hammer this in one switch strike.
It would be better if you could devise a plan to make the switch a subsystem at a time.
[...]
drivers/mfd/asic3.c | 3 ++- drivers/mfd/htc-i2cpld.c | 8 +------- drivers/mfd/sm501.c | 17 +++-------------- drivers/mfd/tc6393xb.c | 13 ++++--------- drivers/mfd/ucb1x00-core.c | 8 ++------
Lee/Sam can either of you ACK this?
I don't see any code?
On Tue, Jul 22, 2014 at 05:08:13PM +0200, Linus Walleij wrote:
On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe berthe.ab@gmail.com wrote:
Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be applied. We're getting rid of the return value from gpiochip_remove().
this remove all reference to gpio_remove retval in all driver except pinctrl and gpio. the same thing is done for gpio and pinctrl in two different patches.
Signed-off-by: abdoulaye berthe berthe.ab@gmail.com
(...)
I think this patch probably needs to be broken down per-subsystem as it hits all over the map. But let's start requesting ACKs for the individual pieces. Actually I think it will be OK to merge because there is likely not much churn around these code sites.
I'm a bit torn between just wanting a big patch for this hitting drivers/gpio and smaller patches hitting one subsystem at a time. We should be able to hammer this in one switch strike.
...
drivers/input/keyboard/adp5588-keys.c | 4 +--- drivers/input/keyboard/adp5589-keys.c | 4 +--- drivers/input/touchscreen/ad7879.c | 10 +++-------
Dmitry can you ACK this?
Acked-by: Dmitry Torokhov dmitry.torokhov@gmail.com
Em Tue, 22 Jul 2014 17:08:13 +0200 Linus Walleij linus.walleij@linaro.org escreveu:
On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe berthe.ab@gmail.com wrote:
Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be applied. We're getting rid of the return value from gpiochip_remove().
this remove all reference to gpio_remove retval in all driver except pinctrl and gpio. the same thing is done for gpio and pinctrl in two different patches.
Signed-off-by: abdoulaye berthe berthe.ab@gmail.com
(...)
I think this patch probably needs to be broken down per-subsystem as it hits all over the map. But let's start requesting ACKs for the individual pieces. Actually I think it will be OK to merge because there is likely not much churn around these code sites.
I'm a bit torn between just wanting a big patch for this hitting drivers/gpio and smaller patches hitting one subsystem at a time. We should be able to hammer this in one switch strike.
...
drivers/media/dvb-frontends/cxd2820r_core.c | 10 +++-------
Mauro can you ACK this?
Acked-by: Mauro Carvalho Chehab m.chehab@samsung.com
(Hm that looks weird. Mental note to look closer at this.)
What's weird there?
Regards, Mauro
On 22/07/14 18:08, Linus Walleij wrote:
On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe berthe.ab@gmail.com wrote:
Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be applied. We're getting rid of the return value from gpiochip_remove().
drivers/video/fbdev/via/via-gpio.c | 10 +++-------
Tomi can you ACK this?
Acked-by: Tomi Valkeinen tomi.valkeinen@ti.com
Tomi
participants (7)
-
Dmitry Torokhov -
Lee Jones -
Linus Walleij -
Mark Brown -
Mauro Carvalho Chehab -
Michael Büsch -
Tomi Valkeinen