[alsa-devel] Patch - ESI Maya44 driver
Hi Takashi,
here's the maya44 patch.
This is a patch against the current alsa-kernel tree.
I did add 2 definitions to ice1712.h (snd_ice1724_get_route_val and snd_ice1724_put_route_val), which allowed me to move some of the maya44 specific code to maya44.c .
There are still a few maya44 special cases in ice1724.c, because maya44 uses the "con" channel and routing switches differently. This is not really clean style I think, but I would suggest sorting this out later, as it would again require larger changes to ice1724.c and testing with other hardware.
Hope everything is ok with you, for now.
This patch does *not* limit the sampling rate to 96kHz for capture, as discussed before.
best regards, -Rainer
At Fri, 21 Mar 2008 12:27:49 +0100, Rainer Zimmermann wrote:
Hi Takashi,
here's the maya44 patch.
This is a patch against the current alsa-kernel tree.
Thanks. This looks better than the previous version.
I did add 2 definitions to ice1712.h (snd_ice1724_get_route_val and snd_ice1724_put_route_val), which allowed me to move some of the maya44 specific code to maya44.c .
We could do it in a bit cleaer way, but I think it's OK as is.
There are still a few maya44 special cases in ice1724.c, because maya44 uses the "con" channel and routing switches differently. This is not really clean style I think, but I would suggest sorting this out later, as it would again require larger changes to ice1724.c and testing with other hardware.
Agreed. This kind of clean up can be done later.
Hope everything is ok with you, for now.
This patch does *not* limit the sampling rate to 96kHz for capture, as discussed before.
The patch looks apparently not compliant to the kernel coding style. Could you fix at least the issues reported by checkpatch.pl (the latest one)?
thanks,
Takashi
Hi Takashi,
sorry about this. here's the fixed patch, identical to the last except for the coding style fixes.
-Rainer
Takashi Iwai wrote:
At Fri, 21 Mar 2008 12:27:49 +0100, Rainer Zimmermann wrote:
Hi Takashi,
here's the maya44 patch.
This is a patch against the current alsa-kernel tree.
Thanks. This looks better than the previous version.
I did add 2 definitions to ice1712.h (snd_ice1724_get_route_val and snd_ice1724_put_route_val), which allowed me to move some of the maya44 specific code to maya44.c .
We could do it in a bit cleaer way, but I think it's OK as is.
There are still a few maya44 special cases in ice1724.c, because maya44 uses the "con" channel and routing switches differently. This is not really clean style I think, but I would suggest sorting this out later, as it would again require larger changes to ice1724.c and testing with other hardware.
Agreed. This kind of clean up can be done later.
Hope everything is ok with you, for now.
This patch does *not* limit the sampling rate to 96kHz for capture, as discussed before.
The patch looks apparently not compliant to the kernel coding style. Could you fix at least the issues reported by checkpatch.pl (the latest one)?
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Will be the patch finally included to alsa?
2008/3/28, Rainer Zimmermann mail@lightshed.de:
Hi Takashi,
sorry about this. here's the fixed patch, identical to the last except for the coding style fixes.
-Rainer
Takashi Iwai wrote:
At Fri, 21 Mar 2008 12:27:49 +0100, Rainer Zimmermann wrote:
Hi Takashi,
here's the maya44 patch.
This is a patch against the current alsa-kernel tree.
Thanks. This looks better than the previous version.
I did add 2 definitions to ice1712.h (snd_ice1724_get_route_val and
snd_ice1724_put_route_val), which allowed me to move some of the maya44 specific code to maya44.c .
We could do it in a bit cleaer way, but I think it's OK as is.
There are still a few maya44 special cases in ice1724.c, because maya44
uses the "con" channel and routing switches differently. This is not really clean style I think, but I would suggest sorting this out later, as it would again require larger changes to ice1724.c and testing with other hardware.
Agreed. This kind of clean up can be done later.
Hope everything is ok with you, for now.
This patch does *not* limit the sampling rate to 96kHz for capture, as discussed before.
The patch looks apparently not compliant to the kernel coding style. Could you fix at least the issues reported by checkpatch.pl (the latest one)?
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-- Lightshed IT Services Löfflerstr. 27, 22765 Hamburg, Germany * mail@lightshed.de * www.lightshed.de
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Fri, 28 Mar 2008 22:07:53 +0100, Rainer Zimmermann wrote:
Hi Takashi,
sorry about this. here's the fixed patch, identical to the last except for the coding style fixes.
Thanks for the revised patch and sorry for long delay (as I've been on vacation).
The patch looks almost fine. There are some minor issues but they can be fixed after the merge, too.
Could you give the proper changelog and your sign-off for merge? (You might have already given but I'm too lazy to dig to the archive ;)
thanks,
Takashi
Hi,
Is there anybody who could integrate the MAYA44 driver with ALSA? Rainer does not respond and I don't know what's going on. Maya44 driver should be integrated as soon as possible because of the improvements in the ice-1724 code. Anybody interested?
On Mon, Apr 14, 2008 at 12:43 PM, Takashi Iwai tiwai@suse.de wrote:
At Fri, 28 Mar 2008 22:07:53 +0100, Rainer Zimmermann wrote:
Hi Takashi,
sorry about this. here's the fixed patch, identical to the last except
for the
coding style fixes.
Thanks for the revised patch and sorry for long delay (as I've been on vacation).
The patch looks almost fine. There are some minor issues but they can be fixed after the merge, too.
Could you give the proper changelog and your sign-off for merge? (You might have already given but I'm too lazy to dig to the archive ;)
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Fri, 9 May 2008 09:22:13 +0200, Piotr Zaryk wrote:
Hi,
Is there anybody who could integrate the MAYA44 driver with ALSA? Rainer does not respond and I don't know what's going on. Maya44 driver should be integrated as soon as possible because of the improvements in the ice-1724 code. Anybody interested?
Such a big patch cannot be merged to the upstream without a proper sign-off. I mailed Rainer again but no response yet, unfortunately.
Takashi
On Mon, Apr 14, 2008 at 12:43 PM, Takashi Iwai tiwai@suse.de wrote:
At Fri, 28 Mar 2008 22:07:53 +0100, Rainer Zimmermann wrote:
Hi Takashi,
sorry about this. here's the fixed patch, identical to the last except
for the
coding style fixes.
Thanks for the revised patch and sorry for long delay (as I've been on vacation).
The patch looks almost fine. There are some minor issues but they can be fixed after the merge, too.
Could you give the proper changelog and your sign-off for merge? (You might have already given but I'm too lazy to dig to the archive ;)
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-- Piotr Zaryk _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (3)
-
Piotr Zaryk -
Rainer Zimmermann -
Takashi Iwai