[alsa-devel] [PATCH 00/16] constify copied structure
Make const static structures that are just copied into other structures.
The semantic patch that detects the opportunity for this change is as follows: (http://coccinelle.lip6.fr/)
<smpl> @r disable optional_qualifier@ identifier i,j; position p; @@ static struct i j@p = { ... };
@upd@ position p1; identifier r.j; expression e; @@ e = j@p1
@ref@ position p2 != {r.p,upd.p1}; identifier r.j; @@ j@p2
@script:ocaml depends on upd && !ref@ i << r.i; j << r.j; p << r.p; @@ if j = (List.hd p).current_element then Coccilib.print_main i p </smpl>
---
arch/powerpc/sysdev/mpic.c | 4 ++-- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +- drivers/media/i2c/mt9v111.c | 2 +- drivers/media/platform/davinci/isif.c | 2 +- drivers/media/usb/cx231xx/cx231xx-dvb.c | 2 +- drivers/media/usb/dvb-usb-v2/anysee.c | 4 ++-- drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 +- drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 2 +- drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 2 +- drivers/ptp/ptp_clockmatrix.c | 2 +- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +- drivers/video/fbdev/sa1100fb.c | 2 +- net/sunrpc/xdr.c | 2 +- sound/isa/ad1816a/ad1816a_lib.c | 2 +- sound/pci/hda/hda_controller.c | 2 +- sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +- 16 files changed, 18 insertions(+), 18 deletions(-)
The snd_ad1816a_timer_table structure is only copied into another structure, so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall Julia.Lawall@inria.fr
--- sound/isa/ad1816a/ad1816a_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/isa/ad1816a/ad1816a_lib.c b/sound/isa/ad1816a/ad1816a_lib.c index e1aa5372c483..da6f68b8c248 100644 --- a/sound/isa/ad1816a/ad1816a_lib.c +++ b/sound/isa/ad1816a/ad1816a_lib.c @@ -409,7 +409,7 @@ static int snd_ad1816a_timer_stop(struct snd_timer *timer) return 0; }
-static struct snd_timer_hardware snd_ad1816a_timer_table = { +static const struct snd_timer_hardware snd_ad1816a_timer_table = { .flags = SNDRV_TIMER_HW_AUTO, .resolution = 10000, .ticks = 65535,
On Wed, 01 Jan 2020 08:43:19 +0100, Julia Lawall wrote:
The snd_ad1816a_timer_table structure is only copied into another structure, so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall Julia.Lawall@inria.fr
Applied, thanks.
Takashi
The azx_pcm_hw structure is only copied into another structure, so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall Julia.Lawall@inria.fr
--- sound/pci/hda/hda_controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c index a74c85867eb3..9757667cdd58 100644 --- a/sound/pci/hda/hda_controller.c +++ b/sound/pci/hda/hda_controller.c @@ -548,7 +548,7 @@ static int azx_get_time_info(struct snd_pcm_substream *substream, return 0; }
-static struct snd_pcm_hardware azx_pcm_hw = { +static const struct snd_pcm_hardware azx_pcm_hw = { .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
On Wed, 01 Jan 2020 08:43:20 +0100, Julia Lawall wrote:
The azx_pcm_hw structure is only copied into another structure, so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall Julia.Lawall@inria.fr
Applied now. Thanks.
Takashi
The q6asm_dai_hardware_capture structure is only copied into another structure, so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall Julia.Lawall@inria.fr
--- sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c index 5e2327708772..c0d422d0ab94 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -72,7 +72,7 @@ struct q6asm_dai_data { long long int sid; };
-static struct snd_pcm_hardware q6asm_dai_hardware_capture = { +static const struct snd_pcm_hardware q6asm_dai_hardware_capture = { .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDRV_PCM_INFO_MMAP_VALID |
The patch
ASoC: qdsp6: q6asm-dai: constify copied structure
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 0da390ba86d841b1f9770c0a67bdebb4d8dc8be5 Mon Sep 17 00:00:00 2001
From: Julia Lawall Julia.Lawall@inria.fr Date: Wed, 1 Jan 2020 08:43:28 +0100 Subject: [PATCH] ASoC: qdsp6: q6asm-dai: constify copied structure
The q6asm_dai_hardware_capture structure is only copied into another structure, so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall Julia.Lawall@inria.fr Link: https://lore.kernel.org/r/1577864614-5543-11-git-send-email-Julia.Lawall@inr... Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c index 5e2327708772..c0d422d0ab94 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -72,7 +72,7 @@ struct q6asm_dai_data { long long int sid; };
-static struct snd_pcm_hardware q6asm_dai_hardware_capture = { +static const struct snd_pcm_hardware q6asm_dai_hardware_capture = { .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDRV_PCM_INFO_MMAP_VALID |
participants (3)
-
Julia Lawall -
Mark Brown -
Takashi Iwai